From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web11.35868.1591015005779817003 for ; Mon, 01 Jun 2020 05:36:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=pp0ZJSVb; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id g10so2909890wmh.4 for ; Mon, 01 Jun 2020 05:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hcXREFQkmTFiODZyPkv7pM74HXYl3EP8+/MnlDJatzk=; b=pp0ZJSVb5OLH15qzxeU7BHZbs0aL++EjrpYyGsggGt02aHX94TuCyCywfEdahv75EE qri/85xSwSNbXEKwcUKh/Angm9uIA4/IGTY4wF3XAzbcRCtVvZ3UUv4WOLxABir5nirV VNVNOpwVJpuzAMTv6v/f/MmeBHBlyfL4m7MSkOoyUywMHpf6tUg6/1myRKB2N9Jh3LlN sRPBiP8VKkaCJR+1QasXZhZQ8Se/3WaCRf1KO1/dSUAAbbuNxRmFgdX0Lk1OMPHvmlDv nr3kg3qQYtjSdpgd1NWZnJIq6fd5Lu7aOWMcBK918tWT+4i2vBv8Kh9oUCKNRm2ksx99 ok3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hcXREFQkmTFiODZyPkv7pM74HXYl3EP8+/MnlDJatzk=; b=IbO+ZNV29nRY949FCmIfKPZA1VcBhoxuFQDtem4ymmng97MoSOM8PLfTNNxN7yYijg DuIhxa0NJ35JCxEwLZOPTEf7E+06ZtNEE+Rh0M1PX7V+Mo9BiXc8M0uBPGpLPT8khQyz Qov+zbVFgtnMY8Gp0tOLojBCu6kUwX2bR3xpwv5rXdNPaiRh3XSd6ugTtEWXhzijB7ud cll0pkUWXWSsMLYe2Wkplcv9I89obDmddGZkp5JtZ7Bi0O7u4cHSkd8srDaWIOr0dS5A TiWhYlRknW6tS/JJGku2yCnOMgQqkECBiMRtLl2xUBsqumgWQZx8/KDKWiu10QZXI9/T Hsrg== X-Gm-Message-State: AOAM533iBxqzbECm08YXPHFxQVGtKrbdhV1bWUjF7pIrQJti25B+eg3W dtWPRWsAqYdXY95Wux33NFm6Pg== X-Google-Smtp-Source: ABdhPJyHC1eggwqvR7tdKVbMMPcLtXrofHF4Ddh3qGQEzgbmDfe/EsrME/PompaB3d9cWDZ1NsoLcg== X-Received: by 2002:a05:600c:2183:: with SMTP id e3mr2443202wme.0.1591015004222; Mon, 01 Jun 2020 05:36:44 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id f71sm7059752wmf.22.2020.06.01.05.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 05:36:43 -0700 (PDT) Date: Mon, 1 Jun 2020 13:36:41 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, jon@solid-run.com, Laszlo Ersek , Ray Ni , Zhichao Gao Subject: Re: [PATCH v2 4/5] ArmPkg/PlatformBootManagerLib: hide UEFI Shell as a regular boot option Message-ID: <20200601123641.GE28566@vanye> References: <20200528091741.14610-1-ard.biesheuvel@arm.com> <20200528091741.14610-5-ard.biesheuvel@arm.com> <20200601120154.GD28566@vanye> <8ac36435-18eb-4a22-5871-75b5dd3a4415@arm.com> MIME-Version: 1.0 In-Reply-To: <8ac36435-18eb-4a22-5871-75b5dd3a4415@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 01, 2020 at 14:08:18 +0200, Ard Biesheuvel wrote: > On 6/1/20 2:01 PM, Leif Lindholm wrote: > > On Thu, May 28, 2020 at 11:17:40 +0200, Ard Biesheuvel wrote: > > > Without ConnectAll() being called on the boot path, the UEFI shell will > > > be entered with no block devices or anything else connected, and so for > > > the novice user, this is not a very accommodating environment. Now that > > > we have made the UiApp the last resort on boot failure, and made the > > > UEFI Shell accessible directly via the 's' hotkey if you really need > > > it, let's hide it as an ordinary boot option. > > > > Am I being confused here, or is the word "hide" a bit unfortunate in > > the above sentence? (It'll still be visible in the UiApp menu, right?) > > > > Ah yes, the wording is slightly off now that the UEFI shell is being kept > accessible via the boot manager menu rather than via a completely separate > root menu option and form. Right. Well, with that addessed - for all of the set (apart from the MdeModulePkg one, which has an ACK): Reviewed-by: Leif Lindholm > > > > > > Signed-off-by: Ard Biesheuvel > > > --- > > > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > > > index 85cb32f6d7cd..1e9b736993d0 100644 > > > --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > > > +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > > > @@ -777,9 +777,7 @@ PlatformBootManagerAfterConsole ( > > > // > > > Key.ScanCode = SCAN_NULL; > > > Key.UnicodeChar = L's'; > > > - PlatformRegisterFvBootOption ( > > > - &gUefiShellFileGuid, L"UEFI Shell", LOAD_OPTION_ACTIVE, &Key > > > - ); > > > + PlatformRegisterFvBootOption (&gUefiShellFileGuid, L"UEFI Shell", 0, &Key); > > > } > > > /** > > > -- > > > 2.17.1 > > > >