From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (EUR03-DB5-obe.outbound.protection.outlook.com []) by mx.groups.io with SMTP id smtpd.web12.37177.1591018565558875974 for ; Mon, 01 Jun 2020 06:36:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=gewv5XBW; spf=fail (domain: oss.nxp.com, ip: , mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RqOLMYXWdkDpxPdh62uNdRxVSePQJx6TJ4aPqcZI4CjIn4poFARKVMUIuPKuTXMPWRd8PkKHZR37X0OgBnO6c68se2rStTgYTaQ8vgGybf7uChE1A9QajMg1YqOT4biOh3i0zZxpaB+3F4oq1ELuGNSHvp7PWYzWsZ06msyZ1jiUsmBSlpqTaj9C5uofv11203BDhTF2GVFqprVM2SHrAQ2DnqdK0YiQynbvAt4wwjWynzgPkA7w2cvNPt86rw9LdWKVoiiFbUhutCtoXNu4nNgJMudggjRePArNaoMedpMPGBxoK3+eK1bzaFjRo9Dl5vprl0VPBj+t+hUxEIJWuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nd+VrdwPX9Qt2j0HiGQWYao8A20F5V807URbJZhIq2U=; b=XJNbkL8BFwAKvj0PL4PkGp24y7JGVPdrHuDv5Z2essc47g44UGbFsgARLexXZn7Dl01d34ZvIN1q5qrkdjiCDYeknvvsYS0MLYxlqpSy69wTZsbddNeWF2TUr5iBfrBikSTauQWOsAVF1yEDtEQW3jcdxVjNglAxxwRM9cTy5qX5Vdke3GP60UousUcjvFApYmvqJl3lzc+83TCT9wXL4O+6R/nQPvJgMYpZL0QCjPvaTPP6m7QXi+vg1ZKaNgvZ1zzv1YOA53rZBbi8k7xnQ9A4uDz7aljgJH7uRN9Zu8gQvKOPeyQRuA1RZQzDO9H3HOC+INud15gK84Gw9INAiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nd+VrdwPX9Qt2j0HiGQWYao8A20F5V807URbJZhIq2U=; b=gewv5XBWhbVJBjmcrlokt6Lui8XuUW+pbovXWfVkezPvggjJuAWUIreGKs9ZsQrny3kH0z0lhEqRl0fVVJgVyH1+8jkahjjv3aNJhvFbiSKOT8H6UJUpRUoj4B/8KlYCYmfJ0vn4NpeVi3qK8oB7jy4oGk1/7BfBRRDbyfL9EQ0= Authentication-Results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=oss.nxp.com; Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) by VI1PR04MB6096.eurprd04.prod.outlook.com (2603:10a6:803:f6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Mon, 1 Jun 2020 13:36:08 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513%7]) with mapi id 15.20.3045.024; Mon, 1 Jun 2020 13:36:08 +0000 From: "Pankaj Bansal" To: Leif Lindholm , Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton , Ard Biesheuvel Subject: [PATCH edk2-platforms v4 03/10] Silicon/NXP/PciHostBridgeLib: Fix compilation with MDEPKG_NDEBUG flag Date: Mon, 1 Jun 2020 19:04:32 +0530 Message-ID: <20200601133439.5711-4-pankaj.bansal@oss.nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200601133439.5711-1-pankaj.bansal@oss.nxp.com> References: <20200601133439.5711-1-pankaj.bansal@oss.nxp.com> X-ClientProxiedBy: SG2PR02CA0097.apcprd02.prod.outlook.com (2603:1096:4:92::13) To VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) Return-Path: pankaj.bansal@oss.nxp.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from uefi-workstation.ap.freescale.net (92.120.0.69) by SG2PR02CA0097.apcprd02.prod.outlook.com (2603:1096:4:92::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17 via Frontend Transport; Mon, 1 Jun 2020 13:36:05 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [92.120.0.69] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8c77f866-b261-4d32-4bf5-08d80630bda4 X-MS-TrafficTypeDiagnostic: VI1PR04MB6096: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:152; X-Forefront-PRVS: 0421BF7135 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +Yt31LsZG6O7X6HmmeecyXZG4YyJKo4k9DXx3ftiyjt5AVf+qtAxxMvmGY6jQbGrFeQpaCZFnrC7vIm/AkO03q/INyDg8i8BX4ej8RdoNIurf1uaIUDzhWD910p5xaRgsKBv/U/POl4GkYsmkZdo0nbJUeutq0CVJbeTHvb7mIfnWZh7tmcyG4Q5n81OW9f9Rx/gefbcwRvqxVrQx9CAZL/+AyXmlgM2F2gydC3kmezvcU+Z+ch7zh5MjvNQG+sCoNfxZ9ZLSkvbqIKOrE2k1QZmzUMte+OdqaGMVcje20OPiecKilctjOISOrObtybziQWlIg/Flq+El3sDPZihnw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(376002)(346002)(396003)(136003)(39860400002)(110136005)(1076003)(316002)(86362001)(6666004)(44832011)(16526019)(478600001)(6506007)(26005)(6512007)(186003)(6486002)(52116002)(956004)(66556008)(66476007)(66946007)(2906002)(2616005)(5660300002)(8936002)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: hmYMlFyKeesII6uLfwc10Z4R8TyjmF2LY/9xJWQmEbSu9ORjqiIPDnlM89hFl0RJecxShxUY948wYQin0z+PR7A1klZoaou+QuZumhnOferd66WWzSy3e2nxFmHoDmj5rAHbTRZyWksrE/An0towrfikXah5FMIwQG+P9cbq1a21hAjWEAOCKH2lOqffrf4Uew9hNT6U39+2Ito6Qj1XnpIz89Vqrt1v0berANcMwtxwwedLym3Frg1D5ED2Bs+TtaR588GQcK5PL1kxdBt3GIyrRaKvX04tpTjeZWq76NuFynBzOf3lC9ZNENaIGVFF9E5f+fSOiNAkFhu/PgYQh93KQKgjTP8e4pRRi8kg1LW5oM+g4aKfDTnY07BUnO3DJ+ywcELVW1nQll/C3yDgkE+0Hzli0aFeoh4tRVK/SzkeQJrsfBEX9Ii3yD6+wFH9FMRdPBS/g83KZqOxdSiL4rl+K5YQSG7WD29tJ56mL2I= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c77f866-b261-4d32-4bf5-08d80630bda4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2020 13:36:08.6820 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4IT1IY9Ol5Ls99jXZ5BohhKik5Qfdn9c3UhBiMIJo33bh5x/3EK6Zb3MI+A0ZVb1ggOnPUGNi7Q11Wnfq+eN1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6096 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Pankaj Bansal when MDEPKG_NDEBUG flag is enabled, RELEASE build fails with this error: error: mPciHostBridgeLibAcpiAddressSpaceTypeStr defined but not used [-Werror=3Dunused-variable] Fix this error by protecting mPciHostBridgeLibAcpiAddressSpaceTypeStr with MDEPKG_NDEBUG macro. Suggested-by: Leif Lindholm Signed-off-by: Pankaj Bansal --- Notes: V4: - No change =20 V3: - New commit =20 V2: - No change Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c b/Sili= con/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c index 549f4fa133fb..e5309a4f4248 100644 --- a/Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c +++ b/Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c @@ -167,11 +167,13 @@ STATIC CONST EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mEfiPciR= ootBridgeDevicePath[] =3D { } }; =20 +#ifndef MDEPKG_NDEBUG STATIC GLOBAL_REMOVE_IF_UNREFERENCED CHAR16 *mPciHostBridgeLibAcpiAddressSpaceTypeStr[] =3D { L"Mem", L"I/O", L"Bus" }; +#endif =20 #define PCI_ALLOCATION_ATTRIBUTES EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PM= EM | \ EFI_PCI_HOST_BRIDGE_MEM64_DECODE --=20 2.17.1