From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web10.11808.1591107779311512840 for ; Tue, 02 Jun 2020 07:22:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=e3bWkWvZ; spf=pass (domain: nuviainc.com, ip: 209.85.128.65, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f65.google.com with SMTP id d128so3344404wmc.1 for ; Tue, 02 Jun 2020 07:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VNH7DCEdEff0K5J8Zwzsfyd07P/AkRgXurE5638GYaU=; b=e3bWkWvZovskz0QQgNZT2CpXV/Oe8B4Nk7kSJnZ7P5H56cbO/c3sObUMO32xaL+FY0 qti8yB5D0uijqG0Mp2IZjsYsDbY61IQ6m9557XCh+3vU0DQ259I9AgJg2Kc5u/IohATI GuUNAVU1zy7mgtwBxVTGs49fcwYHkvXSIaZ5bxMl2thkEAqfA0ZeNy9VqQAT3UP7KJIc DR8jEi9ZSlt5zsC2bF7q138dAQ+ErSWCKMaRKTtkt7uHMCLs+dm2YoHkxfGXm8EFmG9b JDacK922JkPVJ1oTaolMilTeTXL995fl4uEPff6frjWyL4qft/624lVaeXof1yvKZTeY viEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VNH7DCEdEff0K5J8Zwzsfyd07P/AkRgXurE5638GYaU=; b=MpoCnWp2SjfLtJqsCkAa44bwNM7ac7+aNnSCIJ80qDAKUAtPkbtqrOhRCsNDzIBtOG nZ3dpVn5tVdYG/k3Ir8CnzPQNuJZ2ZonnG2y8+eHju3wyiD5K1Up/5nCTzV7Bl+kPDra uSPJckAw8ERcOZvRpa2pBqIuulcSRsJJGK2o+gda3OejxfFc4c/YCAWQmzP+ScfTP9/Y jxvdpLRVl/FtsvlOt2y6SHXKzRey4rEcsvTGIZCW0Bh/jW2ogBx5EGfmCETcyzcvKo7E sTxYRRoDsfsAstarb2wtDiRcLqBZh49lTA6SPm2Xu5HFJcS++K07+DoAyy8BlPaKv6Lb HeWQ== X-Gm-Message-State: AOAM533rtymZiQz6s9RQLxpPJ28j2891XImvAB5r7FZbo88/5GQtpJsk WE16KcjTuYZhuhrXIkb9CEAKFQ== X-Google-Smtp-Source: ABdhPJyGx3ZdQgUB0Tk8oEVLhBLsZXvaHp0vR44Ae+XWSnzoEAW8b6smEv6bM6qTvWwv95oP5nmJUg== X-Received: by 2002:a1c:2707:: with SMTP id n7mr4517645wmn.147.1591107777854; Tue, 02 Jun 2020 07:22:57 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id z6sm3957417wrh.79.2020.06.02.07.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2020 07:22:57 -0700 (PDT) Date: Tue, 2 Jun 2020 15:22:55 +0100 From: "Leif Lindholm" To: "Pankaj Bansal (OSS)" Cc: Laszlo Ersek , "devel@edk2.groups.io" , "michael.d.kinney@intel.com" , Andrew Fish Subject: Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering Message-ID: <20200602142255.GM28566@vanye> References: <20200529140251.23933-1-leif@nuviainc.com> <20200531224339.GA28566@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Pankaj, On Tue, Jun 02, 2020 at 13:37:30 +0000, Pankaj Bansal (OSS) wrote: > > How about replacing > > > > """ > > Packages must be listed in the order that may be required for specifying > > include path statements for a compiler. For example, the MdePkg/MdePkg.dec_ > > file must be listed before the `MdeModulePkg/MdeModulePkg.dec` file. > > """ > > > > with > > > > """ > > The order in which packages are listed may be relevant. Said order > > specifies in what order include path statements are generated for a > > compiler. Normally, header file name collisions are not expected between > > packages -- they are forbidden in edk2 proper --, but with a module INF > > consuming both edk2-native and out-of-edk2 packages, header file names > > may collide. For setting specific include path priorities, the packages > > may be listed in matching order in the INF file. Listing a package > > earlier will cause a compiler to consider include paths from that > > package earlier. > > """ > > Nicely summed up! it is much clearer now for anyone like me who > wants to port edk2 for his platform. > one more suggestion. should this be mentioned along with above > explaination: > "whenever possible use lexicographically ascending order" My preference would be that we rework the coding style document to a document that encompasses style of all contributions, and drop some of the things that are not style related. (For example, we already know that we're short on documentation on Python contributions.) / Leif