[PATCH 0/5] Add reviewers for security related modules.

[PATCH 0/5] Add reviewers for security related modules.

[Dong, Eric]

Add reviewers to review security related changes.
Impacted below modules:

MdeModulePkg: Pei Core
F: MdeModulePkg/Core/Pei/

SecurityPkg: Tcg related modules
F: SecurityPkg/Tcg/

SecurityPkg: Secure boot related modules
F: SecurityPkg/Library/DxeImageVerificationLib/
F: SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/
F: SecurityPkg/Library/AuthVariableLib/

UefiCpuPkg: Sec related modules
F: UefiCpuPkg/SecCore/
F: UefiCpuPkg/ResetVector/

Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Debkumar De <debkumar.de@intel.com>
Cc: Harry Han <harry.han@intel.com>
Cc: Catharine West <catharine.west@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Min Xu <min.m.xu@intel.com>

Eric Dong (5):
  Maintainers.txt: Add reviewers for Tcg related modules.
  Maintainers.txt: Add reviewer for security boot modules.
  Maintainers.txt: Add reviewer for UefiCpuPkg.
  Maintainers.txt: Add reviewer for SEC related modules.
  Maintainers.txt: Add reviewer for Pei Core.

 Maintainers.txt | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

-- 
2.23.0.windows.1

[PATCH 1/5] Maintainers.txt: Add reviewers for Tcg related modules.

[Dong, Eric]

Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
---
 Maintainers.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 896ac5821f..954dc567e0 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -453,6 +453,11 @@ M: Jiewen Yao <jiewen.yao@intel.com>
 M: Jian J Wang <jian.j.wang@intel.com>
 R: Chao Zhang <chao.b.zhang@intel.com>
 
+SecurityPkg: Tcg related modules
+F: SecurityPkg/Tcg/
+R: Qi Zhang <qi1.zhang@intel.com>
+R: Rahul Kumar <rahul1.kumar@intel.com>
+
 ShellPkg
 F: ShellPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
-- 
2.23.0.windows.1

[PATCH 2/5] Maintainers.txt: Add reviewer for security boot modules.

[Dong, Eric]

Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Min Xu <min.m.xu@intel.com>
---
 Maintainers.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 954dc567e0..573084e086 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -458,6 +458,12 @@ F: SecurityPkg/Tcg/
 R: Qi Zhang <qi1.zhang@intel.com>
 R: Rahul Kumar <rahul1.kumar@intel.com>
 
+SecurityPkg: Secure boot related modules
+F: SecurityPkg/Library/DxeImageVerificationLib/
+F: SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/
+F: SecurityPkg/Library/AuthVariableLib/
+R: Min Xu <min.m.xu@intel.com>
+
 ShellPkg
 F: ShellPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
-- 
2.23.0.windows.1

[PATCH 3/5] Maintainers.txt: Add reviewer for UefiCpuPkg.

[Dong, Eric]

Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
---
 Maintainers.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 573084e086..318c8388fe 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -487,6 +487,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
 M: Eric Dong <eric.dong@intel.com>
 M: Ray Ni <ray.ni@intel.com>
 R: Laszlo Ersek <lersek@redhat.com>
+R: Rahul Kumar <rahul1.kumar@intel.com>
 
 UefiPayloadPkg
 F: UefiPayloadPkg/
-- 
2.23.0.windows.1

[PATCH 4/5] Maintainers.txt: Add reviewer for SEC related modules.

[Dong, Eric]

Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Debkumar De <debkumar.de@intel.com>
Cc: Harry Han <harry.han@intel.com>
Cc: Catharine West <catharine.west@intel.com>
---
 Maintainers.txt | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 318c8388fe..8350ece296 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -489,6 +489,13 @@ M: Ray Ni <ray.ni@intel.com>
 R: Laszlo Ersek <lersek@redhat.com>
 R: Rahul Kumar <rahul1.kumar@intel.com>
 
+UefiCpuPkg: Sec related modules
+F: UefiCpuPkg/SecCore/
+F: UefiCpuPkg/ResetVector/
+R: Debkumar De <debkumar.de@intel.com>
+R: Harry Han <harry.han@intel.com>
+R: Catharine West <catharine.west@intel.com>
+
 UefiPayloadPkg
 F: UefiPayloadPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/UefiPayloadPkg
-- 
2.23.0.windows.1

[PATCH 5/5] Maintainers.txt: Add reviewer for Pei Core.

[Dong, Eric]

Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Debkumar De <debkumar.de@intel.com>
Cc: Harry Han <harry.han@intel.com>
Cc: Catharine West <catharine.west@intel.com>
---
 Maintainers.txt | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 8350ece296..bb1a882efc 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -258,6 +258,14 @@ F: MdeModulePkg/Universal/Console/
 R: Zhichao Gao <zhichao.gao@intel.com>
 R: Ray Ni <ray.ni@intel.com>
 
+MdeModulePkg: Pei Core
+F: MdeModulePkg/Core/Pei/
+R: Dandan Bi <dandan.bi@intel.com>
+R: Liming Gao <liming.gao@intel.com>
+R: Debkumar De <debkumar.de@intel.com>
+R: Harry Han <harry.han@intel.com>
+R: Catharine West <catharine.west@intel.com>
+
 MdeModulePkg: Core services (PEI, DXE and Runtime) modules
 F: MdeModulePkg/*Mem*/
 F: MdeModulePkg/*SectionExtract*/
@@ -265,7 +273,6 @@ F: MdeModulePkg/*StatusCode*/
 F: MdeModulePkg/Application/DumpDynPcd/
 F: MdeModulePkg/Core/Dxe/
 F: MdeModulePkg/Core/DxeIplPeim/
-F: MdeModulePkg/Core/Pei/
 F: MdeModulePkg/Core/RuntimeDxe/
 F: MdeModulePkg/Include/*Mem*.h
 F: MdeModulePkg/Include/*Pcd*.h
-- 
2.23.0.windows.1

Re: [edk2-devel] [PATCH 1/5] Maintainers.txt: Add reviewers for Tcg related modules.

[Laszlo Ersek]

On 06/03/20 05:18, Dong, Eric wrote:
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
>  Maintainers.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 896ac5821f..954dc567e0 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -453,6 +453,11 @@ M: Jiewen Yao <jiewen.yao@intel.com>
>  M: Jian J Wang <jian.j.wang@intel.com>
>  R: Chao Zhang <chao.b.zhang@intel.com>
>  
> +SecurityPkg: Tcg related modules
> +F: SecurityPkg/Tcg/
> +R: Qi Zhang <qi1.zhang@intel.com>
> +R: Rahul Kumar <rahul1.kumar@intel.com>
> +
>  ShellPkg
>  F: ShellPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>

Re: [edk2-devel] [PATCH 2/5] Maintainers.txt: Add reviewer for security boot modules.

[Laszlo Ersek]

On 06/03/20 05:18, Dong, Eric wrote:
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 954dc567e0..573084e086 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -458,6 +458,12 @@ F: SecurityPkg/Tcg/
>  R: Qi Zhang <qi1.zhang@intel.com>
>  R: Rahul Kumar <rahul1.kumar@intel.com>
>  
> +SecurityPkg: Secure boot related modules
> +F: SecurityPkg/Library/DxeImageVerificationLib/
> +F: SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/
> +F: SecurityPkg/Library/AuthVariableLib/
> +R: Min Xu <min.m.xu@intel.com>
> +
>  ShellPkg
>  F: ShellPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
> 

(1) please replace "security boot" with "secure boot" in the subject.

with that fixed:

Acked-by: Laszlo Ersek <lersek@redhat.com>

Re: [edk2-devel] [PATCH 3/5] Maintainers.txt: Add reviewer for UefiCpuPkg.

[Laszlo Ersek]

On 06/03/20 05:18, Dong, Eric wrote:
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
>  Maintainers.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 573084e086..318c8388fe 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -487,6 +487,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
>  M: Eric Dong <eric.dong@intel.com>
>  M: Ray Ni <ray.ni@intel.com>
>  R: Laszlo Ersek <lersek@redhat.com>
> +R: Rahul Kumar <rahul1.kumar@intel.com>
>  
>  UefiPayloadPkg
>  F: UefiPayloadPkg/
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>

Re: [edk2-devel] [PATCH 4/5] Maintainers.txt: Add reviewer for SEC related modules.

[Laszlo Ersek]

On 06/03/20 05:18, Dong, Eric wrote:
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> Cc: Debkumar De <debkumar.de@intel.com>
> Cc: Harry Han <harry.han@intel.com>
> Cc: Catharine West <catharine.west@intel.com>
> ---
>  Maintainers.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 318c8388fe..8350ece296 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -489,6 +489,13 @@ M: Ray Ni <ray.ni@intel.com>
>  R: Laszlo Ersek <lersek@redhat.com>
>  R: Rahul Kumar <rahul1.kumar@intel.com>
>  
> +UefiCpuPkg: Sec related modules
> +F: UefiCpuPkg/SecCore/
> +F: UefiCpuPkg/ResetVector/
> +R: Debkumar De <debkumar.de@intel.com>
> +R: Harry Han <harry.han@intel.com>
> +R: Catharine West <catharine.west@intel.com>
> +
>  UefiPayloadPkg
>  F: UefiPayloadPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/UefiPayloadPkg
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>

Re: [edk2-devel] [PATCH 2/5] Maintainers.txt: Add reviewer for security boot modules.

[Laszlo Ersek]

On 06/03/20 16:57, Laszlo Ersek wrote:
> On 06/03/20 05:18, Dong, Eric wrote:
>> Signed-off-by: Eric Dong <eric.dong@intel.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Chao Zhang <chao.b.zhang@intel.com>
>> Cc: Min Xu <min.m.xu@intel.com>
>> ---
>>  Maintainers.txt | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index 954dc567e0..573084e086 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -458,6 +458,12 @@ F: SecurityPkg/Tcg/
>>  R: Qi Zhang <qi1.zhang@intel.com>
>>  R: Rahul Kumar <rahul1.kumar@intel.com>
>>  
>> +SecurityPkg: Secure boot related modules
>> +F: SecurityPkg/Library/DxeImageVerificationLib/
>> +F: SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/
>> +F: SecurityPkg/Library/AuthVariableLib/
>> +R: Min Xu <min.m.xu@intel.com>
>> +
>>  ShellPkg
>>  F: ShellPkg/
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>>
> 
> (1) please replace "security boot" with "secure boot" in the subject.
> 
> with that fixed:
> 
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> 

(2) If I remember correctly, we originally wanted the section headers in
the Maintainers.txt file to remain alphabetically sorted.

This patch would create disorder:

SecurityPkg: Tcg related modules
SecurityPkg: Secure boot related modules

Therefore please add the "SecurityPkg: Secure boot related modules"
section above the "SecurityPkg: Tcg related modules" section.

With (1) and (2) fixed:

Acked-by: Laszlo Ersek <lersek@redhat.com>

(Now I do realize there is already some disorder in the Maintainers.txt
file; I'll post a patch for fixing the OvmfPkg-related ones.)

Thanks
Laszlo

Re: [edk2-devel] [PATCH 5/5] Maintainers.txt: Add reviewer for Pei Core.

[Laszlo Ersek]

On 06/03/20 05:18, Dong, Eric wrote:
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Debkumar De <debkumar.de@intel.com>
> Cc: Harry Han <harry.han@intel.com>
> Cc: Catharine West <catharine.west@intel.com>
> ---
>  Maintainers.txt | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 8350ece296..bb1a882efc 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -258,6 +258,14 @@ F: MdeModulePkg/Universal/Console/
>  R: Zhichao Gao <zhichao.gao@intel.com>
>  R: Ray Ni <ray.ni@intel.com>
>  
> +MdeModulePkg: Pei Core
> +F: MdeModulePkg/Core/Pei/
> +R: Dandan Bi <dandan.bi@intel.com>
> +R: Liming Gao <liming.gao@intel.com>
> +R: Debkumar De <debkumar.de@intel.com>
> +R: Harry Han <harry.han@intel.com>
> +R: Catharine West <catharine.west@intel.com>
> +
>  MdeModulePkg: Core services (PEI, DXE and Runtime) modules
>  F: MdeModulePkg/*Mem*/
>  F: MdeModulePkg/*SectionExtract*/
> @@ -265,7 +273,6 @@ F: MdeModulePkg/*StatusCode*/
>  F: MdeModulePkg/Application/DumpDynPcd/
>  F: MdeModulePkg/Core/Dxe/
>  F: MdeModulePkg/Core/DxeIplPeim/
> -F: MdeModulePkg/Core/Pei/
>  F: MdeModulePkg/Core/RuntimeDxe/
>  F: MdeModulePkg/Include/*Mem*.h
>  F: MdeModulePkg/Include/*Pcd*.h
> 

(1) This section ("MdeModulePkg: Pei Core") should be inserted between:

MdeModulePkg: Management Mode (MM, SMM) modules
MdeModulePkg: Reset modules

With the insertion point fixed:

Acked-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo

Re: [PATCH 1/5] Maintainers.txt: Add reviewers for Tcg related modules.

[Wang, Jian J]

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Dong, Eric <eric.dong@intel.com>
> Sent: Wednesday, June 03, 2020 11:18 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>; Zhang, Qi1 <qi1.zhang@intel.com>;
> Kumar, Rahul1 <rahul1.kumar@intel.com>
> Subject: [PATCH 1/5] Maintainers.txt: Add reviewers for Tcg related modules.
> 
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
>  Maintainers.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 896ac5821f..954dc567e0 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -453,6 +453,11 @@ M: Jiewen Yao <jiewen.yao@intel.com>
>  M: Jian J Wang <jian.j.wang@intel.com>
> 
>  R: Chao Zhang <chao.b.zhang@intel.com>
> 
> 
> 
> +SecurityPkg: Tcg related modules
> 
> +F: SecurityPkg/Tcg/
> 
> +R: Qi Zhang <qi1.zhang@intel.com>
> 
> +R: Rahul Kumar <rahul1.kumar@intel.com>
> 
> +
> 
>  ShellPkg
> 
>  F: ShellPkg/
> 
>  W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
> 
> --
> 2.23.0.windows.1

Re: [edk2-devel] [PATCH 2/5] Maintainers.txt: Add reviewer for security boot modules.

[Wang, Jian J]

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Wednesday, June 03, 2020 11:03 PM
> To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>; Xu, Min M <min.m.xu@intel.com>
> Subject: Re: [edk2-devel] [PATCH 2/5] Maintainers.txt: Add reviewer for security
> boot modules.
> 
> On 06/03/20 16:57, Laszlo Ersek wrote:
> > On 06/03/20 05:18, Dong, Eric wrote:
> >> Signed-off-by: Eric Dong <eric.dong@intel.com>
> >> Cc: Jiewen Yao <jiewen.yao@intel.com>
> >> Cc: Jian J Wang <jian.j.wang@intel.com>
> >> Cc: Chao Zhang <chao.b.zhang@intel.com>
> >> Cc: Min Xu <min.m.xu@intel.com>
> >> ---
> >>  Maintainers.txt | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/Maintainers.txt b/Maintainers.txt
> >> index 954dc567e0..573084e086 100644
> >> --- a/Maintainers.txt
> >> +++ b/Maintainers.txt
> >> @@ -458,6 +458,12 @@ F: SecurityPkg/Tcg/
> >>  R: Qi Zhang <qi1.zhang@intel.com>
> >>  R: Rahul Kumar <rahul1.kumar@intel.com>
> >>
> >> +SecurityPkg: Secure boot related modules
> >> +F: SecurityPkg/Library/DxeImageVerificationLib/
> >> +F: SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/
> >> +F: SecurityPkg/Library/AuthVariableLib/
> >> +R: Min Xu <min.m.xu@intel.com>
> >> +
> >>  ShellPkg
> >>  F: ShellPkg/
> >>  W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
> >>
> >
> > (1) please replace "security boot" with "secure boot" in the subject.
> >
> > with that fixed:
> >
> > Acked-by: Laszlo Ersek <lersek@redhat.com>
> >
> 
> (2) If I remember correctly, we originally wanted the section headers in
> the Maintainers.txt file to remain alphabetically sorted.
> 
> This patch would create disorder:
> 
> SecurityPkg: Tcg related modules
> SecurityPkg: Secure boot related modules
> 
> Therefore please add the "SecurityPkg: Secure boot related modules"
> section above the "SecurityPkg: Tcg related modules" section.
> 
> With (1) and (2) fixed:
> 
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> 
> (Now I do realize there is already some disorder in the Maintainers.txt
> file; I'll post a patch for fixing the OvmfPkg-related ones.)
> 
> Thanks
> Laszlo
> 
> 
> 

Re: [PATCH 5/5] Maintainers.txt: Add reviewer for Pei Core.

[Wang, Jian J]

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Dong, Eric <eric.dong@intel.com>
> Sent: Wednesday, June 03, 2020 11:18 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> De, Debkumar <debkumar.de@intel.com>; Han, Harry <harry.han@intel.com>;
> West, Catharine <catharine.west@intel.com>
> Subject: [PATCH 5/5] Maintainers.txt: Add reviewer for Pei Core.
> 
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Debkumar De <debkumar.de@intel.com>
> Cc: Harry Han <harry.han@intel.com>
> Cc: Catharine West <catharine.west@intel.com>
> ---
>  Maintainers.txt | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 8350ece296..bb1a882efc 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -258,6 +258,14 @@ F: MdeModulePkg/Universal/Console/
>  R: Zhichao Gao <zhichao.gao@intel.com>
> 
>  R: Ray Ni <ray.ni@intel.com>
> 
> 
> 
> +MdeModulePkg: Pei Core
> 
> +F: MdeModulePkg/Core/Pei/
> 
> +R: Dandan Bi <dandan.bi@intel.com>
> 
> +R: Liming Gao <liming.gao@intel.com>
> 
> +R: Debkumar De <debkumar.de@intel.com>
> 
> +R: Harry Han <harry.han@intel.com>
> 
> +R: Catharine West <catharine.west@intel.com>
> 
> +
> 
>  MdeModulePkg: Core services (PEI, DXE and Runtime) modules
> 
>  F: MdeModulePkg/*Mem*/
> 
>  F: MdeModulePkg/*SectionExtract*/
> 
> @@ -265,7 +273,6 @@ F: MdeModulePkg/*StatusCode*/
>  F: MdeModulePkg/Application/DumpDynPcd/
> 
>  F: MdeModulePkg/Core/Dxe/
> 
>  F: MdeModulePkg/Core/DxeIplPeim/
> 
> -F: MdeModulePkg/Core/Pei/
> 
>  F: MdeModulePkg/Core/RuntimeDxe/
> 
>  F: MdeModulePkg/Include/*Mem*.h
> 
>  F: MdeModulePkg/Include/*Pcd*.h
> 
> --
> 2.23.0.windows.1