From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web11.10820.1591179684436440113 for ; Wed, 03 Jun 2020 03:21:24 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: ray.ni@intel.com) IronPort-SDR: Et5YVYRs8VRj0PUZBNRwHwnajMoiwtFFbCu2Sk1Tq9lFdpo9VemTco8YUtp0xPJcs+Y0pMZPej 95C1yikRkETA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2020 03:21:24 -0700 IronPort-SDR: C5stLAAt3zRM5QBphtg4xEMIxpKwt8ThV+B3lDJl8uBQmjS0QX29cJd/cSD7Bfjkon11jQSfyR hWyMJ8CKNIpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,467,1583222400"; d="scan'208";a="269029710" Received: from ray-dev.ccr.corp.intel.com ([10.239.158.43]) by orsmga003.jf.intel.com with ESMTP; 03 Jun 2020 03:21:23 -0700 From: "Ni, Ray" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [PATCH 1/2] MdePkg/PciSegmentInfoLib: Add missing EFIAPI to GetPciSegmentInfo() Date: Wed, 3 Jun 2020 18:20:38 +0800 Message-Id: <20200603102039.768-2-ray.ni@intel.com> X-Mailer: git-send-email 2.26.2.windows.1 In-Reply-To: <20200603102039.768-1-ray.ni@intel.com> References: <20200603102039.768-1-ray.ni@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable All public APIs should have EFIAPI modifier. Somehow PciSegmentInfoLib missed the EFIAPI modifier. The patch updates the library header file and NULL instance in MdePkg to add the missing EFIAPI. Signed-off-by: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu --- MdePkg/Include/Library/PciSegmentInfoLib.h | 1 + MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c | 1 + 2 files changed, 2 insertions(+) diff --git a/MdePkg/Include/Library/PciSegmentInfoLib.h b/MdePkg/Include/Li= brary/PciSegmentInfoLib.h index 320a223628..a59644af99 100644 --- a/MdePkg/Include/Library/PciSegmentInfoLib.h +++ b/MdePkg/Include/Library/PciSegmentInfoLib.h @@ -28,6 +28,7 @@ typedef struct { @retval A callee owned array holding the segment information.=0D **/=0D PCI_SEGMENT_INFO *=0D +EFIAPI=0D GetPciSegmentInfo (=0D UINTN *Count=0D );=0D diff --git a/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c b= /MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c index f9019c4e64..11c09506ab 100644 --- a/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c +++ b/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c @@ -21,6 +21,7 @@ @retval A callee owned array holding the segment information.=0D **/=0D PCI_SEGMENT_INFO *=0D +EFIAPI=0D GetPciSegmentInfo (=0D UINTN *Count=0D )=0D --=20 2.26.2.windows.1