* [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value
@ 2020-06-03 19:36 Ard Biesheuvel
2020-06-03 20:18 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2020-06-03 19:36 UTC (permalink / raw)
To: devel; +Cc: leif, Ard Biesheuvel
PlatformBootManagerLib now asserts at build time that the correct
terminal type is used, and so leaving it unset breaks the ArmPkg
DSC build. So fix that.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
ArmPkg/ArmPkg.dsc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
index 549a2d29ab61..bac1306af61f 100644
--- a/ArmPkg/ArmPkg.dsc
+++ b/ArmPkg/ArmPkg.dsc
@@ -29,6 +29,9 @@ [BuildOptions]
RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES
+[PcdsFixedAtBuild]
+ gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
+
[LibraryClasses.common]
BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value
2020-06-03 19:36 [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value Ard Biesheuvel
@ 2020-06-03 20:18 ` Leif Lindholm
2020-06-03 21:30 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2020-06-03 20:18 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel
On Wed, Jun 03, 2020 at 21:36:35 +0200, Ard Biesheuvel wrote:
> PlatformBootManagerLib now asserts at build time that the correct
> terminal type is used, and so leaving it unset breaks the ArmPkg
> DSC build. So fix that.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> ---
> ArmPkg/ArmPkg.dsc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> index 549a2d29ab61..bac1306af61f 100644
> --- a/ArmPkg/ArmPkg.dsc
> +++ b/ArmPkg/ArmPkg.dsc
> @@ -29,6 +29,9 @@ [BuildOptions]
> RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
> *_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES
>
> +[PcdsFixedAtBuild]
> + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
> +
> [LibraryClasses.common]
> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value
2020-06-03 20:18 ` Leif Lindholm
@ 2020-06-03 21:30 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2020-06-03 21:30 UTC (permalink / raw)
To: Leif Lindholm; +Cc: devel
On 6/3/20 10:18 PM, Leif Lindholm wrote:
> On Wed, Jun 03, 2020 at 21:36:35 +0200, Ard Biesheuvel wrote:
>> PlatformBootManagerLib now asserts at build time that the correct
>> terminal type is used, and so leaving it unset breaks the ArmPkg
>> DSC build. So fix that.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
Thanks
Pushed as #657
>> ---
>> ArmPkg/ArmPkg.dsc | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
>> index 549a2d29ab61..bac1306af61f 100644
>> --- a/ArmPkg/ArmPkg.dsc
>> +++ b/ArmPkg/ArmPkg.dsc
>> @@ -29,6 +29,9 @@ [BuildOptions]
>> RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
>> *_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES
>>
>> +[PcdsFixedAtBuild]
>> + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
>> +
>> [LibraryClasses.common]
>> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
>> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
>> --
>> 2.26.2
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-03 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-03 19:36 [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value Ard Biesheuvel
2020-06-03 20:18 ` Leif Lindholm
2020-06-03 21:30 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox