From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.4777.1591215528943391823 for ; Wed, 03 Jun 2020 13:18:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=xLAoL/9a; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id l10so3715048wrr.10 for ; Wed, 03 Jun 2020 13:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MJCR+nXxuol7NWDHjiEpOt369EV+pHwHLVB8l9Y3/xk=; b=xLAoL/9aEdxfG8LRUR/3aOoUH7OiGgXzZwxxtLa52XAEnsyau7sUkdyn8w8IePD25n VDY1wcx97ile8atTSgLlTyowwz8f0nT9WcNgRgWDI46EPqAwxZ6N+0vrUMPYc8XNZWxg hzJyXa31hwxVM4kl9U+eRYaqa83cauCh5dPuBLQcOZ6n5B14bzkbIyk5nMLPg/2veplx lfFcrWrijVU6re1vDaqJ+mXh+YIm6HJa45/pTTYRONvdZA+qGMkKz71Cwn3RvPhs98Ua 3RDFn5S7DQ9cbiPehziMwdqejfaWMC85yALrqHZFeTNh1j731HiCpXgbbfGFFJjhLhIX vzwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MJCR+nXxuol7NWDHjiEpOt369EV+pHwHLVB8l9Y3/xk=; b=MS/jlbu6OmyCJtSdqOWj497XKFwgqle+iD7gEXHSNl8Ha0C2pejrjeKlAhv4vnSr4B +1Lv3ZYPOZhrUW9c4j2x6eTu5ZoyuIYFgz9dMFNVOXnlXCZShLj853wHbU4IWlzgSOO7 OVWkS+ViRoAO5cFV75Vj7G2LriAJ6K+VDTJxaAJgng2icAuUQ0vIs02LwH1iW83RJ1el v1LVK1OH0dOTHXdi90etH8o+J0bwbPR/FFY9p/dPREUdAkAilQBvcjZMsSSfhnrLE5uz dyFTB/hHVP4HG5uQlbwYkzq+VUjM9QVX4zU36WMGFPFRnphxza1WT6WAGXSmw6VAmcex XpQw== X-Gm-Message-State: AOAM533y7XmMEeHHB7aRRUaye7L/QlD3QFnGr1sL7EdrOhlS45hQ1yfB cb2tFJuHdxcJQCTdUXGKyla5Jw== X-Google-Smtp-Source: ABdhPJzn8smV9KC9f8CNNbua4tEjDbGcWmlU8wtxXuUmXVVOUbJtfBI9jtD7+L7EcgitL4jPJWnqpg== X-Received: by 2002:adf:db47:: with SMTP id f7mr1082560wrj.101.1591215527568; Wed, 03 Jun 2020 13:18:47 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id l17sm4064686wmi.3.2020.06.03.13.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2020 13:18:46 -0700 (PDT) Date: Wed, 3 Jun 2020 21:18:44 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value Message-ID: <20200603201844.GU28566@vanye> References: <20200603193635.5823-1-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200603193635.5823-1-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 03, 2020 at 21:36:35 +0200, Ard Biesheuvel wrote: > PlatformBootManagerLib now asserts at build time that the correct > terminal type is used, and so leaving it unset breaks the ArmPkg > DSC build. So fix that. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPkg/ArmPkg.dsc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > index 549a2d29ab61..bac1306af61f 100644 > --- a/ArmPkg/ArmPkg.dsc > +++ b/ArmPkg/ArmPkg.dsc > @@ -29,6 +29,9 @@ [BuildOptions] > RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > *_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES > > +[PcdsFixedAtBuild] > + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4 > + > [LibraryClasses.common] > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > -- > 2.26.2 >