From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com []) by mx.groups.io with SMTP id smtpd.web12.6510.1591241275730400375 for ; Wed, 03 Jun 2020 20:27:56 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: ray.ni@intel.com) IronPort-SDR: 9GKwvcowsI2Oy6O75QxIG6uLhlXTbEk/Em7LEYVkdgFYQMQMrUNIMsWsDFJlCjZ5eI1c91txSi vsZzWAOqOdgQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2020 20:27:56 -0700 IronPort-SDR: zBPseY8+xDs4r40/XA7XOwHPUkSNVGqfBlLesEFFcpIDojRANB78hWhGw0SVmnuS+PUxqOXZE+ wkeZoz6RX1EA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,470,1583222400"; d="scan'208";a="471280225" Received: from ray-dev.ccr.corp.intel.com ([10.239.158.43]) by fmsmga006.fm.intel.com with ESMTP; 03 Jun 2020 20:27:54 -0700 From: "Ni, Ray" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [PATCH V2 1/2] MdePkg/PciSegmentInfoLib: Add missing EFIAPI to GetPciSegmentInfo() Date: Thu, 4 Jun 2020 11:27:09 +0800 Message-Id: <20200604032710.970-2-ray.ni@intel.com> X-Mailer: git-send-email 2.26.2.windows.1 In-Reply-To: <20200604032710.970-1-ray.ni@intel.com> References: <20200604032710.970-1-ray.ni@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable All public APIs should have EFIAPI modifier. Somehow PciSegmentInfoLib missed the EFIAPI modifier. The patch updates the library header file and NULL instance in MdePkg to add the missing EFIAPI. Signed-off-by: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu --- MdePkg/Include/Library/PciSegmentInfoLib.h | 3 ++- MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Library/PciSegmentInfoLib.h b/MdePkg/Include/Li= brary/PciSegmentInfoLib.h index 320a223628..659ff85649 100644 --- a/MdePkg/Include/Library/PciSegmentInfoLib.h +++ b/MdePkg/Include/Library/PciSegmentInfoLib.h @@ -3,7 +3,7 @@ =0D This library is consumed by PciSegmentLib to support multiple segment PC= I configuration access.=0D =0D - Copyright (c) 2017, Intel Corporation. All rights reserved.
=0D + Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.
=0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D **/=0D @@ -28,6 +28,7 @@ typedef struct { @retval A callee owned array holding the segment information.=0D **/=0D PCI_SEGMENT_INFO *=0D +EFIAPI=0D GetPciSegmentInfo (=0D UINTN *Count=0D );=0D diff --git a/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c b= /MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c index f9019c4e64..3ec7784057 100644 --- a/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c +++ b/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c @@ -2,7 +2,7 @@ Default PCI Segment Information Library that returns one segment whose=0D segment base address equals to PcdPciExpressBaseAddress.=0D =0D - Copyright (c) 2017, Intel Corporation. All rights reserved.
=0D + Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.
=0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D **/=0D @@ -21,6 +21,7 @@ @retval A callee owned array holding the segment information.=0D **/=0D PCI_SEGMENT_INFO *=0D +EFIAPI=0D GetPciSegmentInfo (=0D UINTN *Count=0D )=0D --=20 2.26.2.windows.1