From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.15858.1591282851109142110 for ; Thu, 04 Jun 2020 08:00:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=aAD9IvTk; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id x14so6487260wrp.2 for ; Thu, 04 Jun 2020 08:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OZ9fC7nB9up6fcQIZUGUFxoXh0hyeyIBkvy929b3zDk=; b=aAD9IvTkIkV9pDe0hRg4k8JUVnJe/k+KNkIA4QGWQ3JhO083S3YdykkFo2/Qv5om5C B63mP+uMhiu7BBjjo38ZXkQ7gN3xL5ctkEaPS9u0G5rGQG9ckXNYTsFNqZVwV6xfbA6U n0rcw38GqAbWgh85WIQRc5mtqpN4rro6SpxUSwdHhC+7AUZBah3fo1n4TyVh3UBd/xIk RFdYO7uIKhhlMz6vyEqog2fWQYRQwzUlvPk+gbBBrQddFS/0E/CJyMo5L1A8D63/N2bt 0Dl2tfTwJmsTWp0mNeIQFLXqkTfkYmNHsLqopCkAh4c1BCZm080P8vt13CfZfunwZj+8 XWQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OZ9fC7nB9up6fcQIZUGUFxoXh0hyeyIBkvy929b3zDk=; b=nKyRbOhKAmWGLR6u/hNfX4ABWEdv5OpRFQmxdEbF496pyF+8gU1vkvlkVZI2nPCRa4 0+aWmuLhYUlmRaR7rFBLVtxwm0NbS0+SMJXXiOS8LWd/tXl8uN66LhLMIpQlddVsByPc aB7E4j+qU74kDvEUYa4/2XHHEzB0+n/wv449LzdNvi86Cig8saFCK9cEfkrYbroWn2Rs RTDLdKU7HMO9/cw6Tg6z2RzQYiAXYSyRuj53kRHKg/YzICxG8XvBCP1TEdoWIeICFQ2t /8G2Fjt6PN6dsOMVirR4WFzTScghDrkPAenKqLZxNf5y8IdgJF8cQ+9fppw+kl1UxqWF hSgA== X-Gm-Message-State: AOAM532mLbEEEjA/OZubYUVWTL+LpM7jIQbtjAfHLjDEke8ZwryahsOC LXUhkhBUCY0PKnWWdcAf3fEp/g== X-Google-Smtp-Source: ABdhPJxyWns/kQ4NSNA+lowPVNq6vpUtBFacfubDsAR+qshv/a6ISfgEzz9gruf8cIglpnSJhnzwjA== X-Received: by 2002:adf:97cb:: with SMTP id t11mr4805089wrb.314.1591282849584; Thu, 04 Jun 2020 08:00:49 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id p16sm8913128wru.27.2020.06.04.08.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2020 08:00:48 -0700 (PDT) Date: Thu, 4 Jun 2020 16:00:46 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Jared McNeill , Andrei Warkentin , Samer El-Haj-Mahmoud , Pete Batard , Jeremy Linton Subject: Re: [PATCH edk2-platforms 1/3] Silicon/Broadcom/BcmGenetDxe: program MAC also when not connected Message-ID: <20200604150046.GZ28566@vanye> References: <20200604095007.45693-1-ard.biesheuvel@arm.com> <20200604095007.45693-2-ard.biesheuvel@arm.com> <20200604145339.GX28566@vanye> <68f182be-29ab-7ea7-46ff-1a4eac8f62f4@arm.com> MIME-Version: 1.0 In-Reply-To: <68f182be-29ab-7ea7-46ff-1a4eac8f62f4@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 04, 2020 at 16:57:00 +0200, Ard Biesheuvel wrote: > On 6/4/20 4:53 PM, Leif Lindholm wrote: > > On Thu, Jun 04, 2020 at 11:50:05 +0200, Ard Biesheuvel wrote: > > > In preparation of removing the EfiBootManagerConnectAll() from the > > > ordinary boot path, ensure that the MAC programming of the GENET > > > occurs even if the SNP driver for it is never invoked by the BDS. > > > > Does this not cause a behaviour change if the driver *has* been > > invoked, and the MAC address has been modified with > > SNP.StationAddress()? > > No, the MAC is programmed when the device is registered. If SNP takes > control, it does so afterwards, and will be able to supersede the MAC as > before. Ah, good. Then, for the series: Acked-by: Leif Lindholm