From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web11.10454.1591362573487659955 for ; Fri, 05 Jun 2020 06:09:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=bXG0l6M7; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id g10so8384649wmh.4 for ; Fri, 05 Jun 2020 06:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YOFAaQUPiok5C0lO30/Z6B1Z13wQCky/DM+7DHL5dH4=; b=bXG0l6M7AtRX6TcpH3Z9dNc40uCGsKv0qhjllWqYskOfkkPJuNho1e1185S0MCwoLi EosI356DpynugliovrdsC7WeRYEL5QemRp1Fkp3WV0ySdLfM1x/oPh43YAvyqn70jepH Ma6Qv/Mbaa0UFOJtvWweB0VhvlDFbXEKA6/FpN1mZVAwnWd6jhXUX6LwiChCl5FDuKLJ gU9a6Wvp07jUOEdcEqcuVrzWHzDeJX5uLMgtjYYZsE1v3m7OVC91s7JCzMB9hq5j/9de Hj4yP2LVg2B+k5oqc0GtcdPjgiqcQWkBKOcL2p9tdzEjVLE7X8eWWDIg+4axQNApAvUC 28Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YOFAaQUPiok5C0lO30/Z6B1Z13wQCky/DM+7DHL5dH4=; b=qTNZEM3KWsm/pVZGw1/q0hikQEL6Cpz0VFP9m/StYxIG2H7QN+RTE2BxZoJSs4QhOD Q8iiLt4CtaTR9KCzSjfUuBW9qrqZkHlEiaDCJtfH4Nd2abTX7aY4Ot5w2wxZjiI71Jtq vOYWqvkOj5tfBLqb6/JlywP4kNPlgL+06+MWzN9B0gWV+fO3s19a5wc3FyE7zVcatcI3 V1I+M4fJxukaMp0RMA5VJIdEa/wqIbAg+WZ77wvEs5ZVDTVtY/fUc5IXNiVvRwFx9QiF /pPJtrFKCYYd3q6LhlV4kyusXpSIVRs8IMXJ8XqcYsaLIc/XaJLl3qKjpr7M78hU2EiM 8Xhw== X-Gm-Message-State: AOAM532UB6uaMnkZ3PY+jqipTqc2iSCdEdcjEecNwbuMgCXQLyCtw2BX KHfC+f2uGREyiEKL1n9pDJWbVQ== X-Google-Smtp-Source: ABdhPJzyM19r9Noh6IVASUUYnbcUtu48hcwdEI+To5e2MJeBVoa28tPbpTociJ3Atvq8v0rSxvLuZA== X-Received: by 2002:a7b:c74b:: with SMTP id w11mr2586825wmk.120.1591362572047; Fri, 05 Jun 2020 06:09:32 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id z8sm11974378wru.33.2020.06.05.06.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 06:09:31 -0700 (PDT) Date: Fri, 5 Jun 2020 14:09:29 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: Meenakshi Aggarwal , michael.d.kinney@intel.com, devel@edk2.groups.io, v.sethi@nxp.com, Meenakshi Aggarwal Subject: Re: [PATCH edk2-platforms 2/2] Platform/NXP:LX2160: Enable support of SATA controller Message-ID: <20200605130929.GG28566@vanye> References: <1591372974-7860-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> <1591372974-7860-3-git-send-email-meenakshi.aggarwal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 05, 2020 at 15:01:36 +0200, Ard Biesheuvel wrote: > On 6/5/20 6:02 PM, Meenakshi Aggarwal wrote: > > Enable support of SATA drives on lx2160 RDB board. > > > > Signed-off-by: Meenakshi Aggarwal > > --- > > Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 +++++ > > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 2 ++ > > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 18 +++++++++++++++--- > > 3 files changed, 22 insertions(+), 3 deletions(-) > > > > diff --git a/Silicon/NXP/LX2160A/LX2160A.dsc.inc b/Silicon/NXP/LX2160A/LX2160A.dsc.inc > > index 55dd3b5442eb..6bd08d527aed 100644 > > --- a/Silicon/NXP/LX2160A/LX2160A.dsc.inc > > +++ b/Silicon/NXP/LX2160A/LX2160A.dsc.inc > > @@ -40,8 +40,13 @@ [PcdsFixedAtBuild.common] > > gNxpQoriqLsTokenSpaceGuid.PcdUsbSize|0x10000 > > gNxpQoriqLsTokenSpaceGuid.PcdNumUsbController|2 > > + gNxpQoriqLsTokenSpaceGuid.PcdSataBaseAddr|0x3200000 > > + gNxpQoriqLsTokenSpaceGuid.PcdSataSize|0x10000 > > + gNxpQoriqLsTokenSpaceGuid.PcdNumSataController|0x4 > > + > > [PcdsFeatureFlag] > > gNxpQoriqLsTokenSpaceGuid.PcdI2cErratumA009203|TRUE > > + gNxpQoriqLsTokenSpaceGuid.PcdSataErratumA009185|TRUE > > ################################################################################ > > # > > diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc > > index ec27a1a219a5..2c65577eceab 100644 > > --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc > > +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc > > @@ -44,4 +44,6 @@ [Components.common] > > } > > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf > > + > > + Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf > > ## > > diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf > > index 5cb809e8b3a0..e8ac7658c011 100644 > > --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf > > +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf > > @@ -23,10 +23,10 @@ > > [FD.LX2160ARDB_EFI] > > BaseAddress = 0x82000000|gArmTokenSpaceGuid.PcdFdBaseAddress #The base address of the FLASH Device. > > -Size = 0x00160000|gArmTokenSpaceGuid.PcdFdSize #The size in bytes of the FLASH Device > > +Size = 0x00180000|gArmTokenSpaceGuid.PcdFdSize #The size in bytes of the FLASH Device > > ErasePolarity = 1 > > BlockSize = 0x10000 > > -NumBlocks = 0x16 > > +NumBlocks = 0x18 > > ################################################################################ > > # > > @@ -43,7 +43,7 @@ [FD.LX2160ARDB_EFI] > > # RegionType > > # > > ################################################################################ > > -0x00000000|0x00160000 > > +0x00000000|0x00180000 > > gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > > FV = FVMAIN_COMPACT > > I don't mind these unrelated changes (but Leif might) but you should make a > note of them in the commit log. If the change is to accommodate the added drivers, they're not unrelated. But yes, they should still be explicitly called out in commit message. / Leif > > @@ -132,6 +132,18 @@ [FV.FvMain] > > INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > > INF Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf > > + > > + # > > + # AHCI Support > > + # > > + INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > > + INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > > + INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > > + INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > > + INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > > + > > + INF Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf > > + > > # > > # UEFI application (Shell Embedded Boot Loader) > > # > > >