* [PATCH 1/1] ArmPkg: only attempt buildin MmCommunicationDxe for AArch64
@ 2020-06-07 20:09 Leif Lindholm
2020-06-07 20:23 ` [edk2-devel] " Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2020-06-07 20:09 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Michael Kubacki
Commit 045e4b84c18f ("ArmPkg/ArmPkg.dsc: Add missing components")
adds some components to the ArmPkg.dsc build config, but it adds
them to Components.common, and MmCommunicationDxe is AArch64 only.
Move it to Components.AARCH64 to stop the ARM build breaking.
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
---
ArmPkg/ArmPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
index bac1306af61f..48059cf38ed3 100644
--- a/ArmPkg/ArmPkg.dsc
+++ b/ArmPkg/ArmPkg.dsc
@@ -145,8 +145,8 @@ [Components.common]
ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf
- ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
[Components.AARCH64]
+ ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf
ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH 1/1] ArmPkg: only attempt buildin MmCommunicationDxe for AArch64
2020-06-07 20:09 [PATCH 1/1] ArmPkg: only attempt buildin MmCommunicationDxe for AArch64 Leif Lindholm
@ 2020-06-07 20:23 ` Ard Biesheuvel
2020-06-07 21:16 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2020-06-07 20:23 UTC (permalink / raw)
To: devel, leif; +Cc: Michael Kubacki
On 6/7/20 10:09 PM, Leif Lindholm via groups.io wrote:
> Commit 045e4b84c18f ("ArmPkg/ArmPkg.dsc: Add missing components")
> adds some components to the ArmPkg.dsc build config, but it adds
> them to Components.common, and MmCommunicationDxe is AArch64 only.
> Move it to Components.AARCH64 to stop the ARM build breaking.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
So how does this break only now?
In any case,
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> ---
> ArmPkg/ArmPkg.dsc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> index bac1306af61f..48059cf38ed3 100644
> --- a/ArmPkg/ArmPkg.dsc
> +++ b/ArmPkg/ArmPkg.dsc
> @@ -145,8 +145,8 @@ [Components.common]
>
> ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
> ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf
> - ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
>
> [Components.AARCH64]
> + ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
> ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf
> ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH 1/1] ArmPkg: only attempt buildin MmCommunicationDxe for AArch64
2020-06-07 20:23 ` [edk2-devel] " Ard Biesheuvel
@ 2020-06-07 21:16 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2020-06-07 21:16 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel, Michael Kubacki
On Sun, Jun 07, 2020 at 22:23:20 +0200, Ard Biesheuvel wrote:
> On 6/7/20 10:09 PM, Leif Lindholm via groups.io wrote:
> > Commit 045e4b84c18f ("ArmPkg/ArmPkg.dsc: Add missing components")
> > adds some components to the ArmPkg.dsc build config, but it adds
> > them to Components.common, and MmCommunicationDxe is AArch64 only.
> > Move it to Components.AARCH64 to stop the ARM build breaking.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> > Signed-off-by: Leif Lindholm <leif@nuviainc.com>
>
> So how does this break only now?
Did you see it hit the upstream tree? You did have some stuck job,
maybe it was stuck because this one had hung?
> In any case,
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Thanks!
Pushed as 6ff7c838d092.
> > ---
> > ArmPkg/ArmPkg.dsc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> > index bac1306af61f..48059cf38ed3 100644
> > --- a/ArmPkg/ArmPkg.dsc
> > +++ b/ArmPkg/ArmPkg.dsc
> > @@ -145,8 +145,8 @@ [Components.common]
> > ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
> > ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf
> > - ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
> > [Components.AARCH64]
> > + ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
> > ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf
> > ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-07 21:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-07 20:09 [PATCH 1/1] ArmPkg: only attempt buildin MmCommunicationDxe for AArch64 Leif Lindholm
2020-06-07 20:23 ` [edk2-devel] " Ard Biesheuvel
2020-06-07 21:16 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox