From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by mx.groups.io with SMTP id smtpd.web11.16397.1591564563903550653
 for <devel@edk2.groups.io>;
 Sun, 07 Jun 2020 14:16:04 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=u63n28kf;
 spf=pass (domain: nuviainc.com, ip: 209.85.128.66, mailfrom: leif@nuviainc.com)
Received: by mail-wm1-f66.google.com with SMTP id r9so13443138wmh.2
        for <devel@edk2.groups.io>; Sun, 07 Jun 2020 14:16:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=E7ROPfB2jGbCOC6/2gFNqpwut2qsphWMn6bXKE966PM=;
        b=u63n28kfRbKvfM7HchSEAGMrySdel4fxI2g+pLsQFm2lS+qnslge/LiPwhj+1K+aqz
         TO8n4aMonB6CXLYzzH6gyIajwHS4ISIbU9axrN8FJtn6vWvqGG/F4Yy7oz1rtYt6gsb6
         CkDD0ag16hlGxdYvgNe4pem4H+N5gBWgmY8a1vkkAK+Q3H4lexcW2GAiFMN+3Ca325pW
         UbrWCw334EIQatWWwHsBH3kTqDqdCMjdxLE2oxE6HG+JylsVWHdExeqkT9GzKtwBIHga
         HnfTzvNhD6Y3y0kfu3OuAKvMbNNV3eiYLxk2pzJO7R/00R5pgYF/jpNj1lZB3MG3jpWj
         yg9g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=E7ROPfB2jGbCOC6/2gFNqpwut2qsphWMn6bXKE966PM=;
        b=CF3n8tCT9j1fJoILppi65ixf750LlYtxPa3C3Kf2RBU8iIhwDKmK499qjBqaKLKgSU
         J6LSODEVR0IP16OJy8eq/bxheawjTlhr30snglMHDDw7lKUWjYkFjy79n4gu5SdD9Jkt
         xMCZpKhaZTW66MBJ7mG86DLHslkK3G4ZpOIKrrGKcB2y65Q+PparhoE8LRoYlCAROIE9
         ZInxGKvAnxHMm0PudZrFNTF2ToMfoCnUr67H6oGkTpTStxOuhYgFoCe8JgHSwA8tJT9l
         U7ilS1fruudKtmRQYDs7nKSmTd28yueyqbvnys0lIDqnV1qWR/AgnHZVbXU6ysj3wsyn
         KoTA==
X-Gm-Message-State: AOAM530y/uJx+4BFTd5tBS/PTBJfkAYC9cp1lfoStI2WPGB9PrIlFdr/
	vg44dsMz0vPBuBtXUm3hHakUpg==
X-Google-Smtp-Source: ABdhPJx8Ts+BI3hoYRRERhUqkQowjccHF+Ip/wOqVDuZj27f8BQmH88hAwCWP7CqQMgF3AqZP24ylA==
X-Received: by 2002:a1c:2183:: with SMTP id h125mr13110139wmh.88.1591564562550;
        Sun, 07 Jun 2020 14:16:02 -0700 (PDT)
Return-Path: <leif@nuviainc.com>
Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8])
        by smtp.gmail.com with ESMTPSA id o20sm22033367wra.29.2020.06.07.14.16.01
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Sun, 07 Jun 2020 14:16:02 -0700 (PDT)
Date: Sun, 7 Jun 2020 22:16:00 +0100
From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io, Michael Kubacki <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] [PATCH 1/1] ArmPkg: only attempt buildin MmCommunicationDxe for AArch64
Message-ID: <20200607211600.GK28566@vanye>
References: <20200607200920.8204-1-leif@nuviainc.com>
 <d4e5a571-65b9-f932-2df9-addc47031b2c@arm.com>
MIME-Version: 1.0
In-Reply-To: <d4e5a571-65b9-f932-2df9-addc47031b2c@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jun 07, 2020 at 22:23:20 +0200, Ard Biesheuvel wrote:
> On 6/7/20 10:09 PM, Leif Lindholm via groups.io wrote:
> > Commit 045e4b84c18f  ("ArmPkg/ArmPkg.dsc: Add missing components")
> > adds some components to the ArmPkg.dsc build config, but it adds
> > them to Components.common, and MmCommunicationDxe is AArch64 only.
> > Move it to Components.AARCH64 to stop the ARM build breaking.
> > 
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> > Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> 
> So how does this break only now?

Did you see it hit the upstream tree? You did have some stuck job,
maybe it was stuck because this one had hung?

> In any case,
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Thanks!

Pushed as 6ff7c838d092.

> > ---
> >   ArmPkg/ArmPkg.dsc | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> > index bac1306af61f..48059cf38ed3 100644
> > --- a/ArmPkg/ArmPkg.dsc
> > +++ b/ArmPkg/ArmPkg.dsc
> > @@ -145,8 +145,8 @@ [Components.common]
> >     ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
> >     ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf
> > -  ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
> >   [Components.AARCH64]
> > +  ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
> >     ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf
> >     ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf
> > 
>