From: "Tan, Ming" <ming.tan@intel.com>
To: devel@edk2.groups.io
Subject: [PATCH 1/2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data
Date: Mon, 8 Jun 2020 19:15:46 +0800 [thread overview]
Message-ID: <20200608111547.17649-1-ming.tan@intel.com> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2787
When output string data through serial port, will not ouput \n\r now.
Caller can output several data in one line, and output \n\r when needed.
Signed-off-by: Ming Tan <ming.tan@intel.com>
---
.../Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c | 2 +-
.../StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c | 2 +-
.../Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
index 2455f8b2a9..3aa5642b64 100644
--- a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
+++ b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
@@ -134,7 +134,7 @@ SerialStatusCodeReportWorker (
CharCount = AsciiSPrint (
Buffer,
sizeof (Buffer),
- "%a\n\r",
+ "%a",
((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
);
} else {
diff --git a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c
index 2dc3ecfff5..0b98e7ec63 100644
--- a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c
+++ b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c
@@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
CharCount = AsciiSPrint (
Buffer,
sizeof (Buffer),
- "%a\n\r",
+ "%a",
((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
);
} else {
diff --git a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c
index c0c907b32f..3df0a67126 100644
--- a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c
+++ b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c
@@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
CharCount = AsciiSPrint (
Buffer,
sizeof (Buffer),
- "%a\n\r",
+ "%a",
((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
);
} else {
--
2.24.0.windows.2
next reply other threads:[~2020-06-08 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 11:15 Tan, Ming [this message]
2020-06-08 11:15 ` [PATCH 2/2] MdeModulePkg.dec: Change PCDs for status code Tan, Ming
2020-06-09 2:45 ` [edk2-devel] [PATCH 1/2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608111547.17649-1-ming.tan@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox