public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pete Batard" <pete@akeo.ie>
To: devel@edk2.groups.io
Cc: ard.biesheuvel@arm.com, leif@nuviainc.com
Subject: [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Revert don't connect all devices on an ordinary boot
Date: Mon,  8 Jun 2020 16:51:59 +0100	[thread overview]
Message-ID: <20200608155159.8748-1-pete@akeo.ie> (raw)

This reverts commit c8000ecccc83b728baf04ced2fedb870bc3bc1b3 on account
of USB keyboard devices not being detected until after the timeout to
enter the Setup menu or run the UEFI Shell has expired.

The core of the issue is that, when EfiBootManagerConnectAll() is not
invoked, PCI bus scanning only starts after the BDS wait period has
elapsed, which effectively takes away the ability to use an USB device
to enact Boot Device Selection or interact with the Setup menu.

Signed-off-by: Pete Batard <pete@akeo.ie>
---
 Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
index 253614a646c1..2bd625ad7e7c 100644
--- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
+++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
@@ -655,6 +655,11 @@ PlatformBootManagerAfterConsole (
     Print (BOOT_PROMPT);
   }
 
+  //
+  // Connect the rest of the devices.
+  //
+  EfiBootManagerConnectAll ();
+
   Status = gBS->LocateProtocol (&gEsrtManagementProtocolGuid, NULL, (VOID**)&EsrtManagement);
   if (!EFI_ERROR (Status)) {
     EsrtManagement->SyncEsrtFmp ();
-- 
2.21.0.windows.1


             reply	other threads:[~2020-06-08 15:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08 15:51 Pete Batard [this message]
2020-06-08 16:43 ` [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Revert don't connect all devices on an ordinary boot Ard Biesheuvel
2020-06-08 17:01   ` Pete Batard
2020-06-08 17:10     ` Ard Biesheuvel
2020-06-08 17:24       ` Pete Batard
     [not found]       ` <1616A175B5F96459.24909@groups.io>
2020-06-09 10:01         ` [edk2-devel] " Pete Batard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200608155159.8748-1-pete@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox