From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web10.33153.1591631533416246231 for ; Mon, 08 Jun 2020 08:52:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=OE4kgEsM; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.67, mailfrom: pete@akeo.ie) Received: by mail-wr1-f67.google.com with SMTP id h5so17968601wrc.7 for ; Mon, 08 Jun 2020 08:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YzY/BqE4qoi7lzkgnGje/Ii1IFe4MmWnCVzJmF1cQ0E=; b=OE4kgEsM2nkfoxcitWpr/iAUGDO1WoTtUEmH/heWYYRZXnjFI72pAZ0zyx5+PAjmUq aSywA0nPTalIb0IFnO+26ru75w2DhCO4yWE4tZqNN20nfkONr6RLgm8g9r2LCA8+Z6Sq 7NE4cFB1M6wquxnvROX6msu2w4cWCtZ29FH1bij99rnldbJ3HqNYRPia2DJVMJPAhvhw yWaTZK7msvyMz+wv4PCUgfYxBGlHt2QrYeaImD2tdviNvGQJ4x58ddIlnYycIoGHahK+ OkXqcHcSDSQyfpYEMcwW3LJmtzXOUndG3kD/waMHKPpYaiPDUwXbjd2jVXow8HZKwUVp g1cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YzY/BqE4qoi7lzkgnGje/Ii1IFe4MmWnCVzJmF1cQ0E=; b=RK3rY+9naKSUZ8d3itqgavJSA0Hk9rZ1aovgkb4FyEz8+50xDXZer3KqMHQA2DvQgY E8x9SFrUV1YkU25w4WpJfs0wn138cDV/YWeHQar0YuricAqe7sckOhCClmatwJ6c88sb wMy8VfU8Aat+/qLJKC6lpuoCU2FgBsnGnoN6KZ8LnFJ/cUxRIZc/opSPmO1srFYmPj55 JV3bngtZyeJ6R0Nq2THh7NBVpjkdxBSPJWowSlbz1KV3a0xZsRBZXx2V37pw3io7BHxz K9cZkkZpMSvtdLPAmXQ6G7nPYfq2xGHCzJW831hzZLqhs3fuUELz2GTpYuBFOomFM6RM rwqg== X-Gm-Message-State: AOAM532vLQeU+BKN9NvhvM1RMl/uhQ+qb5RpfZCqZTGAkaUaIO3rLaaf 8n7ZdGoVv8pJAM24mbEGqvGKgrBpGNx4Zg== X-Google-Smtp-Source: ABdhPJyoDLFPOvHRKhpxt7azEVEXWBT61GcyYUm9vEtVIx6e7OEBsruDeLAcTgsXuxk3hccgo9kmbA== X-Received: by 2002:adf:f44b:: with SMTP id f11mr23881544wrp.165.1591631531607; Mon, 08 Jun 2020 08:52:11 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([84.203.48.247]) by smtp.gmail.com with ESMTPSA id t8sm125297wro.56.2020.06.08.08.52.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jun 2020 08:52:10 -0700 (PDT) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com Subject: [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Revert don't connect all devices on an ordinary boot Date: Mon, 8 Jun 2020 16:51:59 +0100 Message-Id: <20200608155159.8748-1-pete@akeo.ie> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This reverts commit c8000ecccc83b728baf04ced2fedb870bc3bc1b3 on account of USB keyboard devices not being detected until after the timeout to enter the Setup menu or run the UEFI Shell has expired. The core of the issue is that, when EfiBootManagerConnectAll() is not invoked, PCI bus scanning only starts after the BDS wait period has elapsed, which effectively takes away the ability to use an USB device to enact Boot Device Selection or interact with the Setup menu. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c index 253614a646c1..2bd625ad7e7c 100644 --- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c +++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c @@ -655,6 +655,11 @@ PlatformBootManagerAfterConsole ( Print (BOOT_PROMPT); } + // + // Connect the rest of the devices. + // + EfiBootManagerConnectAll (); + Status = gBS->LocateProtocol (&gEsrtManagementProtocolGuid, NULL, (VOID**)&EsrtManagement); if (!EFI_ERROR (Status)) { EsrtManagement->SyncEsrtFmp (); -- 2.21.0.windows.1