From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web10.583.1591636886727829129 for ; Mon, 08 Jun 2020 10:21:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=D3CuBApD; spf=pass (domain: nuviainc.com, ip: 209.85.221.65, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f65.google.com with SMTP id r7so18297266wro.1 for ; Mon, 08 Jun 2020 10:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3B/+E0YxC7b4ve2c3K+GCOciHPCrftnmtHQz/D6v948=; b=D3CuBApDvieaCfAa18LnrbAWHQxXNXjnxsIfpUkg5ajfBhop0o8xI8fsaZXgV7071D 28w7lTJUgNG8VeOnYwwW2WSzDuR+zO4qc/5MdMhrWiq/TcCkLllXRyaZHZGyxX+I48Je kCv15DzRrB8CfAvl2LSlU8fQyOZGodHK2lOcx2pzv1R8IsYIN0gBCsVwCtb+NWnBuh2i fFkoU1IjJ76YxlSlOYIZHr2kByRURY04EZYGKgcsbJesr847mw9ZHBa43hXcHle7eXZv vJQh5yffB5Zw/yoDuZMnJNVefGdugPC4T7YBBjKEVJPBmKv141jqCgF4LfotUnkOF+Zq QdJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3B/+E0YxC7b4ve2c3K+GCOciHPCrftnmtHQz/D6v948=; b=hGHzzpC59tVj8FLqYfs0uI1CK8ttkzskGlREqb3baGnSzQrq0NNHEFVXsq8qTkDgep 1hzK+e23F7m1JwNNhniyHaZ1Jpe7w8VyMxhWrm2clsi04fwR5p3wDuyZdM03DGs8x1bJ VywMpcuuPRZzv2Kmr1nJLxxNo+kbVA0eKWRvZYCr4MpO4vHH8YleB5JR+sujtNnGdJu1 nIXGh81sw/bh+O1I1dgYupoRXoe44luG7ye0Gj3yXd7ipDFpxrFrP7hUty2kpHGGq6d3 kkvwMcTUnwzl2YO7OP1/n3Gu14ADai5KsV4BXA/AmblqAEf7cvfsGVvFB8BqmLK8OhzR NIvg== X-Gm-Message-State: AOAM533iS+ZNiuDu9qT359rzf6eKM9UiF3nTJ7tD3c2A200Cpo6GeYZ4 EZpI2TSZdEA7YlWlGp8uL+hEsU2/idE4AlwuxEeITnJoVsBe2Q1nfB9yt+8a2ouQZyUQTJSj3eA cxYyVd0aWg4bdK1J27Mhy+vDlrTLN7o2fBJdWyIKsxFCXa4bBLZuT2GQunrMBylA= X-Google-Smtp-Source: ABdhPJxN7/nf0IzM66uZJ6Yrvu7gNsQFJugMo9GOYCYt0ePN3mcM/16iMDGBOk8mL/rEabTWUnMc0A== X-Received: by 2002:a5d:5489:: with SMTP id h9mr23993376wrv.125.1591636885061; Mon, 08 Jun 2020 10:21:25 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id h15sm344834wrt.73.2020.06.08.10.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 10:21:24 -0700 (PDT) Date: Mon, 8 Jun 2020 18:21:21 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, huangming23@huawei.com Cc: jian.j.wang@intel.com, hao.a.wu@intel.com, liming.gao@intel.com, lidongzhan@huawei.com, songdongkuang@huawei.com, wanghuiqiang@huawei.com, qiuliangen@huawei.com, shenlimei@huawei.com Subject: Re: [edk2-devel] [PATCH edk2 v2 5/5] Silicon/Hisilicon/FlashFvbDxe: Declare missing GUID dependency Message-ID: <20200608172121.GV28566@vanye> References: <1590590038-19724-1-git-send-email-huangming23@huawei.com> <1590590038-19724-6-git-send-email-huangming23@huawei.com> MIME-Version: 1.0 In-Reply-To: <1590590038-19724-6-git-send-email-huangming23@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 27, 2020 at 22:33:58 +0800, Ming Huang wrote: > FlashFvbDxe depends on gEfiEventVirtualAddressChangeGuid, but got > away with not declaring it in its INF because of a transitive > dependency. However, this dependency got dropped in core EDK2, > resulting in build failures of the D0x platform. > > Signed-off-by: Ming Huang This file is a prerequisite for building the remaining patches, so should have come in as 1/5. Regardless, it has no dependencies on 1-4, so: Reviewed-by: Leif Lindholm Pushed as cf2f013b9dee. > --- > Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf b/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf > index 23591b8..1119361 100644 > --- a/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf > +++ b/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf > @@ -38,6 +38,7 @@ > UefiRuntimeLib > > [Guids] > + gEfiEventVirtualAddressChangeGuid > gEfiSystemNvDataFvGuid > gEfiVariableGuid > > -- > 2.8.1 > > > >