From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>,
Laszlo Ersek <lersek@redhat.com>,
Leif Lindholm <leif@nuviainc.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Julien Grall <julien@xen.org>, Jiewen Yao <jiewen.yao@intel.com>,
Sami Mujawar <Sami.Mujawar@arm.com>,
Jiewen Yao <Jiewen.yao@intel.com>
Subject: [PATCH v2 3/3] ArmVirtPkg: remove unused files
Date: Thu, 11 Jun 2020 14:52:28 +0200 [thread overview]
Message-ID: <20200611125228.252500-4-ard.biesheuvel@arm.com> (raw)
In-Reply-To: <20200611125228.252500-1-ard.biesheuvel@arm.com>
We no longer use ELF PIE executables to implement the self-relocating
PrePi so drop the custom linker script and visibility override header
file.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Sami Mujawar <Sami.Mujawar@arm.com>
---
ArmVirtPkg/Include/Platform/Hidden.h | 22 -----------
ArmVirtPkg/PrePi/Scripts/PrePi-PIE.lds | 41 --------------------
2 files changed, 63 deletions(-)
diff --git a/ArmVirtPkg/Include/Platform/Hidden.h b/ArmVirtPkg/Include/Platform/Hidden.h
deleted file mode 100644
index 7a7bdb42b8bd..000000000000
--- a/ArmVirtPkg/Include/Platform/Hidden.h
+++ /dev/null
@@ -1,22 +0,0 @@
-/** @file
-
- Copyright (c) 2018, Linaro Limited. All rights reserved.
-
- SPDX-License-Identifier: BSD-2-Clause-Patent
-
-**/
-
-#ifndef __PLATFORM_HIDDEN_H
-#define __PLATFORM_HIDDEN_H
-
-//
-// Setting the GCC -fvisibility=hidden command line option is not quite the same
-// as setting the pragma below: the former only affects definitions, whereas the
-// pragma affects extern declarations as well. So if we want to ensure that no
-// GOT indirected symbol references are emitted, we need to use the pragma, or
-// GOT based cross object references could be emitted, e.g., in libraries, and
-// these cannot be relaxed to ordinary symbol references at link time.
-//
-#pragma GCC visibility push (hidden)
-
-#endif
diff --git a/ArmVirtPkg/PrePi/Scripts/PrePi-PIE.lds b/ArmVirtPkg/PrePi/Scripts/PrePi-PIE.lds
deleted file mode 100644
index c9a15ca3493a..000000000000
--- a/ArmVirtPkg/PrePi/Scripts/PrePi-PIE.lds
+++ /dev/null
@@ -1,41 +0,0 @@
-/** @file
-
- Copyright (c) 2015, Linaro Ltd. All rights reserved.<BR>
-
- SPDX-License-Identifier: BSD-2-Clause-Patent
-
-**/
-
-SECTIONS
-{
- PROVIDE(__reloc_base = .);
-
- . = PECOFF_HEADER_SIZE;
- .text : ALIGN(CONSTANT(COMMONPAGESIZE)) {
- *(.text .text*)
- *(.got .got*)
- *(.rodata .rodata*)
- *(.data .data*)
- *(.bss .bss*)
-
- . = ALIGN(0x20);
- PROVIDE(__reloc_start = .);
- *(.rel .rel.*)
- *(.rela .rela.*)
- PROVIDE(__reloc_end = .);
- }
-
- .note (INFO) : { *(.note.gnu.build-id) }
-
- /DISCARD/ : {
- *(.note.GNU-stack)
- *(.gnu.hash)
- *(.gnu_debuglink)
- *(.interp)
- *(.dynamic)
- *(.dynsym)
- *(.dynstr)
- *(.hash)
- *(.comment)
- }
-}
--
2.26.2
next prev parent reply other threads:[~2020-06-11 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 12:52 [PATCH v2 0/3] ArmVirtPkg: use PE/COFF metadata for self relocation Ard Biesheuvel
2020-06-11 12:52 ` [PATCH v2 1/3] ArmVirtPkg: add FDF rule for self-relocating PrePi Ard Biesheuvel
2020-06-11 12:52 ` [PATCH v2 2/3] ArmVirtPkg/PrePi: use standard PeCoff routines for self-relocation Ard Biesheuvel
2020-06-11 12:52 ` Ard Biesheuvel [this message]
2020-06-11 17:50 ` [PATCH v2 0/3] ArmVirtPkg: use PE/COFF metadata for self relocation Laszlo Ersek
2020-06-12 22:18 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611125228.252500-4-ard.biesheuvel@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox