[PATCH v4 00/17] Add a pipline to check Ecc issues for edk2 on open ci

[PATCH v4 00/17] Add a pipline to check Ecc issues for edk2 on open ci

[Zhang, Shenglei]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now, but these are V3 series. So I expect that contributors in
edk2 community can try using this script when reviewing. And I appreciate
receiving feedback and comments if someone find errors or false positive
issues.

I created a pipline of EccCheck for my forked edk2.
https://dev.azure.com/shengleizhang/shengleizhang/_build?definitionId=10&_a=summary

The patch series are big, so the commits are also pushed into my forked tree.
https://github.com/shenglei10/edk2/commits/ECC

Patches
1/17: EccCheck.py is a tool to report Ecc issues for commits. It can be run
     on azure servers for open ci, or locally. Its usage is like
     PatchCheck.py.
2/17: It's a lib necessary for py3 to run Ecc on azure servers. For local
     use, we need to type command
     "py -3 -m pip install antlr4-python3-runtime==4.7.1" first.
3/17: Windows-EccCheck.yml is a yaml file to configure the newly added
     pipline. Azure uses this to create a pipline.
4/17~17/17: We consider some cases that will report out Ecc issues but they won't
     be fixed, like submodule and industry standard related things. So we
     add two configuration fields "Exception" and "IgnoreFiles" for people
     to use. These patches add configuration in yaml files for Ecc check.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>

v2: Update 1/17, fix the bug that the script can't hanlde multiple commits.

v3: Update 1/17, set the only workalbe workspace is edk2 root directory.
    Update 2/17, designate the version of antlr4 is 4.7.1.
    Add 4/17~17/17.

v4. Update 1/17, remove the function EdksetupRebuild(), instead add
    function SetupEnvironment(). Update variables' format and type hints
    to pass flake8 and mypy.

Shenglei Zhang (17):
  BaseTools/Scripts: Add EccCheck.py
  pip-requirements.txt: Add Ecc required lib
  .azurepiplines: Add a pipline to check ECC issues for commits
  MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check
  ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check
  CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check
  EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check
  FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check
  FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check
  MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check
  NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check
  OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check
  PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check
  SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check
  ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check
  UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check
  UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file

 .azurepipelines/Windows-EccCheck.yml          |  38 ++
 ArmVirtPkg/ArmVirtPkg.ci.yaml                 |  10 +
 BaseTools/Scripts/EccCheck.py                 | 419 ++++++++++++++++++
 CryptoPkg/CryptoPkg.ci.yaml                   |  10 +
 EmulatorPkg/EmulatorPkg.ci.yaml               |  10 +
 FatPkg/FatPkg.ci.yaml                         |  10 +
 FmpDevicePkg/FmpDevicePkg.ci.yaml             |  10 +
 MdeModulePkg/MdeModulePkg.ci.yaml             |  10 +
 MdePkg/MdePkg.ci.yaml                         |  10 +
 NetworkPkg/NetworkPkg.ci.yaml                 |  10 +
 OvmfPkg/OvmfPkg.ci.yaml                       |  10 +
 PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml         |  10 +
 SecurityPkg/SecurityPkg.ci.yaml               |  10 +
 ShellPkg/ShellPkg.ci.yaml                     |  10 +
 UefiCpuPkg/UefiCpuPkg.ci.yaml                 |  10 +
 .../UnitTestFrameworkPkg.ci.yaml              |  10 +
 pip-requirements.txt                          |   1 +
 17 files changed, 598 insertions(+)
 create mode 100644 .azurepipelines/Windows-EccCheck.yml
 create mode 100644 BaseTools/Scripts/EccCheck.py

-- 
2.18.0.windows.1

[PATCH v4 01/17] BaseTools/Scripts: Add EccCheck.py

[Zhang, Shenglei]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck.py is a tool to report Ecc issues for commits, which will
be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their code in source code files. And comment
issues can also be handled.

Its usage is similar to PatchCheck.py. Type EccCheck.py -h and then
learn how to use it.

If a patch passes EccCheck, "Ecc Pass" will show up.
Otherwise, "Ecc error detected" alerts the users and the details
are also presented.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 BaseTools/Scripts/EccCheck.py | 419 ++++++++++++++++++++++++++++++++++
 1 file changed, 419 insertions(+)
 create mode 100644 BaseTools/Scripts/EccCheck.py

diff --git a/BaseTools/Scripts/EccCheck.py b/BaseTools/Scripts/EccCheck.py
new file mode 100644
index 000000000000..8049e95656be
--- /dev/null
+++ b/BaseTools/Scripts/EccCheck.py
@@ -0,0 +1,419 @@
+## @file
+#  Check a patch for various format issues
+#
+#  Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+#
+#  SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+
+import os
+import re
+import csv
+import subprocess
+import argparse
+import sys
+import yaml
+import xml.dom.minidom
+from typing import List, Dict, Tuple, Any
+
+__copyright__ = "Copyright (c) 2020, Intel Corporation  All rights reserved."
+ReModifyFile = re.compile(r'[B-Q,S-Z]+[\d]*\t(.*?)\n')
+FindModifyFile = re.compile(r'\+\+\+ b\/(.*)')
+LineScopePattern = (r'@@ -\d*\,*\d* \+\d*\,*\d* @@.*')
+LineNumRange = re.compile(r'@@ -\d*\,*\d* \+(\d*)\,*(\d*) @@.*')
+
+EnvList = os.environ
+GlobalSymbol = {}
+
+
+def AppendException(exception_list: List[str], exception_xml: str) -> None:
+    error_code_list = exception_list[::2]
+    keyword_list = exception_list[1::2]
+    dom_tree = xml.dom.minidom.parse(exception_xml)
+    root_node = dom_tree.documentElement
+    for error_code, keyword in zip(error_code_list, keyword_list):
+        customer_node = dom_tree.createElement("Exception")
+        keyword_node = dom_tree.createElement("KeyWord")
+        keyword_node_text_value = dom_tree.createTextNode(keyword)
+        keyword_node.appendChild(keyword_node_text_value)
+        customer_node.appendChild(keyword_node)
+        error_code_node = dom_tree.createElement("ErrorID")
+        error_code_text_value = dom_tree.createTextNode(error_code)
+        error_code_node.appendChild(error_code_text_value)
+        customer_node.appendChild(error_code_node)
+        root_node.appendChild(customer_node)
+
+    with open(exception_xml, 'w') as f:
+        dom_tree.writexml(f, indent='', addindent='', newl='\n', encoding='UTF-8')
+
+
+def GetPkgList() -> List[str]:
+    WORKDIR = EnvList['WORKDIR']
+    dirs = os.listdir(WORKDIR)
+    pkg_list = []
+    for directory in dirs:
+        if directory.endswith('Pkg'):
+            pkg_list.append(directory)
+    return pkg_list
+
+
+def GenerateEccReport(modify_dir_list: List[str], ecc_diff_range: Dict[str, List[Tuple[int, int]]]) -> None:
+    ecc_need = False
+    ecc_run = True
+    pkg_list = GetPkgList()
+
+    for line in modify_dir_list:
+        print('Run ECC tool for the commit in %s' % line)
+        GlobalSymbol['GenerateEccReport'] = True
+        for pkg in pkg_list:
+            if pkg in line:
+                ecc_need = True
+                ecc_cmd = ["py", "-3", "%WORKDIR%\\BaseTools\\Source\\Python\\Ecc\\EccMain.py",
+                                 "-c", "%WORKDIR%\\BaseTools\\Source\\Python\\Ecc\\config.ini",
+                                 "-e", "%WORKDIR%\\BaseTools\\Source\\Python\\Ecc\\exception.xml",
+                                 "-t", "%WORKDIR%\\{}".format(line),
+                                 "-r", "%WORKDIR%\\Ecc.csv"]
+                _, _, result, return_code = ExecuteScript(ecc_cmd, EnvList, shell=True)
+                if return_code != 0:
+                    ecc_run = False
+                    break
+
+        if not ecc_run:
+            print('Fail to run ECC tool')
+            GlobalSymbol['SCRIPT_ERROR'] = True
+            EndDelFile()
+
+        if GlobalSymbol.get('GenerateEccReport'):
+            ParseEccReport(ecc_diff_range)
+        else:
+            print("Patch check tool or ECC tool don't detect error")
+
+    if ecc_need:
+        revert_cmd = ["git", "checkout", "--", "%WORKDIR%\\BaseTools\\Source\\Python\\Ecc\\exception.xml"]
+        _, _, result, return_code = ExecuteScript(revert_cmd, EnvList, shell=True)
+    else:
+        print("Doesn't need run ECC check")
+        return
+
+
+def ParseEccReport(ecc_diff_range: Dict[str, List[Tuple[int, int]]]) -> None:
+    WORKDIR = EnvList['WORKDIR']
+    ecc_log = os.path.join(WORKDIR, "Ecc.log")
+    ecc_csv = "Ecc.csv"
+    file = os.listdir(WORKDIR)
+    row_lines = []
+    if ecc_csv in file:
+        with open(ecc_csv) as csv_file:
+            reader = csv.reader(csv_file)
+            for row in reader:
+                for modify_file in ecc_diff_range:
+                    if modify_file in row[3]:
+                        for i in ecc_diff_range[modify_file]:
+                            line_no = int(row[4])
+                            if i[0] <= line_no <= i[1]:
+                                row[0] = '\nEFI coding style error'
+                                row[1] = 'Error code: ' + row[1]
+                                row[3] = 'file: ' + row[3]
+                                row[4] = 'Line number: ' + row[4]
+                                row_line = '\n  *'.join(row)
+                                row_lines.append(row_line)
+                                break
+                        break
+    if row_lines:
+        GlobalSymbol['ECC_PASS'] = False
+
+    with open(ecc_log, 'a') as log:
+        all_line = '\n'.join(row_lines)
+        all_line = all_line + '\n'
+        log.writelines(all_line)
+
+
+def RemoveFile(file: str) -> None:
+    if os.path.exists(file):
+        os.remove(file)
+
+
+def ExecuteScript(command: List[str], env_variables: Any, collect_env: bool = False,
+                  enable_std_pipe: bool = False, shell: bool = True) -> Tuple[str, str, Dict[str, str], int]:
+    env_marker = '-----env-----'
+    env: Dict[str, str] = {}
+    kwarg = {"env": env_variables,
+             "universal_newlines": True,
+             "shell": shell,
+             "cwd": env_variables["WORKSPACE"]}
+
+    if enable_std_pipe or collect_env:
+        kwarg["stdout"] = subprocess.PIPE
+        kwarg["stderr"] = subprocess.PIPE
+
+    if collect_env:
+        # get the binary that prints environment variables based on os
+        if os.name == 'nt':
+            get_var_command = "set"
+        else:
+            get_var_command = "env"
+        # modify the command to print the environment variables
+        if isinstance(command, list):
+            command += ["&&", "echo", env_marker, "&&",
+                        get_var_command, "&&", "echo", env_marker]
+        else:
+            command += " " + " ".join(["&&", "echo", env_marker,
+                                       "&&", get_var_command,
+                                       "&&", "echo", env_marker])
+
+    # execute the command
+    execute = subprocess.Popen(command, **kwarg)
+    std_out, stderr = execute.communicate()
+    code = execute.returncode
+
+    # wait for process to be done
+    execute.wait()
+
+    # if collect enviroment variables
+    if collect_env:
+        # get the new environment variables
+        std_out, env = GetEnvironmentVariables(std_out, env_marker)
+    return (std_out, stderr, env, code)
+
+
+def GetEnvironmentVariables(std_out_str: str, marker: str) -> Tuple[str, Dict[str, str]]:
+    start_env_update = False
+    environment_vars = {}
+    out_put = ""
+    for line in std_out_str.split("\n"):
+        if start_env_update and len(line.split("=")) == 2:
+            key, value = line.split("=")
+            environment_vars[key] = value
+        else:
+            out_put += "\n" + line.replace(marker, "")
+
+        if marker in line:
+            if start_env_update:
+                start_env_update = False
+            else:
+                start_env_update = True
+    return (out_put, environment_vars)
+
+
+def EndDelFile() -> None:
+    WORKDIR = EnvList['WORKDIR']
+    modify_file_list_log = os.path.join(WORKDIR, 'PatchModifyFiles.log')
+    RemoveFile(modify_file_list_log)
+    patch_log = os.path.join(WORKDIR, 'PatchFile.log')
+    RemoveFile(patch_log)
+    file_log = os.path.join(WORKDIR, "File.log")
+    RemoveFile(file_log)
+    if GlobalSymbol.get('GenerateEccReport'):
+        file_list = os.listdir(WORKDIR)
+        csv_list = [os.path.join(WORKDIR, file) for file in file_list if file.endswith('.csv')]
+        for csv_file in csv_list:
+            RemoveFile(csv_file)
+    if GlobalSymbol.get('SCRIPT_ERROR'):
+        print('ECC tool detect error')
+        exit(1)
+
+
+def GetDiffrange(commit: str) -> Dict[str, List[Tuple[int, int]]]:
+    WORKDIR = EnvList['WORKDIR']
+    range_directory: Dict[str, List[Tuple[int, int]]] = {}
+    patch_log = os.path.join(WORKDIR, 'PatchFile.log')
+    format_patch_cmd = ["git", "show", str(commit), "--unified=0", ">", patch_log]
+    _, _, result, return_code = ExecuteScript(format_patch_cmd, EnvList, shell=True)
+    if return_code != 0:
+        print('Fail to run GIT')
+        GlobalSymbol['SCRIPT_ERROR'] = True
+        EndDelFile()
+    with open(patch_log, encoding='utf8') as patch_file:
+        file_lines = patch_file.readlines()
+        IsDelete = True
+        StartCheck = False
+        for line in file_lines:
+            modify_file = FindModifyFile.findall(line)
+            if modify_file and not StartCheck and os.path.isfile(modify_file[0]):
+                modify_file_comment_dic = GetCommentRange(modify_file[0])
+                IsDelete = False
+                StartCheck = True
+                modify_file_dic = modify_file[0]
+                modify_file_dic = modify_file_dic.replace("/", "\\")
+                range_directory[modify_file_dic] = []
+            elif line.startswith('--- '):
+                StartCheck = False
+            elif re.match(LineScopePattern, line, re.I) and not IsDelete and StartCheck:
+                start_line = LineNumRange.search(line).group(1)
+                line_range = LineNumRange.search(line).group(2)
+                if not line_range:
+                    line_range = '1'
+                range_directory[modify_file_dic].append((int(start_line), int(start_line) + int(line_range) - 1))
+                for i in modify_file_comment_dic:
+                    if i[0] <= int(start_line) <= i[1]:
+                        range_directory[modify_file_dic].append(i)
+    return range_directory
+
+
+def GetCommentRange(modify_file: str) -> List[Tuple[int, int]]:
+    WORKDIR = EnvList['WORKDIR']
+    modify_file_path = os.path.join(WORKDIR, modify_file)
+    with open(modify_file_path) as f:
+        line_no = 1
+        comment_range: List[Tuple[int, int]] = []
+        Start = False
+        for line in f:
+            if line.startswith('/**'):
+                startno = line_no
+                Start = True
+            if line.startswith('**/') and Start:
+                endno = line_no
+                Start = False
+                comment_range.append((int(startno), int(endno)))
+            line_no += 1
+
+    if comment_range and comment_range[0][0] == 1:
+        del comment_range[0]
+    return comment_range
+
+
+def GetModifyDir(commit: str) -> List[str]:
+    WORKDIR = EnvList['WORKDIR']
+    modify_dir_list = []
+    modify_file_list_log = os.path.join(WORKDIR, 'PatchModifyFiles.log')
+    EnvList['ModifyFileListLog'] = modify_file_list_log
+    patch_modify_cmd = ["git", "diff", "--name-status", str(commit), str(commit) + "~1", ">", modify_file_list_log]
+    _, _, result, return_code = ExecuteScript(patch_modify_cmd, EnvList, shell=True)
+    if return_code != 0:
+        print('Fail to run GIT')
+        GlobalSymbol['SCRIPT_ERROR'] = True
+        EndDelFile()
+    with open(modify_file_list_log) as modify_file:
+        file_lines = modify_file.readlines()
+    for Line in file_lines:
+        file_path = ReModifyFile.findall(Line)
+        if file_path:
+            file_dir = os.path.dirname(file_path[0])
+        else:
+            continue
+        pkg_list = GetPkgList()
+        if file_dir in pkg_list or not file_dir:
+            continue
+        else:
+            modify_dir_list.append('%s' % file_dir)
+
+    modify_dir_list = list(set(modify_dir_list))
+    return modify_dir_list
+
+
+def ApplyConfig(modify_dir_list: List[str], ecc_diff_range: Dict[str, List[Tuple[int, int]]]) -> None:
+    WORKDIR = EnvList['WORKDIR']
+    modify_pkg_list = []
+    for modify_dir in modify_dir_list:
+        modify_pkg = modify_dir.split("/")[0]
+        modify_pkg_list.append(modify_pkg)
+    modify_pkg_list = list(set(modify_pkg_list))
+    for modify_pkg in modify_pkg_list:
+        pkg_config_file = os.path.join(WORKDIR, modify_pkg, modify_pkg + ".ci.yaml")
+        if os.path.exists(pkg_config_file):
+            with open(pkg_config_file, 'r') as f:
+                pkg_config = yaml.safe_load(f)
+            if "EccCheck" in pkg_config:
+                ecc_config = pkg_config["EccCheck"]
+                #
+                # Add exceptions
+                #
+                exception_list = ecc_config["ExceptionList"]
+                exception_xml = os.path.join(WORKDIR, "BaseTools", "Source", "Python", "Ecc", "exception.xml")
+                if os.path.exists(exception_xml):
+                    AppendException(exception_list, exception_xml)
+                #
+                # Exclude ignored files
+                #
+                ignore_file_list = ecc_config['IgnoreFiles']
+                for ignore_file in ignore_file_list:
+                    ignore_file = ignore_file.replace("/", "\\")
+                    ignore_file = os.path.join(modify_pkg, ignore_file)
+                    if ignore_file in ecc_diff_range:
+                        del ecc_diff_range[ignore_file]
+    return
+
+
+def CheckOneCommit(commit: str) -> None:
+    WORKDIR = EnvList['WORKDIR']
+    if not WORKDIR.endswith('edk2') and not WORKDIR.endswith('Edk2') and not WORKDIR.endswith('\\s'):
+        print(WORKDIR)
+        print("Error: invalid workspace.\nBefore using EccCheck.py, please change workspace to edk2 root directory!")
+        exit(1)
+    modify_dir_list = GetModifyDir(commit)
+    ecc_diff_range = GetDiffrange(commit)
+    ApplyConfig(modify_dir_list, ecc_diff_range)
+    GenerateEccReport(modify_dir_list, ecc_diff_range)
+    EndDelFile()
+
+
+def parse_options() -> argparse.Namespace:
+    parser = argparse.ArgumentParser(description=__copyright__)
+    parser.add_argument('commits', nargs='*',
+                        help='[commit(s) ID | number of commits, like "-3" means check first 3 commits]')
+    args = parser.parse_args()
+    return args
+
+
+def read_commit_list_from_git(start_commit: str, count: int) -> List[str]:
+    cmd = ['git', 'rev-list', '--abbrev-commit', '--no-walk']
+    if count != 0:
+        cmd.append('--max-count=' + str(count))
+    cmd.append(start_commit)
+    p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
+    result = p.communicate()
+    out = result[0].decode('utf-8', 'ignore') if result[0] and result[0].find(b"fatal") != 0 else None
+    return out.split() if out else []
+
+
+def ReleaseReport() -> int:
+    WORKDIR = EnvList['WORKDIR']
+    ecc_log = os.path.join(WORKDIR, "ECC.log")
+    if GlobalSymbol['ECC_PASS']:
+        print('\n===================Ecc pass===================')
+        RemoveFile(ecc_log)
+        return 0
+    else:
+        print('\n===================Ecc error detected===================')
+        with open(ecc_log) as output:
+            print(output.read())
+        RemoveFile(ecc_log)
+        return -1
+
+
+def SetupEnvironment() -> None:
+    WORKDIR = os.getcwd()
+    EnvList['WORKDIR'] = WORKDIR
+    EnvList['WORKSPACE'] = WORKDIR
+    python_path = os.path.join(WORKDIR, "BaseTools", "Source", "Python")
+    EnvList['PYTHONPATH'] = python_path
+
+
+def main() -> int:
+    commits = parse_options().commits
+
+    if len(commits) == 0:
+        commits = ['HEAD']
+
+    if len(commits[0]) >= 2 and commits[0][0] == '-':
+        count = int(commits[0][1:])
+        commits = read_commit_list_from_git('HEAD', count)
+
+    """
+        This 'if' block is only used for creating pull request.
+    """
+    if ".." in commits[0]:
+        commits = read_commit_list_from_git(commits[0], 0)
+
+    GlobalSymbol['ECC_PASS'] = True
+
+    SetupEnvironment()
+    for commit in commits:
+        CheckOneCommit(commit)
+
+    retval = ReleaseReport()
+    return retval
+
+
+if __name__ == "__main__":
+    sys.exit(main())
-- 
2.18.0.windows.1

[PATCH v4 02/17] pip-requirements.txt: Add Ecc required lib

[Zhang, Shenglei]

antlr4-python3-runtime is a lib to support Ecc run with Py3.x.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 pip-requirements.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pip-requirements.txt b/pip-requirements.txt
index 574dac43b1a6..0fecd37f2a83 100644
--- a/pip-requirements.txt
+++ b/pip-requirements.txt
@@ -14,3 +14,4 @@
 
 edk2-pytool-library==0.10.*
 edk2-pytool-extensions~=0.13.3
+antlr4-python3-runtime==4.7.1
-- 
2.18.0.windows.1

[PATCH v4 03/17] .azurepiplines: Add a pipline to check ECC issues for commits

[Zhang, Shenglei]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
Add a pipeline to run the ECC checks on Azure Pipelines agents
for edk2 open ci.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .azurepipelines/Windows-EccCheck.yml | 38 ++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 .azurepipelines/Windows-EccCheck.yml

diff --git a/.azurepipelines/Windows-EccCheck.yml b/.azurepipelines/Windows-EccCheck.yml
new file mode 100644
index 000000000000..0d20551efb5f
--- /dev/null
+++ b/.azurepipelines/Windows-EccCheck.yml
@@ -0,0 +1,38 @@
+## @file
+# Azure Pipielines YML file that evalues the patch series in a PR using the
+# python script BaseTools/Scripts/PatchCheck.py.
+#
+# NOTE: This example monitors pull requests against the edk2-ci branch.  Most
+# environments would replace 'edk2-ci' with 'master'.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+# https://github.com/tianocore
+#
+##
+
+trigger: none
+
+pr:
+- master
+
+pool:
+  vmImage: 'windows-latest'
+
+steps:
+- checkout: self
+  clean: true
+
+- task: UsePythonVersion@0
+  inputs:
+    versionSpec: '3.8.x'
+    architecture: 'x64'
+
+- script: pip install -r pip-requirements.txt
+  displayName: 'Install/Upgrade pip modules'
+
+- script: |
+    git fetch origin $(System.PullRequest.TargetBranch):$(System.PullRequest.TargetBranch)
+    py -3 BaseTools/Scripts/EccCheck.py $(System.PullRequest.TargetBranch)..$(System.PullRequest.SourceCommitId)
+  displayName: 'Use EccCheck.py to verify patch series in pull request'
-- 
2.18.0.windows.1

[PATCH v4 04/17] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 MdeModulePkg/MdeModulePkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml
index 1cfc1328390e..cfdac0a73f0c 100644
--- a/MdeModulePkg/MdeModulePkg.ci.yaml
+++ b/MdeModulePkg/MdeModulePkg.ci.yaml
@@ -5,6 +5,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     ## options defined ci/Plugin/CompilerPlugin
     "CompilerPlugin": {
         "DscPath": "MdeModulePkg.dsc"
-- 
2.18.0.windows.1

[PATCH v4 05/17] ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
 ArmVirtPkg/ArmVirtPkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
index 4553725ee528..b52e621b3c5c 100644
--- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
+++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
@@ -8,6 +8,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     ## options defined .pytool/Plugin/CompilerPlugin
     "CompilerPlugin": {
         "DscPath": "" # Don't support this test
-- 
2.18.0.windows.1

[PATCH v4 06/17] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 CryptoPkg/CryptoPkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index f54ebfb22e70..2c1a8a7f5072 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -5,6 +5,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     "CompilerPlugin": {
         "DscPath": "CryptoPkg.dsc"
     },
-- 
2.18.0.windows.1

[PATCH v4 07/17] EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 EmulatorPkg/EmulatorPkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/EmulatorPkg/EmulatorPkg.ci.yaml b/EmulatorPkg/EmulatorPkg.ci.yaml
index 81f81780ec76..a5c932366c8a 100644
--- a/EmulatorPkg/EmulatorPkg.ci.yaml
+++ b/EmulatorPkg/EmulatorPkg.ci.yaml
@@ -8,6 +8,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     ## options defined .pytool/Plugin/CompilerPlugin
     "CompilerPlugin": {
         "DscPath": "" # Don't support this test
-- 
2.18.0.windows.1

[PATCH v4 08/17] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 FatPkg/FatPkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg.ci.yaml
index 8b0fb1d4fcd5..82069d3a7534 100644
--- a/FatPkg/FatPkg.ci.yaml
+++ b/FatPkg/FatPkg.ci.yaml
@@ -5,6 +5,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     "CompilerPlugin": {
         "DscPath": "FatPkg.dsc"
     },
-- 
2.18.0.windows.1

[PATCH v4 09/17] FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 FmpDevicePkg/FmpDevicePkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/FmpDevicePkg/FmpDevicePkg.ci.yaml b/FmpDevicePkg/FmpDevicePkg.ci.yaml
index 74a0aefe8e49..99ffa4aae8f2 100644
--- a/FmpDevicePkg/FmpDevicePkg.ci.yaml
+++ b/FmpDevicePkg/FmpDevicePkg.ci.yaml
@@ -5,6 +5,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     "CompilerPlugin": {
         "DscPath": "FmpDevicePkg.dsc"
     },
-- 
2.18.0.windows.1

[PATCH v4 10/17] MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 MdePkg/MdePkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
index 3268f1535499..e779dac912b4 100644
--- a/MdePkg/MdePkg.ci.yaml
+++ b/MdePkg/MdePkg.ci.yaml
@@ -5,6 +5,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     ## options defined ci/Plugin/CompilerPlugin
     "CompilerPlugin": {
         "DscPath": "MdePkg.dsc"
-- 
2.18.0.windows.1

[PATCH v4 11/17] NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
---
 NetworkPkg/NetworkPkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/NetworkPkg/NetworkPkg.ci.yaml b/NetworkPkg/NetworkPkg.ci.yaml
index 70f2e1014748..7cd61912c71e 100644
--- a/NetworkPkg/NetworkPkg.ci.yaml
+++ b/NetworkPkg/NetworkPkg.ci.yaml
@@ -5,6 +5,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     "CompilerPlugin": {
         "DscPath": "NetworkPkg.dsc"
     },
-- 
2.18.0.windows.1

[PATCH v4 12/17] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/OvmfPkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml
index 98992f0429ff..67561c0bace0 100644
--- a/OvmfPkg/OvmfPkg.ci.yaml
+++ b/OvmfPkg/OvmfPkg.ci.yaml
@@ -8,6 +8,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     ## options defined .pytool/Plugin/CompilerPlugin
     "CompilerPlugin": {
         "DscPath": "" # Don't support this test
-- 
2.18.0.windows.1

[PATCH v4 13/17] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
index be470807bd9e..5809ff8e3b1c 100644
--- a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
+++ b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
@@ -5,6 +5,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     "CompilerPlugin": {
         "DscPath": "PcAtChipsetPkg.dsc"
     },
-- 
2.18.0.windows.1

[PATCH v4 14/17] SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 SecurityPkg/SecurityPkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/SecurityPkg/SecurityPkg.ci.yaml b/SecurityPkg/SecurityPkg.ci.yaml
index 953219053318..dc70ce642171 100644
--- a/SecurityPkg/SecurityPkg.ci.yaml
+++ b/SecurityPkg/SecurityPkg.ci.yaml
@@ -5,6 +5,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     "CompilerPlugin": {
         "DscPath": "SecurityPkg.dsc"
     },
-- 
2.18.0.windows.1

[PATCH v4 15/17] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 ShellPkg/ShellPkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/ShellPkg/ShellPkg.ci.yaml b/ShellPkg/ShellPkg.ci.yaml
index 67de34a2556e..528bd2cc41cc 100644
--- a/ShellPkg/ShellPkg.ci.yaml
+++ b/ShellPkg/ShellPkg.ci.yaml
@@ -5,6 +5,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     "CompilerPlugin": {
         "DscPath": "ShellPkg.dsc"
     },
-- 
2.18.0.windows.1

[PATCH v4 16/17] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
 UefiCpuPkg/UefiCpuPkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml b/UefiCpuPkg/UefiCpuPkg.ci.yaml
index 99e460a8b090..dc3ff362f7c2 100644
--- a/UefiCpuPkg/UefiCpuPkg.ci.yaml
+++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml
@@ -5,6 +5,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     "CompilerPlugin": {
         "DscPath": "UefiCpuPkg.dsc"
     },
-- 
2.18.0.windows.1

[PATCH v4 17/17] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file

[Zhang, Shenglei]

Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
index 51e172537f8a..7e9fc5d005fb 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
@@ -5,6 +5,16 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        "IgnoreFiles": [
+        ]
+    },
     ## options defined .pytool/Plugin/CompilerPlugin
     "CompilerPlugin": {
         "DscPath": "UnitTestFrameworkPkg.dsc"
-- 
2.18.0.windows.1

Re: [edk2-devel] [PATCH v4 15/17] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check

[Gao, Zhichao]

Acked-by: Zhichao gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang,
> Shenglei
> Sent: Monday, June 15, 2020 4:49 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [edk2-devel] [PATCH v4 15/17] ShellPkg/ShellPkg.ci.yaml: Add
> configuration for Ecc check
> 
> Add configuration ExceptionList and IgnoreFiles for package config files. So users
> can rely on this to ignore some Ecc issues.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  ShellPkg/ShellPkg.ci.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/ShellPkg/ShellPkg.ci.yaml b/ShellPkg/ShellPkg.ci.yaml index
> 67de34a2556e..528bd2cc41cc 100644
> --- a/ShellPkg/ShellPkg.ci.yaml
> +++ b/ShellPkg/ShellPkg.ci.yaml
> @@ -5,6 +5,16 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  ##  {
> +    "EccCheck": {
> +        ## Exception sample looks like below:
> +        ## "ExceptionList": [
> +        ##     "<ErrorID>", "<KeyWord>"
> +        ## ]
> +        "ExceptionList": [
> +        ],
> +        "IgnoreFiles": [
> +        ]
> +    },
>      "CompilerPlugin": {
>          "DscPath": "ShellPkg.dsc"
>      },
> --
> 2.18.0.windows.1
> 
> 
> 

Re: [edk2-devel] [PATCH v4 06/17] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check

[Guomin Jiang]

Good work.

Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang,
> Shenglei
> Sent: Monday, June 15, 2020 4:49 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> <xiaoyux.lu@intel.com>
> Subject: [edk2-devel] [PATCH v4 06/17] CryptoPkg/CryptoPkg.ci.yaml: Add
> configuration for Ecc check
> 
> Add configuration ExceptionList and IgnoreFiles for package config files. So
> users can rely on this to ignore some Ecc issues.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  CryptoPkg/CryptoPkg.ci.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
> index f54ebfb22e70..2c1a8a7f5072 100644
> --- a/CryptoPkg/CryptoPkg.ci.yaml
> +++ b/CryptoPkg/CryptoPkg.ci.yaml
> @@ -5,6 +5,16 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  ##  {
> +    "EccCheck": {
> +        ## Exception sample looks like below:
> +        ## "ExceptionList": [
> +        ##     "<ErrorID>", "<KeyWord>"
> +        ## ]
> +        "ExceptionList": [
> +        ],
> +        "IgnoreFiles": [
> +        ]
> +    },
>      "CompilerPlugin": {
>          "DscPath": "CryptoPkg.dsc"
>      },
> --
> 2.18.0.windows.1
> 
> 
> 

Re: [edk2-devel] [PATCH v4 09/17] FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check

[Guomin Jiang]

Good work.

Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang,
> Shenglei
> Sent: Monday, June 15, 2020 4:49 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [PATCH v4 09/17]
> FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check
> 
> Add configuration ExceptionList and IgnoreFiles for package config files. So
> users can rely on this to ignore some Ecc issues.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  FmpDevicePkg/FmpDevicePkg.ci.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/FmpDevicePkg/FmpDevicePkg.ci.yaml
> b/FmpDevicePkg/FmpDevicePkg.ci.yaml
> index 74a0aefe8e49..99ffa4aae8f2 100644
> --- a/FmpDevicePkg/FmpDevicePkg.ci.yaml
> +++ b/FmpDevicePkg/FmpDevicePkg.ci.yaml
> @@ -5,6 +5,16 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  ##  {
> +    "EccCheck": {
> +        ## Exception sample looks like below:
> +        ## "ExceptionList": [
> +        ##     "<ErrorID>", "<KeyWord>"
> +        ## ]
> +        "ExceptionList": [
> +        ],
> +        "IgnoreFiles": [
> +        ]
> +    },
>      "CompilerPlugin": {
>          "DscPath": "FmpDevicePkg.dsc"
>      },
> --
> 2.18.0.windows.1
> 
> 
> 

Re: [edk2-devel] [PATCH v4 08/17] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check

[Guomin Jiang]

Good work.

Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang,
> Shenglei
> Sent: Monday, June 15, 2020 4:49 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [PATCH v4 08/17] FatPkg/FatPkg.ci.yaml: Add
> configuration for Ecc check
> 
> Add configuration ExceptionList and IgnoreFiles for package config files. So
> users can rely on this to ignore some Ecc issues.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  FatPkg/FatPkg.ci.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg.ci.yaml index
> 8b0fb1d4fcd5..82069d3a7534 100644
> --- a/FatPkg/FatPkg.ci.yaml
> +++ b/FatPkg/FatPkg.ci.yaml
> @@ -5,6 +5,16 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  ##  {
> +    "EccCheck": {
> +        ## Exception sample looks like below:
> +        ## "ExceptionList": [
> +        ##     "<ErrorID>", "<KeyWord>"
> +        ## ]
> +        "ExceptionList": [
> +        ],
> +        "IgnoreFiles": [
> +        ]
> +    },
>      "CompilerPlugin": {
>          "DscPath": "FatPkg.dsc"
>      },
> --
> 2.18.0.windows.1
> 
> 
> 

Re: [edk2-devel] [PATCH v4 13/17] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check

[Guomin Jiang]

Good work.

Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang,
> Shenglei
> Sent: Monday, June 15, 2020 4:49 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [PATCH v4 13/17]
> PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check
> 
> Add configuration ExceptionList and IgnoreFiles for package config files. So
> users can rely on this to ignore some Ecc issues.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
> b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
> index be470807bd9e..5809ff8e3b1c 100644
> --- a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
> +++ b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
> @@ -5,6 +5,16 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  ##  {
> +    "EccCheck": {
> +        ## Exception sample looks like below:
> +        ## "ExceptionList": [
> +        ##     "<ErrorID>", "<KeyWord>"
> +        ## ]
> +        "ExceptionList": [
> +        ],
> +        "IgnoreFiles": [
> +        ]
> +    },
>      "CompilerPlugin": {
>          "DscPath": "PcAtChipsetPkg.dsc"
>      },
> --
> 2.18.0.windows.1
> 
> 
>