From: "Tomas Pilar (tpilar)" <Tomas.Pilar@arm.com>
To: <devel@edk2.groups.io>
Cc: <nd@arm.com>, Ray Ni <ray.ni@intel.com>,
Zhichao Gao <zhichao.gao@intel.com>
Subject: [PATCH v3 0/7] Standalone AcpiView Application
Date: Mon, 15 Jun 2020 15:03:44 +0100 [thread overview]
Message-ID: <20200615140351.1725-1-Tomas.Pilar@arm.com> (raw)
This patchset adds a new application module to the
ShellPkg with the functionality of the 'acpiview' command.
The existing code is tidied and a clean boundary between
the UEFI shell command wrapper and the acpiview functionality
is created. Then, a new application wrapper is added.
The motivation for a standalone AcpiView application lies
in the desire to test implementation of the Acpi tables on
a wide selection of platforms, particularly platforms still
in development, platforms that might have an older implementation
of the UEFI shell or platforms that might not include the 'acpiview'
command in the internal build of the UEFI shell. Furthermore,
this application can then be integrated in larger firmware
testing frameworks.
---
v3: Fix pointer dereference in GetSelectedTable. Create library
interface for the UefiShellAcpiViewCommandLib and convert to
named library. Tidy help text shell hook in standalone app.
v2: Patch formatting
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Tomas Pilar (7):
ShellPkg/AcpiView: Move log reset to main method
ShellPkg/AcpiView: Refactor configuration
ShellPkg/AcpiView: Move table count reset
ShellPkg/AcpiView: Move parameter parsing
ShellPkg/AcpiView: Refactor DumpAcpiTableToFile
ShellPkg: Add AcpiViewCommandLib
ShellPkg/AcpiView: Add application wrapper
.../Application/AcpiViewApp/AcpiViewApp.c | 40 ++
.../Application/AcpiViewApp/AcpiViewApp.inf | 34 ++
.../Application/AcpiViewApp/AcpiViewApp.uni | 122 +++++
ShellPkg/Include/Library/AcpiViewCommandLib.h | 46 ++
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 1 +
.../AcpiTableParser.c | 1 +
.../UefiShellAcpiViewCommandLib/AcpiView.c | 474 ++----------------
.../UefiShellAcpiViewCommandLib/AcpiView.h | 113 +----
.../AcpiViewConfig.c | 246 +++++++++
.../AcpiViewConfig.h | 177 +++++++
.../Parsers/Gtdt/GtdtParser.c | 1 +
.../Parsers/Iort/IortParser.c | 1 +
.../Parsers/Madt/MadtParser.c | 1 +
.../Parsers/Pptt/PpttParser.c | 1 +
.../Parsers/Srat/SratParser.c | 1 +
.../UefiShellAcpiViewCommandLib.c | 279 ++++++++++-
.../UefiShellAcpiViewCommandLib.h | 26 -
.../UefiShellAcpiViewCommandLib.inf | 33 +-
ShellPkg/ShellPkg.dec | 3 +
ShellPkg/ShellPkg.dsc | 4 +-
20 files changed, 1019 insertions(+), 585 deletions(-)
create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.c
create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.inf
create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.uni
create mode 100644 ShellPkg/Include/Library/AcpiViewCommandLib.h
create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.c
create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h
delete mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.h
--
2.24.1.windows.2
next reply other threads:[~2020-06-15 14:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 14:03 Tomas Pilar (tpilar) [this message]
2020-06-15 14:03 ` [PATCH v3 1/7] ShellPkg/AcpiView: Move log reset to main method Tomas Pilar (tpilar)
2020-06-15 14:03 ` [PATCH v3 2/7] ShellPkg/AcpiView: Refactor configuration Tomas Pilar (tpilar)
2020-06-23 1:23 ` Gao, Zhichao
2020-06-15 14:03 ` [PATCH v3 3/7] ShellPkg/AcpiView: Move table count reset Tomas Pilar (tpilar)
2020-06-15 14:03 ` [PATCH v3 4/7] ShellPkg/AcpiView: Move parameter parsing Tomas Pilar (tpilar)
2020-06-15 14:03 ` [PATCH v3 5/7] ShellPkg/AcpiView: Refactor DumpAcpiTableToFile Tomas Pilar (tpilar)
2020-06-23 1:25 ` Gao, Zhichao
2020-06-15 14:03 ` [PATCH v3 6/7] ShellPkg: Add AcpiViewCommandLib Tomas Pilar (tpilar)
2020-06-23 1:26 ` [edk2-devel] " Gao, Zhichao
2020-06-15 14:03 ` [PATCH v3 7/7] ShellPkg/AcpiView: Add application wrapper Tomas Pilar (tpilar)
2020-06-23 1:28 ` Gao, Zhichao
2020-06-22 12:23 ` [edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application Tomas Pilar (tpilar)
2020-06-23 1:32 ` Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615140351.1725-1-Tomas.Pilar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox