From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by mx.groups.io with SMTP id smtpd.web10.869.1592335776364786416 for ; Tue, 16 Jun 2020 12:29:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=y14rlq/Z; spf=pass (domain: linaro.org, ip: 209.85.215.193, mailfrom: tanmay.jagdale@linaro.org) Received: by mail-pg1-f193.google.com with SMTP id e9so808pgo.9 for ; Tue, 16 Jun 2020 12:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fFoea/+NRLL64gXiIWCmGsl5f3+iuO3wXuNUaNBExVQ=; b=y14rlq/Z8TlLw129Ilz9B53AvwQDvvWV5CWpZ/1l8vDfldn1YY+eTGeUkeSO0bFPmq EFwRGejc9UQXTw4H+lRkVeIUzHj3SXKlZbrAh8wDvERIWA/veUilq1CiICFTDjfbRMOV lfKGKqP7LaohWm8gDGY4nZGw3xlhcNL+v6CWI2AYXSNahg7zdvSC2wJUq7ydywHerOxR 5GqsTK83azhRsudy2K97Fqh0p1YDsCFui06wQ+aWZTvUV/IxSmeVxaMcQYKxCP3KfNcT oXXpGjszqilHjFqSNrbWBG/2NHV5OMZWbTfoHYruTvsOaPQ3yGT8c1AHHZv08vSHHuYJ 2ncg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fFoea/+NRLL64gXiIWCmGsl5f3+iuO3wXuNUaNBExVQ=; b=rlyBB8FyRe+AtrtwpY73ChHDvTCYEJ0mhudpzqnrtkRYOB4WVliCiPv8g7KieTV77q KQ7iaTBHToU14CF/Z+pUTrB2GavGS/m547wM/zpjSobIzz9+h04sGVQ+JFsl/HGLiEeW bRe0Mo8UFAGxtCRjvgKOyM0v4RLLr31FzVCZv2yYD7/WKFI5AMNDwQBxIn1pDk/QM+S5 dZ8B6rHBhBRGPw+TowBjw8DoPOBbSwVhzKnSQvW1KGTjLKAYf1/fEfvE0uAts60n9g+z p536LzXwz8QEdJKB2t7b8N78vL0LyVhuoDosVi4PiZUgGZZPGmGVqjJ167q0tagxB//k ElHA== X-Gm-Message-State: AOAM532h9VDTPSNSj7cVQuxOVq/vaWFVX1MHDan/SibAAkUIi5BG4K2D Ea3aFtxGbuEEll6VHplCeaHXRg== X-Google-Smtp-Source: ABdhPJyfDHGpApL0rUANmiKKgDwsHZ0H1pczoLP6ErGr5WiCSYx6/LzcaOpdUkm/Ez7FaSnbVn6/FA== X-Received: by 2002:a63:6dc2:: with SMTP id i185mr3185533pgc.250.1592335775816; Tue, 16 Jun 2020 12:29:35 -0700 (PDT) Return-Path: Received: from bean-canyon.localdomain ([106.200.227.148]) by smtp.googlemail.com with ESMTPSA id b29sm18226932pfr.159.2020.06.16.12.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 12:29:35 -0700 (PDT) From: "Tanmay Jagdale" To: leif@nuviainc.com, ard.biesheuvel@arm.com, graeme.gregory@linaro.org, devel@edk2.groups.io Cc: rad@semihalf.com, Tanmay Jagdale Subject: Silicon/SbsaQemu: Fix NOR flash RegionBaseAddress Date: Wed, 17 Jun 2020 00:59:13 +0530 Message-Id: <20200616192913.56882-1-tanmay.jagdale@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable The EFI_FIMRWARE_VOLUME_HEADER is present at an offset in the NOR flash of Sbsa QEMU model. Use the right RegionBaseAddress so that the EFI firmware volume header can be found correctly. Signed-off-by: Tanmay Jagdale --- .../SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib.c | 2 +- .../Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib.inf | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorF= lashLib.c b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFl= ashLib.c index e7bb626596..0946327cb5 100644 --- a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib= .c +++ b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib= .c @@ -23,7 +23,7 @@ NorFlashPlatformInitialization ( NOR_FLASH_DESCRIPTION mNorFlashDevice =3D=0D {=0D FixedPcdGet64(PcdFdBaseAddress),=0D - FixedPcdGet64(PcdFdBaseAddress),=0D + FixedPcdGet64(PcdFlashNvStorageVariableBase),=0D FixedPcdGet32(PcdFdSize),=0D QEMU_NOR_BLOCK_SIZE=0D };=0D diff --git a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorF= lashLib.inf b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNor= FlashLib.inf index 82712c8901..f2ba41e1df 100644 --- a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib= .inf +++ b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib= .inf @@ -23,7 +23,9 @@ ArmPlatformPkg/ArmPlatformPkg.dec=0D ArmPkg/ArmPkg.dec=0D MdePkg/MdePkg.dec=0D + MdeModulePkg/MdeModulePkg.dec=0D =0D [FixedPcd]=0D gArmTokenSpaceGuid.PcdFdBaseAddress=0D gArmTokenSpaceGuid.PcdFdSize=0D + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase=0D --=20 2.27.0