public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: devel@edk2.groups.io
Cc: Ray Ni <niruiyu@users.noreply.github.com>,
	Eric Dong <eric.dong@intel.com>, Amy Chan <amy.chan@intel.com>,
	Rangasai V Chaganty <rangasai.v.chaganty@intel.com>,
	Isaac W Oram <isaac.w.oram@intel.com>
Subject: [PATCH] Features/Intel/Readme.md: clarify feature package dependency rule
Date: Wed, 17 Jun 2020 17:03:25 +0800	[thread overview]
Message-ID: <20200617090326.1213-1-ray.ni@intel.com> (raw)

From: Ray Ni <niruiyu@users.noreply.github.com>

Original statement only says depending on another feature package
is not allowed. It gives developers impression that board level
packages are allowed to depend on.

This patch clarifies the package dependency rule.

Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Amy Chan <amy.chan@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Isaac W Oram <isaac.w.oram@intel.com>
---
 Features/Intel/Readme.md | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Features/Intel/Readme.md b/Features/Intel/Readme.md
index 9729f90a41..1a03a4c0d2 100644
--- a/Features/Intel/Readme.md
+++ b/Features/Intel/Readme.md
@@ -17,8 +17,10 @@ document as needed.
 ### Advanced Feature Attributes
 Advanced features should be:
 * _Cohesive_, the feature should not contain any functionality unrelated to the feature.
-* _Complete_, the feature must have a complete design that minimizes dependencies. A feature package cannot directly
-  depend on another feature package.
+* _Complete_, the feature must have a complete design that minimizes dependencies. A feature package can only depend
+  on following packages:
+  * edk2 repo: `MdePkg`, `MdeModulePkg`, `UefiCpuPkg`, `FmpDevicePkg`, `SecurityPkg`, `NetworkPkg`, `ShellPkg`.
+  * edk2-platforms repo: `MinPlatformPkg`, `IntelSiliconPkg`.
 * _Easy to Integrate_, the feature should expose well-defined software interfaces to use and configure the feature.
   * It should also present a set of simple and well-documented standard EDK II configuration options such as PCDs to
   configure the feature.
-- 
2.25.1


             reply	other threads:[~2020-06-17  9:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17  9:03 Ni, Ray [this message]
2020-06-18  0:31 ` [PATCH] Features/Intel/Readme.md: clarify feature package dependency rule Dong, Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617090326.1213-1-ray.ni@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox