From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.3399.1592384653638729055 for ; Wed, 17 Jun 2020 02:04:13 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) IronPort-SDR: oa5vh5+xD6mzr8kvwVLWZNN2dGp5l2MG5BZXaa7IXZQETqrnbaSqsiRdGeZ3VbbTFFaSkkW/QU yRR9tGeoTwug== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 02:04:13 -0700 IronPort-SDR: YcgwMFhIDzQIeTPE2x6NLDVah/EjfOtploYo43fpLdhzoLO1HHMPbTpAVYni/6TsurmbyEXns2 Wz+bnmlIylMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,522,1583222400"; d="scan'208";a="476759060" Received: from ray-dev.ccr.corp.intel.com ([10.239.158.87]) by fmsmga006.fm.intel.com with ESMTP; 17 Jun 2020 02:04:11 -0700 From: "Ni, Ray" To: devel@edk2.groups.io Cc: Ray Ni , Eric Dong , Amy Chan , Rangasai V Chaganty , Isaac W Oram Subject: [PATCH] Features/Intel/Readme.md: clarify feature package dependency rule Date: Wed, 17 Jun 2020 17:03:25 +0800 Message-Id: <20200617090326.1213-1-ray.ni@intel.com> X-Mailer: git-send-email 2.26.2.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Ray Ni Original statement only says depending on another feature package is not allowed. It gives developers impression that board level packages are allowed to depend on. This patch clarifies the package dependency rule. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Amy Chan Cc: Rangasai V Chaganty Cc: Isaac W Oram --- Features/Intel/Readme.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Features/Intel/Readme.md b/Features/Intel/Readme.md index 9729f90a41..1a03a4c0d2 100644 --- a/Features/Intel/Readme.md +++ b/Features/Intel/Readme.md @@ -17,8 +17,10 @@ document as needed. ### Advanced Feature Attributes=0D Advanced features should be:=0D * _Cohesive_, the feature should not contain any functionality unrelated t= o the feature.=0D -* _Complete_, the feature must have a complete design that minimizes depen= dencies. A feature package cannot directly=0D - depend on another feature package.=0D +* _Complete_, the feature must have a complete design that minimizes depen= dencies. A feature package can only depend=0D + on following packages:=0D + * edk2 repo: `MdePkg`, `MdeModulePkg`, `UefiCpuPkg`, `FmpDevicePkg`, `Se= curityPkg`, `NetworkPkg`, `ShellPkg`.=0D + * edk2-platforms repo: `MinPlatformPkg`, `IntelSiliconPkg`.=0D * _Easy to Integrate_, the feature should expose well-defined software int= erfaces to use and configure the feature.=0D * It should also present a set of simple and well-documented standard ED= K II configuration options such as PCDs to=0D configure the feature.=0D --=20 2.25.1