From: "Leif Lindholm" <leif@nuviainc.com>
To: Meenakshi Aggarwal <meenakshi.aggarwal@oss.nxp.com>
Cc: ard.biesheuvel@arm.com, michael.d.kinney@intel.com,
devel@edk2.groups.io, v.sethi@nxp.com
Subject: Re: [PATCH edk2-platforms V2 0/2] Add SATA driver support
Date: Wed, 17 Jun 2020 12:55:06 +0100 [thread overview]
Message-ID: <20200617115506.GK6739@vanye> (raw)
In-Reply-To: <1591713065-18258-1-git-send-email-meenakshi.aggarwal@oss.nxp.com>
On Tue, Jun 09, 2020 at 20:01:03 +0530, Meenakshi Aggarwal wrote:
> This patchset implement SATA driver for NXP Platforms enable
> SATA for LX2160A Platform.
>
> Changes in v2:
> - Incorporated review comments
> - Removed header file and define macro in .c file
For this set:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
*However*, this set does not apply cleanly without the "Add USB driver
support" set, and that set has an outstanding question from Ard in
https://edk2.groups.io/g/devel/message/61211.
I'll leave it up to you whether we get that set merged first, or
whether you can rebase this one.
/
Leif
> Meenakshi Aggarwal (2):
> Silicon/NXP: Add SATA controller initialization driver
> Platform/NXP:LX2160: Enable support of SATA controller
>
> Silicon/NXP/NxpQoriqLs.dec | 6 +
> Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 +
> Silicon/NXP/NxpQoriqLs.dsc.inc | 10 ++
> Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 2 +
> Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 18 ++-
> Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf | 45 +++++++
> Silicon/NXP/Drivers/SataInitDxe/SataInit.c | 124 ++++++++++++++++++++
> 7 files changed, 207 insertions(+), 3 deletions(-)
> create mode 100644 Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf
> create mode 100644 Silicon/NXP/Drivers/SataInitDxe/SataInit.c
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2020-06-17 11:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 16:02 [PATCH edk2-platforms 0/2] Add SATA driver support Meenakshi Aggarwal
2020-06-05 16:02 ` [PATCH edk2-platforms 1/2] Silicon/NXP: Add SATA controller initialization driver Meenakshi Aggarwal
2020-06-05 13:00 ` Ard Biesheuvel
2020-06-08 11:44 ` Meenakshi Aggarwal
2020-06-05 16:02 ` [PATCH edk2-platforms 2/2] Platform/NXP:LX2160: Enable support of SATA controller Meenakshi Aggarwal
2020-06-05 13:01 ` Ard Biesheuvel
2020-06-05 13:09 ` Leif Lindholm
2020-06-09 14:31 ` [PATCH edk2-platforms V2 0/2] Add SATA driver support Meenakshi Aggarwal
2020-06-09 14:31 ` [PATCH edk2-platforms V2 1/2] Silicon/NXP: Add SATA controller initialization driver Meenakshi Aggarwal
2020-06-09 14:31 ` [PATCH edk2-platforms V2 2/2] Platform/NXP:LX2160: Enable support of SATA controller Meenakshi Aggarwal
2020-06-17 11:55 ` Leif Lindholm [this message]
2020-06-23 19:08 ` [PATCH edk2-platforms V2 0/2] Add SATA driver support Meenakshi Aggarwal (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617115506.GK6739@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox