From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.5785.1592394910843293636 for ; Wed, 17 Jun 2020 04:55:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=MqmqT4/v; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id q11so2038381wrp.3 for ; Wed, 17 Jun 2020 04:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xZEcdzHRIkE/udgy0QsZqYhbpDHQic88Q+RyXzeBkb8=; b=MqmqT4/vFSI0mw6acZDsgEseq33F2D8B5PBbv0646DnJGxqWU8yOZKhoK74dcC57C6 XTUkDHi9WR+Iye1in8jI63kSN1CuZlbH5GpakvX+vhnNn50l6KCI0T8HYb8lHDZttq0a CCRxacjkGCXQ1k5ZcmhPJFMAX6FII/EUnBUOM74wtp0cuotY4vko2yL8lRylGbeYNF5a 1tXYft3wMXq5SEOFEP+QN2QxuOer9bsnfFSMDSg7cnPdBm3DmUCOHUJDPCylh+q4DJP0 e0ySGazBGYvfFbjgLFFQaY2ztZ/UbS77PTz2xrYzhqoLZK5ePSsBjtW7KWULGXKgAZui MfDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xZEcdzHRIkE/udgy0QsZqYhbpDHQic88Q+RyXzeBkb8=; b=M+WwzF+Lv58nk1dDtcsCb5mYIlGqSeVtoN1+jsV4pcH6ONey/RY4QnrSxBHiXl7z4a wAIEP7s3uqGbDgo8naDyqMV0uwWAjaNbe+KtrFX+Yf1Cw4XKB0nHuAC//1B3Inc3FcdJ SmBVepME3Ctw8EdAfc6dxkB2RDyGy9Yq+1aIWSsCCfx82GG4AQb5jTQbiovXiaGHdICC hBDLx2NCF4liuWwasm7bzvpH/79YCDXXqlhieJdMATUHmHjzPU7tXVr2L1ew+Kq65Z2L aZByiJvfnYmpSVJOWRBE87PB+7X8to4CHZFYUzUZdq6StSW/5J1PG1319vYwgKQ4Z3QR UwIw== X-Gm-Message-State: AOAM532kyiKYSgPWJMGP6241IaQ6J+fQDBIvyWcLsFNMq3RxkssPOR8F CBkP5dXYIqwOn5Vanci9QPgTxA== X-Google-Smtp-Source: ABdhPJwpZcniyGfUW5pKY5eTKf1fYwoj4+oryKc6ItSqjPkQWGHox6df3qtItCMDy5+pbw5loCay9g== X-Received: by 2002:adf:f207:: with SMTP id p7mr8186486wro.206.1592394909488; Wed, 17 Jun 2020 04:55:09 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id g19sm99771wmh.29.2020.06.17.04.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 04:55:08 -0700 (PDT) Date: Wed, 17 Jun 2020 12:55:06 +0100 From: "Leif Lindholm" To: Meenakshi Aggarwal Cc: ard.biesheuvel@arm.com, michael.d.kinney@intel.com, devel@edk2.groups.io, v.sethi@nxp.com Subject: Re: [PATCH edk2-platforms V2 0/2] Add SATA driver support Message-ID: <20200617115506.GK6739@vanye> References: <1591372974-7860-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> <1591713065-18258-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <1591713065-18258-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 09, 2020 at 20:01:03 +0530, Meenakshi Aggarwal wrote: > This patchset implement SATA driver for NXP Platforms enable > SATA for LX2160A Platform. > > Changes in v2: > - Incorporated review comments > - Removed header file and define macro in .c file For this set: Reviewed-by: Leif Lindholm *However*, this set does not apply cleanly without the "Add USB driver support" set, and that set has an outstanding question from Ard in https://edk2.groups.io/g/devel/message/61211. I'll leave it up to you whether we get that set merged first, or whether you can rebase this one. / Leif > Meenakshi Aggarwal (2): > Silicon/NXP: Add SATA controller initialization driver > Platform/NXP:LX2160: Enable support of SATA controller > > Silicon/NXP/NxpQoriqLs.dec | 6 + > Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 + > Silicon/NXP/NxpQoriqLs.dsc.inc | 10 ++ > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 2 + > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 18 ++- > Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf | 45 +++++++ > Silicon/NXP/Drivers/SataInitDxe/SataInit.c | 124 ++++++++++++++++++++ > 7 files changed, 207 insertions(+), 3 deletions(-) > create mode 100644 Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf > create mode 100644 Silicon/NXP/Drivers/SataInitDxe/SataInit.c > > -- > 1.9.1 >