Re: [edk2-devel] [PATCH edk2-platforms v3 3/4] Silicon/Hisilicon/Acpi: Add update sas address feature

["Leif Lindholm" <leif@nuviainc.com>]

On Wed, Jun 17, 2020 at 19:23:47 +0800, Ming Huang wrote:
> >>>> +  Status = gBS->LocateProtocol (&gHisiSasConfigProtocolGuid, NULL, (VOID **)&HisiSasConf);
> >>>> +  if (EFI_ERROR (Status)) {
> >>>> +    DEBUG ((DEBUG_ERROR, "Locate Sas Config Protocol failed %r\n", Status));
> >>>> +    SasAddrBuffer[0] = 0x50;
> >>>> +    SasAddrBuffer[1] = 0x01;
> >>>> +    SasAddrBuffer[2] = 0x88;
> >>>> +    SasAddrBuffer[3] = 0x20;
> >>>> +    SasAddrBuffer[4] = 0x16;
> >>>> +    SasAddrBuffer[5] = 0x00;
> >>>> +    SasAddrBuffer[6] = 0x00;
> >>>> +    SasAddrBuffer[7] = Index;
> >>>
> >>> This is still a sompletely random-looking value being stuffed into the
> >>> buffer. What is it?
> >>
> >> This is a random value. Maybe it is more appropriate to stuff zero into the
> >> buffer here.
> > 
> > I think so.
> > Would you be happy for me to fold that in before pushing?
> 
> Yes.
> Thanks.

Done.
For the remaining patches:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Series pushed as 5f13ce8a65f2..73efee74df87.

/
    Leif