From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68])
 by mx.groups.io with SMTP id smtpd.web11.6055.1592395681054498221
 for <devel@edk2.groups.io>;
 Wed, 17 Jun 2020 05:08:01 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=Z3RgtWy1;
 spf=pass (domain: nuviainc.com, ip: 209.85.221.68, mailfrom: leif@nuviainc.com)
Received: by mail-wr1-f68.google.com with SMTP id b6so2043451wrs.11
        for <devel@edk2.groups.io>; Wed, 17 Jun 2020 05:08:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=tZ+Rirj6WrRClE2nxEeJm94C45dOKQvtG6ICJtH1EFs=;
        b=Z3RgtWy10sJuNw1uXQVgrDN4pP5vC/5l6mGTjqXFUaWbaQTvEOoLnxpb2+TQV4URqx
         BQUmGggZV96vXGls4zCLvJip0q+1Lt23ytaQ6zoWUvfIM04v4zd5mreH52HwUzYbEw1h
         Vnhu9UZQGthYc57Sy2x7uMVkgApG85CZSEm+0Z0w361xchUBQcL9hcXdKr3JsbBWu65x
         1/7zhDDZC6hUAFv2DKoSkCMiGm8jIdmXj240QqMCMFlhlGGsVm74PdVmgOuEaleW1HIA
         SPSELoChqdVqqfSPtcI9jHHh2o8C7WMd/mOo6j66yCAi9p9uF9UEbwPx2XQH48zcp2Zz
         H0vg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=tZ+Rirj6WrRClE2nxEeJm94C45dOKQvtG6ICJtH1EFs=;
        b=kKQsfJs370utaXazaE8Ui07ZnAUqriaUITrBTHcwnnpgkvrqPstIG1W1Y85FZT9RUh
         +REEtk/W0A3rHnC0jQZYXG+bgH5Wlf2w8zpRZDXsRlUYmiqaNpOdDFtOCJs1CW7cXeQb
         i9BKOvRzv5X8JXfPbhwf5BOUJKMtaUL2qYuwLrLgNkYtD4Ct3OoJQxhqB64eSwsFJzFQ
         6QRenB9fRrWI7nXhisipGJfNbyc32W8Dq2egrgNCwFf1Dt1TwB3fCo1kBQUHmwrxGyi2
         vSSBXKKfiH9WQJZPrR4q7LUTzIwJo5Fpu+QXuDmNj2Rs2kdM2MjpIqYxndkyZFSHv7Fy
         i+oQ==
X-Gm-Message-State: AOAM530QnZGu/oOIr0iBq6diUk4yQcRSyGchRJ7ynCGM5yIhlI2WrIiN
	0fik+xNPWfR4sSpA5K1t16ywhOcLPY9S3pCKZNvhE9Ba/fmYJ2xe98t/WC9hL758fyFQlEC5LBK
	MUtmRuaGSK8LdMnkvQ6/6eRjDsZcaaqBbj2Ba/V8Z6j9aQ9GLmQnv3Cr+TNjMPkI=
X-Google-Smtp-Source: ABdhPJzBZEwipRZBhRBcseExgnIpEhYjRtqHewo6pS4PQ2YmjvV48Ag1Bckw/30sZ2SFrz+BPdulQA==
X-Received: by 2002:a5d:6581:: with SMTP id q1mr7932252wru.43.1592395679288;
        Wed, 17 Jun 2020 05:07:59 -0700 (PDT)
Return-Path: <leif@nuviainc.com>
Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8])
        by smtp.gmail.com with ESMTPSA id h29sm36077582wrc.78.2020.06.17.05.07.58
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Wed, 17 Jun 2020 05:07:58 -0700 (PDT)
Date: Wed, 17 Jun 2020 13:07:56 +0100
From: "Leif Lindholm" <leif@nuviainc.com>
To: devel@edk2.groups.io, huangming23@huawei.com
Cc: ard.biesheuvel@linaro.org, lidongzhan@huawei.com,
	songdongkuang@huawei.com, wanghuiqiang@huawei.com,
	qiuliangen@huawei.com, shenlimei@huawei.com, xiewenyi2@huawei.com
Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 3/4] Silicon/Hisilicon/Acpi: Add update sas address feature
Message-ID: <20200617120756.GL6739@vanye>
References: <1591709245-44527-1-git-send-email-huangming23@huawei.com>
 <1591709245-44527-4-git-send-email-huangming23@huawei.com>
 <20200616142006.GE6739@vanye>
 <9564872f-ba0f-22c3-fb4f-d05db39802a3@huawei.com>
 <20200617110703.GI6739@vanye>
 <b5bd2aaf-cfbb-c999-98da-1bf7ac32bd5c@huawei.com>
MIME-Version: 1.0
In-Reply-To: <b5bd2aaf-cfbb-c999-98da-1bf7ac32bd5c@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 17, 2020 at 19:23:47 +0800, Ming Huang wrote:
> >>>> +  Status = gBS->LocateProtocol (&gHisiSasConfigProtocolGuid, NULL, (VOID **)&HisiSasConf);
> >>>> +  if (EFI_ERROR (Status)) {
> >>>> +    DEBUG ((DEBUG_ERROR, "Locate Sas Config Protocol failed %r\n", Status));
> >>>> +    SasAddrBuffer[0] = 0x50;
> >>>> +    SasAddrBuffer[1] = 0x01;
> >>>> +    SasAddrBuffer[2] = 0x88;
> >>>> +    SasAddrBuffer[3] = 0x20;
> >>>> +    SasAddrBuffer[4] = 0x16;
> >>>> +    SasAddrBuffer[5] = 0x00;
> >>>> +    SasAddrBuffer[6] = 0x00;
> >>>> +    SasAddrBuffer[7] = Index;
> >>>
> >>> This is still a sompletely random-looking value being stuffed into the
> >>> buffer. What is it?
> >>
> >> This is a random value. Maybe it is more appropriate to stuff zero into the
> >> buffer here.
> > 
> > I think so.
> > Would you be happy for me to fold that in before pushing?
> 
> Yes.
> Thanks.

Done.
For the remaining patches:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Series pushed as 5f13ce8a65f2..73efee74df87.

/
    Leif