From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67])
 by mx.groups.io with SMTP id smtpd.web12.6161.1592396205639716433
 for <devel@edk2.groups.io>;
 Wed, 17 Jun 2020 05:16:45 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=U8mV5pr7;
 spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com)
Received: by mail-wm1-f67.google.com with SMTP id g10so1644380wmh.4
        for <devel@edk2.groups.io>; Wed, 17 Jun 2020 05:16:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=wWrsQZ9/wby3Y71iu/iND+RctyPuZpKpetCnin/1Fts=;
        b=U8mV5pr78zO91AC69ChiifLiu1296E9ld/32687izEUsrznA0015UX8zqpeUWfXWkF
         +vPj6a+gaWYGoeaY77I24pu8D31Rhc42Wd7kJENYYpNHdVfbHGZ3yxEtVS80d372hrYm
         CHvIuSItM2kBo2t5at9e+Dfm8SRy3Uzp4Duq5XvQ8mYAl3E9tWcivEH+jFAL73JYXl46
         87pc02z/oO6na2mwMMYrF9IJjGiMnZHABSU2+2ERC2bTkKu06zjaG2qR7PJEml2fKXU3
         uvczOlnCv4nKp3srmHq1bABkSdDNAl6qrbELsdjXYHNeZIuQg+p6n9iIcTVa10ZaG8uN
         QYZw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=wWrsQZ9/wby3Y71iu/iND+RctyPuZpKpetCnin/1Fts=;
        b=OBOn/smfxwXC1LLocOD0U+9FEUdm9ZrJg9RBMaMAuP9m0S1YuGxmE/0S0ck53sIhaY
         vrzIIUxiEBQKgoaaBVPNszfCrG0e4aNVB6sgVgNZUwx2cb6/bMtCwO7srtpTECJv5s1M
         1WrnS84tVgqffCHZLNtM9m52KtwlxfRBRQtdv9/hztl69gEp1PJLJeM9xbF13rk4fr8j
         R9/ckW+DavVTJhKRWzrQ/dy1svd1R+ZaItCXPF+Xh6SbW1ijE5X6eMxkhOtk2ZK3ZvOa
         UeUkVlRlrpwdm7sMaRUiI5nFLhzUNjzEUo6ncs7jNPTYHCGvRG3DIEljLd4Mpq+w80hU
         DxRg==
X-Gm-Message-State: AOAM5336Di0yXKQ2QYxV3KON8r1LXeGzZThwIye69Im5rcGTFJcJSTNO
	7pqGXTOFBq1LMJaQ3WVEs/iRHg==
X-Google-Smtp-Source: ABdhPJydxchLzMWQh1sd2VKU3oCGA1CcV4gy5VhSHE/DyQX3qDeO1eF/R0sx8+m10VFlurepi6hnAQ==
X-Received: by 2002:a1c:230f:: with SMTP id j15mr8625711wmj.100.1592396204282;
        Wed, 17 Jun 2020 05:16:44 -0700 (PDT)
Return-Path: <leif@nuviainc.com>
Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8])
        by smtp.gmail.com with ESMTPSA id o9sm4712422wrs.1.2020.06.17.05.16.43
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Wed, 17 Jun 2020 05:16:43 -0700 (PDT)
Date: Wed, 17 Jun 2020 13:16:41 +0100
From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io, Pete Batard <pete@akeo.ie>,
	Andrei Warkentin <awarkentin@vmware.com>,
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [PATCH] ArmPkg/PlatformBootManagerLib: regenerate boot options on boot failure
Message-ID: <20200617121641.GM6739@vanye>
References: <20200616174834.1110310-1-ard.biesheuvel@arm.com>
 <20200617111235.GJ6739@vanye>
 <6a089a72-00cb-f8ce-16d7-50cefed9b47d@arm.com>
MIME-Version: 1.0
In-Reply-To: <6a089a72-00cb-f8ce-16d7-50cefed9b47d@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 17, 2020 at 13:32:36 +0200, Ard Biesheuvel wrote:
> On 6/17/20 1:12 PM, Leif Lindholm wrote:
> > On Tue, Jun 16, 2020 at 19:48:34 +0200, Ard Biesheuvel wrote:
> > > One of the side effects of the recent changes to PlatformBootManagerLib
> > > changes to avoid connecting all devices on every boot is that we no
> > > longer default to network boot on a virgin boot, but end up in the
> > > UiApp menu. At this point, the autogenerated boot options that we used
> > > to rely on will be instantiated too,
> > 
> > The passive voice is confusing me a bit here - who does the updating,
> > and when specifically?
> > 
> 
> Originally, the ArmPkg PlatformBmLib would always refresh all boot options,
> but now, only the UiApp does that upon entry, at which point your sitting in
> the menu idly, and so automated network boot no longer works.

Sure. But the message should contain some description of agency.

Something like:
"On entry, the UiApp instantiates the autogenerated boot options that
we used to rely on - but it does not consume them. This breaks the
unattended..."

I assume the UiApp only ever *adds* entries, which is why checking
number of entries is sufficient?

With that/if so:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

/
    Leif