From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.6565.1592397631005719351 for ; Wed, 17 Jun 2020 05:40:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=PLFaIknj; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id d128so1835503wmc.1 for ; Wed, 17 Jun 2020 05:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZgZ/tIy0pCYPQyY3dEEFAl8o4a/8X9rXPGNQVZzTvAc=; b=PLFaIknjNQTHADqq//J5GAE0fMkRrplg5ur+MXtaFiM6vXdjr10Y8bNDQktpCx4ms4 rzQ8SD/UWmvQPgMsRM86BRwCTY1DyB9IRbg8nOu/PXcmszn5Rz+StDrivb/UwoVK2dJm tfoVs+qm5GGCdY772aQfX4naWSfJvdE6SgaiklEYTQeLY7zyQfG2iy74hbpcz8hprFrG MFAQGSZnXM8pu4Iu7DHIIAbfb3Fqprky58/khvIzkjYzjPcBUg830JopJSt8Y80A+c/G 72wquh+ssW7tIqxM88zOak7L0wTEZrapjI5Lx/Y/NeNL+FddpJBZ+Xsi8zhrf0zLM/yH nKvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZgZ/tIy0pCYPQyY3dEEFAl8o4a/8X9rXPGNQVZzTvAc=; b=ME9BLaRnQNujNFoV//slKLpHgpA7RRSBo9iJA2QPuk1kOL+GcQqS+ro+xvAJ5xEExr eGAItS7ritY7e9wUtDuV6b32CtF7T0sLxWJHMRiTiMKO/ZCcpI9ilJ3JgQ2GRjM3FkvT JRtVPGALHjzOi2MsZsgrQypqPnYye133TRvkRAwU+4533NMPTfO40P3ZSl5SpuXc0KMV YB3v7mp4IAdsyb53IfkASuBOOImv14h63Hhn2HFBfnfhuBog/ZfETOcPeUKfYSKnBOxb 9JRAEXbzarCgBX9NBKu7IajfWT+e2XIE+YUha2oq8BUTSz6e1BCYmisSUeXNwLINKZXC bWTw== X-Gm-Message-State: AOAM530sg/dVc1dNxPOZ5EnszC5T3LYHf6ewJG2LuVgmAOgAW5RNLQC5 lXWP318lRsJdeosEruCErHvAXA== X-Google-Smtp-Source: ABdhPJyX1sng5AICASxfG0tBdj9pTst1jHG1wngN411NgKm68fJn6XoPP0mE9sDjRQ/PCKEWGaj4aw== X-Received: by 2002:a1c:4887:: with SMTP id v129mr7956322wma.184.1592397629526; Wed, 17 Jun 2020 05:40:29 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id n19sm243186wmi.33.2020.06.17.05.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 05:40:28 -0700 (PDT) Date: Wed, 17 Jun 2020 13:40:26 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Pete Batard , Andrei Warkentin , Samer El-Haj-Mahmoud Subject: Re: [PATCH] ArmPkg/PlatformBootManagerLib: regenerate boot options on boot failure Message-ID: <20200617124026.GO6739@vanye> References: <20200616174834.1110310-1-ard.biesheuvel@arm.com> <20200617111235.GJ6739@vanye> <6a089a72-00cb-f8ce-16d7-50cefed9b47d@arm.com> <20200617121641.GM6739@vanye> <4bb1b99c-fa5a-ea9d-d786-32b16bb1604c@arm.com> MIME-Version: 1.0 In-Reply-To: <4bb1b99c-fa5a-ea9d-d786-32b16bb1604c@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 17, 2020 at 14:28:04 +0200, Ard Biesheuvel wrote: > On 6/17/20 2:16 PM, Leif Lindholm wrote: > > On Wed, Jun 17, 2020 at 13:32:36 +0200, Ard Biesheuvel wrote: > > > On 6/17/20 1:12 PM, Leif Lindholm wrote: > > > > On Tue, Jun 16, 2020 at 19:48:34 +0200, Ard Biesheuvel wrote: > > > > > One of the side effects of the recent changes to PlatformBootManagerLib > > > > > changes to avoid connecting all devices on every boot is that we no > > > > > longer default to network boot on a virgin boot, but end up in the > > > > > UiApp menu. At this point, the autogenerated boot options that we used > > > > > to rely on will be instantiated too, > > > > > > > > The passive voice is confusing me a bit here - who does the updating, > > > > and when specifically? > > > > > > > > > > Originally, the ArmPkg PlatformBmLib would always refresh all boot options, > > > but now, only the UiApp does that upon entry, at which point your sitting in > > > the menu idly, and so automated network boot no longer works. > > > > Sure. But the message should contain some description of agency. > > > > Something like: > > "On entry, the UiApp instantiates the autogenerated boot options that > > we used to rely on - but it does not consume them. This breaks the > > unattended..." > > OK > > > I assume the UiApp only ever *adds* entries, which is why checking > > number of entries is sufficient? > > > > It only manages entries that it instantiated itself, but it may also remove > entries if the underlying hardware has disappeared. Hmm, that's a bit trickier then. I mean, it's unlikely, but I'm sure there's situations that could happen. Would we run the risk of getting bug reports like "system fails to boot from Ethernet when inifiniband switch powered off"? Or if some virtual devices presented by a BMC appear/disappear? / Leif