From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web10.9465.1592405652595940623 for ; Wed, 17 Jun 2020 07:54:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=wImLosjY; spf=pass (domain: nuviainc.com, ip: 209.85.221.65, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f65.google.com with SMTP id l11so2689462wru.0 for ; Wed, 17 Jun 2020 07:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Eo8ePLuIlION03rujocCNsilEgsxgxNIOa+wOmAEOjI=; b=wImLosjY1GkiXu4enkhrof1Qf6FAANhdiXE2hz627qaFtr+DNDSYpRLdXq1T9kSkWh KOlHNhsGTFa8ndUFAtLfxBRqrS/a6JRUAiz36RE3QrxsSfwzeMVsl89oV2vZz3rmrkpD qZpeFwG8pCtp4gvRrqwLTjNR8ME+aJMHV3WP0oYqJUN9Apo65Id6PwnkqfGXmexSVlGT KWgSCT7s+Tutqh8EpgB/+GcXOi7lER+vTqsCQVeRw3GNvQkU8EoETlgFXaKF0Vnta6F2 e7WfZJqhmH2BEGBVT+6C+Rr6NxvTihcn9XzZR0kOpa3b07O1/NWsFNe74SwqW9EURmWi sVEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Eo8ePLuIlION03rujocCNsilEgsxgxNIOa+wOmAEOjI=; b=lrxIm/IgBvzyFFcOcx4n1FT9Lw8nbNh26Gtz/vHOdUJw1QUkKf/UE6e5ab/cUKB8HN MraP7dv8GLNduNwC993b0zHsDKt4cCl5Ppt/uRBrjshTfLm3AuAI6kCW2umkTUiPze+9 OLBgAQMWKNhU8nDlNfupg7uEM/hyPfGM4HQCUT82L5yrHf8wOJabCOqOqzy0W23S40+q TbQoTHaV50Rfa1wPoLsECmJkFLJHgrhxTN+c3Ihep2hhQ4fUdUrI3ExCxgM3C5IBIcK0 7voDOhEhrful8Et+Z6Pm0ZSIy9evWxnFRV8nAlXQfkakBEgx4vKVMmB54JJhqP6ra8MN BJAg== X-Gm-Message-State: AOAM532+6jCzMUFy+6dzSVJm5H6rQ0I5jinP/TliTtzCr24f+kaKPUCl nyBrzq8RTmhsVwEYWF42/H8vVw== X-Google-Smtp-Source: ABdhPJxDXHSjoO5RFVDy9j8NT0KIiogFPxoV0o5D67mKNpfo1ZDAqJ3EYieCE5eYUMeOOINfDMiLkQ== X-Received: by 2002:a5d:428e:: with SMTP id k14mr8878936wrq.21.1592405651234; Wed, 17 Jun 2020 07:54:11 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id y19sm25262wmi.6.2020.06.17.07.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 07:54:10 -0700 (PDT) Date: Wed, 17 Jun 2020 15:54:08 +0100 From: "Leif Lindholm" To: Wasim Khan Cc: devel@edk2.groups.io, meenakshi.aggarwal@nxp.com, V.Sethi@nxp.com, ard.biesheuvel@arm.com, Wasim Khan Subject: Re: [PATCH edk2-platforms 2/8] Silicon/NXP: Chassis2: define SVR macros Message-ID: <20200617145408.GQ6739@vanye> References: <1591737659-8051-1-git-send-email-wasim.khan@oss.nxp.com> <1591737659-8051-3-git-send-email-wasim.khan@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <1591737659-8051-3-git-send-email-wasim.khan@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 10, 2020 at 02:50:53 +0530, Wasim Khan wrote: > From: Wasim Khan > > Define macros to retrieve System Version Register(SVR) > related information > > Signed-off-by: Wasim Khan > --- > Silicon/NXP/Chassis2/Include/Chassis.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Silicon/NXP/Chassis2/Include/Chassis.h b/Silicon/NXP/Chassis2/Include/Chassis.h > index e5edd80134a4..7e8bf224884b 100644 > --- a/Silicon/NXP/Chassis2/Include/Chassis.h > +++ b/Silicon/NXP/Chassis2/Include/Chassis.h > @@ -12,6 +12,10 @@ > > #define NXP_LAYERSCAPE_CHASSIS2_DCFG_ADDRESS 0x1EE0000 > > +#define SVR_SOC_VER(svr) (((svr) >> 8) & 0xFFFFFE) > +#define SVR_MAJOR(svr) (((svr) >> 4) & 0xf) > +#define SVR_MINOR(svr) (((svr) >> 0) & 0xf) > + > /* SMMU Defintions */ > #define SMMU_BASE_ADDR 0x09000000 > #define SMMU_REG_SCR0 (SMMU_BASE_ADDR + 0x0) These macros are identical between Chassis2 and Chassis3V2, and they also look like exactly the sort of thing you want identical across different chassis. Is there a common header file they can use? (The set is straightforward, I have no other comments on it.) / Leif > -- > 2.7.4 >