From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.502.1592453814501503397 for ; Wed, 17 Jun 2020 21:16:54 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: samer.el-haj-mahmoud@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B3A031B; Wed, 17 Jun 2020 21:16:53 -0700 (PDT) Received: from localhost.localdomain (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E94423F71F; Wed, 17 Jun 2020 21:16:52 -0700 (PDT) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Andrei Warkentin , Pete Batard Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix SMBIOS Type 9 Date: Thu, 18 Jun 2020 00:16:48 -0400 Message-Id: <20200618041648.15692-1-Samer.El-Haj-Mahmoud@arm.com> X-Mailer: git-send-email 2.17.1 FWTS reports an error with SMBIOS Type 9 Segment-Bus-DevFunc fields. The SMBIOS specification requires that for non-PCIe slot devices to have these fields reported as 0xFFFFF-0xFF-xFF. Instead, they were being reported as 0x0000-0x00-0x00. This fixes the FWTS SMBIOS Type 9 failure reported here: https://github.com/pftf/RPi4/issues/75 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Andrei Warkentin Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c index 7b86e76a1248..78bdda18eb2d 100644 --- a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c +++ b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c @@ -380,9 +380,9 @@ SMBIOS_TABLE_TYPE9 mSysSlotInfoType9 = { 0, // SmbusSignalSupported :1; 0, // Reserved :5; ///< Set to 0. }, - 0, // SegmentGroupNum; - 0, // BusNum; - 0, // DevFuncNum; + 0xFFFF, // SegmentGroupNum; + 0xFF, // BusNum; + 0xFF, // DevFuncNum; }; CHAR8 *mSysSlotInfoType9Strings[] = { "SD Card", -- 2.17.1