From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66])
 by mx.groups.io with SMTP id smtpd.web12.9968.1592493611406068406
 for <devel@edk2.groups.io>;
 Thu, 18 Jun 2020 08:20:11 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=Rkzwpd/f;
 spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com)
Received: by mail-wr1-f66.google.com with SMTP id q11so6493181wrp.3
        for <devel@edk2.groups.io>; Thu, 18 Jun 2020 08:20:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=F/2MH4zB8XBKZ8rTSe0iQMtqZnseAyyXZIl1vsCrTPQ=;
        b=Rkzwpd/fF2QpCMUyk1yX+KqcsjprJcMLerjP6m9t/5hLxbQSsUgJeRT9tVM8sch7WR
         XZ6O22MqgDZ/GXeqqu0jMct85nyggnJnzOQ3cB0oFfuUbHuBK3Hv7keyw/fPKNXTf4LO
         hQx1j1FKNxlp6iRRVCyy3UPRLerDXoLB+bSSSlN8WCywOe34Nbsy8IBjjjxw0cNfApCO
         k4D9cjGhATavxc4HN1Y6O5e3TtHn4T5LYl6rAdMsXa8+Ut5sqTwrhrQbey6rvGaO5one
         padIL06/ShYR0GR8SO9e9jkpxNaBb22rSq0RBBGbfxta8dDgcX6kDWKHFg1pmzX7i8JK
         TL0w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=F/2MH4zB8XBKZ8rTSe0iQMtqZnseAyyXZIl1vsCrTPQ=;
        b=SwtBhdLK3J04Z81X60vlqIXHnWw63bkDZdOWso2kA+Vnig47R63lgW4W2uOGkCQ1Z9
         cKiqmTELIBCIvtYpa28AwwagS185uOu1lm/TuiwpcMDCA+gydeujctBnauZZaCdWovin
         QxZU/Pc2vH02SNCZui0+yHXvd6Gy+aSYYbgWXvvQyL1Lp0dx3vmgjcz7Pscbhsz2kk43
         x9JXsJ/MwOAVIeY+vNUmTvJoCceDI+QGKBYG9Z8In/aUqX6O+lBSUqeQg1xeir2ctEGW
         4mGgLc3bvMHBPi7S3pBKJotjvBOfCYBuJbet2MKGMP4m9BQGl+ZnbV2Umxbt1rh+/tee
         Ad2A==
X-Gm-Message-State: AOAM533umzs8z/tY/F25Tjo0d6pU2ayhurXiJrjFsaRg132xlO/Qi9pt
	LK3iIkMvYID1X9hhzs0gFW74Bg==
X-Google-Smtp-Source: ABdhPJzCyqkcDic0RESKnauyzGhjRiVGkU8gAX41pV7QIQJnUkBzhNx38b5VJ6H6cF5CAAijJt4Kyg==
X-Received: by 2002:a5d:5303:: with SMTP id e3mr5029519wrv.321.1592493610026;
        Thu, 18 Jun 2020 08:20:10 -0700 (PDT)
Return-Path: <leif@nuviainc.com>
Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8])
        by smtp.gmail.com with ESMTPSA id e8sm2182363wrv.24.2020.06.18.08.20.09
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 18 Jun 2020 08:20:09 -0700 (PDT)
Date: Thu, 18 Jun 2020 16:20:07 +0100
From: "Leif Lindholm" <leif@nuviainc.com>
To: Wasim Khan <wasim.khan@oss.nxp.com>
Cc: devel@edk2.groups.io, meenakshi.aggarwal@nxp.com, V.Sethi@nxp.com,
	ard.biesheuvel@arm.com, Wasim Khan <wasim.khan@nxp.com>
Subject: Re: [PATCH edk2-platforms 6/7] Platform/NXP: LX2160aRdbPkg: Enable NetworkPkg
Message-ID: <20200618152007.GY6739@vanye>
References: <1591741050-11645-1-git-send-email-wasim.khan@oss.nxp.com>
 <1591741050-11645-7-git-send-email-wasim.khan@oss.nxp.com>
MIME-Version: 1.0
In-Reply-To: <1591741050-11645-7-git-send-email-wasim.khan@oss.nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 10, 2020 at 03:47:29 +0530, Wasim Khan wrote:
> From: Wasim Khan <wasim.khan@nxp.com>
> 
> Enable NetworkPkg for LX2160aRdbPkg Platform.

This is done as part of a pacthset called "enable PCIe support
for...".
Again, I understand why you're doing this, but it is far from obvious.
Please add a note to the commit message explaining *why*.
(Also, this deserves explicit pointing out in cover letter.)

> Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
> ---
>  Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 11 +++++++++++
>  Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf |  5 +++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> index d0ec7b5a8906..c73f9fd4d393 100644
> --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> @@ -22,6 +22,13 @@ [Defines]
>    OUTPUT_DIRECTORY               = Build/LX2160aRdbPkg
>    FLASH_DEFINITION               = Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
>  
> +  #
> +  # Network definition
> +  #
> +  DEFINE NETWORK_TLS_ENABLE             = FALSE
> +  DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
> +  DEFINE NETWORK_ISCSI_ENABLE           = FALSE
> +
>  !include Silicon/NXP/NxpQoriqLs.dsc.inc
>  !include Silicon/NXP/LX2160A/LX2160A.dsc.inc
>  
> @@ -45,4 +52,8 @@ [Components.common]
>  
>    Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf
>  
> +  #
> +  # Networking stack
> +  #
> +!include NetworkPkg/Network.dsc.inc
>   ##
> diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> index 41b8f1ececa4..4c9cab5d0938 100644
> --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> @@ -116,6 +116,11 @@ [FV.FvMain]
>    INF ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf
>  
>    #
> +  # Networking stack
> +  #
> +!include NetworkPkg/Network.fdf.inc
> +
> +  #
>    # FAT filesystem + GPT/MBR partitioning
>    #
>    INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> -- 
> 2.7.4
>