From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.50]) by mx.groups.io with SMTP id smtpd.web11.17266.1592831922292673781 for ; Mon, 22 Jun 2020 06:18:42 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=pdUNmszW; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.244.50, mailfrom: garrett.kirkendall@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R3B3HxLYHZY5WhNKEN7y9psFYqtWLHf8z++p2aYBh0fm61Cai0NccuqR6zwEn5k33mivxTrn7W1lC7BIU1zxXVX/LvNlPxJFIelK+riDFVG1jDQeI4wodYcePfeNwgFMoKvPCPZ+N2mLp5Pxch9s4FcXMdG4apKtH8h3gbpD5QpTpVZSRbCuBVEBbuBhzC97FmS/VD2gVHWA/1IgwMJp7Fr5i6PLw5brYfAF79aBgF6w2xEwtt5zvM9X/cspbmuDwkKKZF2AoiQVYpsPcFmqRk0fSkqiBYTv5S5GOH6t0/INg6YmwJey7EZTSp4XgKQECDilz3vyDQfKuPk54LQ/Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aeRBr//RxXcZqPIJNrBxzXfMjVFMLBEGR/y5Huu2ci8=; b=fKJLSPH2v1a+UsHEz1I0E4tB/f5x58mCZhFrzVMIxzVAU7tyYUPD4BPQy2umpiaRxZ2wAy7ZPXFtsyE2AMuJFGP/xIQdS62j0Io8pg7df/K/udJjzeeHWZz1VFqf7DHYXyKPgYpOQqSUmy4jGaV4azyxhitk2AQy0yb8ySiu3h1YD5jsd8Fquf8O8D2gxD3sKri1rJKZrPsTDcPuHlTwAriV5+IgIPmsI1QVhoJrZpPRvyy403nyOf4zJVW7Y1M5RkB0YzbAfP2YH/IGIWNEicfirCWdeimeRmbhWISE91AthO0JXD9aTgogVQg0BVk4ACd0FDle2b6NcZhi8ET8hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aeRBr//RxXcZqPIJNrBxzXfMjVFMLBEGR/y5Huu2ci8=; b=pdUNmszWP+p5F/qT7B58rK0oWzW9AubPyx9KraVL6d6E8cd2Dm/2Y+JAdxxQTxeNxOlOpTwSHXpCWT9tLn9Q+tUz5MZx9Y0Dqa6o12fW4HiVSAkoqLLjFzz4tZyv49QG/t5OsvwlRkwJZYZRxu3L0srl2opTD4xuCiKuY17U2KE= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; Received: from SN1PR12MB2352.namprd12.prod.outlook.com (2603:10b6:802:25::13) by SA0PR12MB4461.namprd12.prod.outlook.com (2603:10b6:806:9c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Mon, 22 Jun 2020 13:18:41 +0000 Received: from SN1PR12MB2352.namprd12.prod.outlook.com ([fe80::156e:ce6d:a148:274e]) by SN1PR12MB2352.namprd12.prod.outlook.com ([fe80::156e:ce6d:a148:274e%7]) with mapi id 15.20.3109.027; Mon, 22 Jun 2020 13:18:40 +0000 From: "Kirkendall, Garrett" To: devel@edk2.groups.io CC: Eric Dong , Ray Ni , Laszlo Ersek , Hao A Wu Subject: [PATCH v6 0/4] AMD processor MSR_IA32_MISC_ENABLE Date: Mon, 22 Jun 2020 08:18:21 -0500 Message-ID: <20200622131825.1352-1-Garrett.Kirkendall@amd.com> X-Mailer: git-send-email 2.27.0 X-ClientProxiedBy: SN4PR0501CA0135.namprd05.prod.outlook.com (2603:10b6:803:2c::13) To SN1PR12MB2352.namprd12.prod.outlook.com (2603:10b6:802:25::13) Return-Path: Garrett.Kirkendall@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from biosdev-01.amd.com (165.204.78.2) by SN4PR0501CA0135.namprd05.prod.outlook.com (2603:10b6:803:2c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.13 via Frontend Transport; Mon, 22 Jun 2020 13:18:39 +0000 X-Mailer: git-send-email 2.27.0 X-Originating-IP: [165.204.78.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8968f90e-c2c9-4c6d-b210-08d816aec75e X-MS-TrafficTypeDiagnostic: SA0PR12MB4461: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 0442E569BC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lU3WPR+rldVrR47jNJ3bps2WDcI0THHiQI7v77sSqIuSm/98SBbU1VzZ/gbMjayPHQkfu6sXzaTpLbNGYKLv9op4MgYpxciTVKXi4a2vEP9oYqrYYfrNiTK6Pv34WBOcsING6IOHRLsP3N7hw1y6tEjfVVgkLRWrCuDSf8h6LZ+LDeAP7vMJv0SwI5z75TuUc0EjfTHw1GQHXr548va/Dr07MQ4GF0B1tJ7gpLjRFXoZIcpBGJ63Cv6AvmGVLFhQeUlL+ZSyiRVOpJVgO5qNPifqHHqZsQ4BiNqL4V7dFLo3NMPgWpW30mbWuzksQw4qgE287sygOxcURb1qmi3quozP3tWnwDucsPU+OGi/rMBQ62DtZD+iU1l1qLn+CYhu971c8fAN55lMmIGwYbdFhA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN1PR12MB2352.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(376002)(396003)(39860400002)(366004)(2616005)(956004)(16526019)(6666004)(54906003)(66476007)(66946007)(66556008)(1076003)(2906002)(8936002)(8676002)(36756003)(4326008)(966005)(26005)(186003)(6916009)(83380400001)(478600001)(6486002)(86362001)(316002)(19627235002)(5660300002)(52116002)(7696005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ZP2Z+HolOVl/CY1lSchF48Q+96Sr/7TsmUNdkzK3ig3ui/no4Q+j+w1KR/Fk205+nTZYv/WmOo/PumTVvzpWcJ7X7jeUnfgLhJYxwTLNtVnrzRX9sB/KcBBrnG/3NX+hz43uDaTOKbFJnpD+7VrKMPzc6gdnfIWh0M0oVDqe/rEPi6vAwSM8Nv8i//jznY/A1ZOEG/OQjiroTtB284mnpVoJf7vG5NMyvVeDMRd7JoEyFh7K2ukdtWofm4G+oR0Maixzksa1yO3W8Yt/F/djNeyemkOgmXb5pJjgPdacMGbyylFGSfesU7bCfpcJQbZDteA5XYe43CbMZZgRNATc7/s83MdmlURrug+tdNM8tXPjqqcXxiiCOx6nn4xRkEBT5r0HienVLM5gAYy/ZcYFQOqCgZlXMCFSlwDCsKflVFGs8UD8AlxGgRr2rXWKOQVOAfF8QP1iMKM6u+pVDlG7biu6oz+z0VcFzQYFcWQZXwM= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8968f90e-c2c9-4c6d-b210-08d816aec75e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2020 13:18:40.0376 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X9fUQmdoRbXacuY/lHN0qLqCBCOtN2FztkE8qjXG2/GJ4sy51oxQ/0Gsro0VMqibEfbSHjLOzA3lvEhN+GsdkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4461 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing this register on AMD causes an unhandled exception in SmmEntry.nasm and a subsequent failure to boot since this is too early in SMM path for the exception handler to be loaded. 1. Prepare PcAtChipsetPkg/PcAtChipsetPkg.dsc to move StandardSignatureIsAuthenticAMD into UefiCpuLib LibraryClass BaseUefiCpuLib in UefiCpuPkg. 2. To distinguish between AMD and other processors, refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib. So there is only one copy in the source. 3. Skip manipulation of MSR_IA32_MISC_ENABLE register if running on an AMD processor. Tested on AMD X64 hardware. OvmfIa32 and OvmfIa32X64 on Intel hardware. v1: Move StandardSignatureIsAuthenticAMD. Handle MSR_IA32_MISC_ENABLE v2: Incorporate Laszlo's feedback v3: Typo, not sent v4: Patch in to add UefiCpuLib to PcAtChipsetPkg.dsc v5: Patch in to add UefiCpuLib to SourceLevelDebugPkg.dsc v6: Hopefully reformat patch when sending???? Garrett Kirkendall (4): PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass SourceLevelDebugPkg: SourceLevelDebugPkg.dsc add UefiCpuLib LibraryClass UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD PcAtChipsetPkg/PcAtChipsetPkg.dsc | 2 ++ SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++ UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf | 7 ++++ UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf | 2 ++ UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf | 2 ++ UefiCpuPkg/Include/Library/UefiCpuLib.h | 14 ++++++++ UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h | 3 ++ UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c | 38 ++++++++= ++++++++++++ UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 25 ++------= ----- UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 25 ++------= ----- UefiCpuPkg/Library/MpInitLib/MpLib.c | 23 --------= ---- UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 9 ++++- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 19 ++++++++= -- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 20 ++++++++= +-- 14 files changed, 117 insertions(+), 74 deletions(-) create mode 100644 UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c Changes at: https://github.com/gkirkendall-amd/edk2/tree/smmentry_nasm_skip_msr_xd_bit_= on_amd_v6 Pull Request: https://github.com/tianocore/edk2/pull/716 Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Hao A Wu Signed-off-by: Garrett Kirkendall --=20 2.27.0