From: "Tomas Pilar (tpilar)" <Tomas.Pilar@arm.com>
To: <devel@edk2.groups.io>
Cc: <Sami.Mujawar@arm.com>, <nd@arm.com>, Ray Ni <ray.ni@intel.com>,
"Zhichao Gao" <zhichao.gao@intel.com>
Subject: [PATCH v4 1/7] ShellPkg/AcpiView: Move log reset to main method
Date: Tue, 23 Jun 2020 14:42:58 +0100 [thread overview]
Message-ID: <20200623134304.2619-2-Tomas.Pilar@arm.com> (raw)
In-Reply-To: <20200623134304.2619-1-Tomas.Pilar@arm.com>
The error and warning counters are reset in the AcpiView main method.
This improves reusability of the main method.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Tomas Pilar <tomas.pilar@arm.com>
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
index 84ffb3595750..f1a95b7b8f03 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
@@ -424,6 +424,10 @@ AcpiView (
EfiConfigurationTable = NULL;
OriginalAttribute = 0;
+ // Reset The error/warning counters
+ ResetErrorCount ();
+ ResetWarningCount ();
+
// Search the table for an entry that matches the ACPI Table Guid
FoundAcpiTable = FALSE;
for (Index = 0; Index < SystemTable->NumberOfTableEntries; Index++) {
@@ -566,10 +570,6 @@ ShellCommandRunAcpiView (
Package = NULL;
TmpDumpFileHandle = NULL;
- // Reset The error/warning counters
- ResetErrorCount ();
- ResetWarningCount ();
-
Status = ShellCommandLineParse (ParamList, &Package, &ProblemParam, TRUE);
if (EFI_ERROR (Status)) {
if (Status == EFI_VOLUME_CORRUPTED && ProblemParam != NULL) {
--
2.24.1.windows.2
next prev parent reply other threads:[~2020-06-23 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 13:42 [PATCH v4 0/7] Standalone AcpiView Application Tomas Pilar (tpilar)
2020-06-23 13:42 ` Tomas Pilar (tpilar) [this message]
2020-06-23 13:42 ` [PATCH v4 2/7] ShellPkg/AcpiView: Refactor configuration Tomas Pilar (tpilar)
2020-06-23 13:43 ` [PATCH v4 3/7] ShellPkg/AcpiView: Move table count reset Tomas Pilar (tpilar)
2020-06-23 13:43 ` [PATCH v4 4/7] ShellPkg/AcpiView: Move parameter parsing Tomas Pilar (tpilar)
2020-06-23 13:43 ` [PATCH v4 5/7] ShellPkg/AcpiView: Refactor DumpAcpiTableToFile Tomas Pilar (tpilar)
2020-06-23 13:43 ` [PATCH v4 6/7] ShellPkg: Add AcpiViewCommandLib Tomas Pilar (tpilar)
2020-06-23 13:43 ` [PATCH v4 7/7] ShellPkg/AcpiView: Add application wrapper Tomas Pilar (tpilar)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623134304.2619-2-Tomas.Pilar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox