From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
To: devel@edk2.groups.io
Cc: Maurice Ma <maurice.ma@intel.com>, Guo Dong <guo.dong@intel.com>,
Benjamin You <benjamin.you@intel.com>
Subject: [UefiPayloadPkg: Make TerminalDxe build time configurable 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable
Date: Tue, 23 Jun 2020 17:02:48 +0200 [thread overview]
Message-ID: <20200623150248.16206-2-marcello.bauer@9elements.com> (raw)
In-Reply-To: <20200623150248.16206-1-marcello.bauer@9elements.com>
From: Patrick Rudolph <patrick.rudolph@9elements.com>
As the TerminalDxe significantly slows down the boot menu rendering.
Disable it by default and add the option SERIAL_TERMINAL to enabled
it for headless platforms.
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
---
UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 5 +++++
UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 5 +++++
UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
3 files changed, 12 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
index c6c47833871b..2ea475a4cee4 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
@@ -58,6 +58,9 @@ [Defines]
DEFINE UART_DEFAULT_STOP_BITS = 1
DEFINE DEFAULT_TERMINAL_TYPE = 0
+ # Enabling the serial terminal will slow down the boot menu rendering!
+ DEFINE SERIAL_TERMINAL = FALSE
+
#
# typedef struct {
# UINT16 VendorId; ///< Vendor ID to match the PCI device. The value 0xFFFF terminates the list of entries.
@@ -502,7 +505,9 @@ [Components.IA32]
MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
+!if $(SERIAL_TERMINAL) == TRUE
MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
+!endif
UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf
#------------------------------
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
index 5559b1258521..62539ad56031 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
@@ -59,6 +59,9 @@ [Defines]
DEFINE UART_DEFAULT_STOP_BITS = 1
DEFINE DEFAULT_TERMINAL_TYPE = 0
+ # Enabling the serial terminal will slow down the boot menu redering!
+ DEFINE SERIAL_TERMINAL = FALSE
+
#
# typedef struct {
# UINT16 VendorId; ///< Vendor ID to match the PCI device. The value 0xFFFF terminates the list of entries.
@@ -504,7 +507,9 @@ [Components.X64]
MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
+!if $(SERIAL_TERMINAL) == TRUE
MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
+!endif
UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf
#------------------------------
diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index dfbcde566849..bda831d77c9b 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -131,7 +131,9 @@ [FV.DXEFV]
INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
+!if $(SERIAL_TERMINAL) == TRUE
INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
+!endif
INF UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf
#
--
2.25.4
next prev parent reply other threads:[~2020-06-23 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 15:02 [UefiPayloadPkg: Make TerminalDxe build time configurable 0/1] *** Marcello Sylvester Bauer
2020-06-23 15:02 ` Marcello Sylvester Bauer [this message]
2020-06-23 17:13 ` [UefiPayloadPkg: Make TerminalDxe build time configurable 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable Guo Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623150248.16206-2-marcello.bauer@9elements.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox