From: "Tomas Pilar (tpilar)" <Tomas.Pilar@arm.com>
To: <devel@edk2.groups.io>
Cc: <Sami.Mujawar@arm.com>, <nd@arm.com>
Subject: [PATCH 0/8] ShellPkg/AcpiView: Refactor Error Logging
Date: Mon, 29 Jun 2020 16:20:00 +0100 [thread overview]
Message-ID: <20200629152008.685-1-Tomas.Pilar@arm.com> (raw)
This patch series refactors the error logging in the AcpiView
functionality to a newly created logging facility.
The new error logging facility in AcpiViewLog.[ch] contains
helper functions to log messages of various types and severities,
enumerations of known error types as well as common abstractions
for outputting the log.
This allows for modularity when determining how the output
should be delivered to the user as well as significantly reduced
code footprint of the logging mechanism in the core AcpiView code.
Tomas Pilar (8):
ShellPkg/AcpiView: Extract configuration struct
ShellPkg/AcpiView: Declutter error counters
ShellPkg/AcpiView: Modify error message
ShellPkg/AcpiView: Create a logging facility
ShellPkg/AcpiView: Refactor PrintFieldName
ShellPkg/AcpiView: Refactor dump helpers
ShellPkg/AcpiView: Refactor AcpiView
ShellPkg/AcpiView: Refactor table parsers
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 530 +++---------------
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 173 +-----
.../AcpiTableParser.c | 56 +-
.../AcpiTableParser.h | 2 +-
.../UefiShellAcpiViewCommandLib/AcpiView.c | 226 +++-----
.../UefiShellAcpiViewCommandLib/AcpiView.h | 36 --
.../AcpiViewConfig.c | 180 +-----
.../AcpiViewConfig.h | 138 +----
.../UefiShellAcpiViewCommandLib/AcpiViewLog.c | 266 +++++++++
.../UefiShellAcpiViewCommandLib/AcpiViewLog.h | 254 +++++++++
.../Arm/SbbrValidator.c | 65 +--
.../FieldFormatHelper.h | 164 ++++++
.../Parsers/Dbg2/Dbg2Parser.c | 119 ++--
.../Parsers/Fadt/FadtParser.c | 49 +-
.../Parsers/Gtdt/GtdtParser.c | 84 +--
.../Parsers/Iort/IortParser.c | 208 +++----
.../Parsers/Madt/MadtParser.c | 99 +---
.../Parsers/Mcfg/McfgParser.c | 11 +-
.../Parsers/Pptt/PpttParser.c | 166 ++----
.../Parsers/Rsdp/RsdpParser.c | 42 +-
.../Parsers/Slit/SlitParser.c | 123 ++--
.../Parsers/Spcr/SpcrParser.c | 31 +-
.../Parsers/Srat/SratParser.c | 189 ++-----
.../Parsers/Xsdt/XsdtParser.c | 93 +--
.../UefiShellAcpiViewCommandLib.c | 22 +-
.../UefiShellAcpiViewCommandLib.inf | 3 +
26 files changed, 1289 insertions(+), 2040 deletions(-)
create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.c
create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.h
create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/FieldFormatHelper.h
--
2.24.1.windows.2
next reply other threads:[~2020-06-29 15:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 15:20 Tomas Pilar (tpilar) [this message]
2020-06-29 15:20 ` [PATCH 1/8] ShellPkg/AcpiView: Extract configuration struct Tomas Pilar (tpilar)
2020-07-10 6:15 ` Gao, Zhichao
2020-06-29 15:20 ` [PATCH 2/8] ShellPkg/AcpiView: Declutter error counters Tomas Pilar (tpilar)
2020-06-29 15:20 ` [PATCH 3/8] ShellPkg/AcpiView: Modify error message Tomas Pilar (tpilar)
2020-06-29 15:20 ` [PATCH 4/8] ShellPkg/AcpiView: Create a logging facility Tomas Pilar (tpilar)
2020-07-10 6:26 ` Gao, Zhichao
2020-06-29 15:20 ` [PATCH 5/8] ShellPkg/AcpiView: Refactor PrintFieldName Tomas Pilar (tpilar)
2020-06-29 15:20 ` [PATCH 6/8] ShellPkg/AcpiView: Refactor dump helpers Tomas Pilar (tpilar)
2020-06-29 15:20 ` [PATCH 7/8] ShellPkg/AcpiView: Refactor AcpiView Tomas Pilar (tpilar)
2020-06-29 15:20 ` [PATCH 8/8] ShellPkg/AcpiView: Refactor table parsers Tomas Pilar (tpilar)
2020-07-10 6:42 ` [edk2-devel] " Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629152008.685-1-Tomas.Pilar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox