From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.89]) by mx.groups.io with SMTP id smtpd.web10.21282.1593444041448902057 for ; Mon, 29 Jun 2020 08:20:41 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=67cHDpIx; spf=pass (domain: arm.com, ip: 40.107.21.89, mailfrom: tomas.pilar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S4ByWxzWGNj6F35+mZt8fYRidD0l+nclh/3TRFMr/SM=; b=67cHDpIxGhkmukbMIH0sAWturnN+UFresORtoPX5GFrBdVtZPjcukgQ9/EdpCDLcljOVG1KAmzAvpec+X9UnMAoo8zUmSPtTlUsI8/kjA6qJBGH1toRNEWgL5L0UVbD2yhGOC7kFJPZVJI4EqnMPEc2gSQjWOgRW+1bmliDHmP0= Received: from AM6PR10CA0027.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::40) by VI1PR08MB5423.eurprd08.prod.outlook.com (2603:10a6:803:133::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Mon, 29 Jun 2020 15:20:38 +0000 Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::64) by AM6PR10CA0027.outlook.office365.com (2603:10a6:209:89::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21 via Frontend Transport; Mon, 29 Jun 2020 15:20:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Mon, 29 Jun 2020 15:20:38 +0000 Received: ("Tessian outbound c90b0f113c0c:v60"); Mon, 29 Jun 2020 15:20:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f63e136adb6ddc61 X-CR-MTA-TID: 64aa7808 Received: from abeff3509665.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7BDB59DB-64B8-4779-830E-4A9957D97670.1; Mon, 29 Jun 2020 15:20:32 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id abeff3509665.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 29 Jun 2020 15:20:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dHxyVQLx/5FMuclKRFROQ+Ev2suD+LlMGrM5MEWNuJkEb2ayhZ2TPUYCN5JZGjmgE10KxTKkdWla95KAHOKwj6KY9PIygrhx5AtmpqVx6iLbect+sGGYw+JJfNBWEy59+0rwH+O/Mziz5QjLX1T/ENLli2EU4ppMxfebjZY96i016mvDVLs47d2PglzI6EO7HbRf/z1xgSYGmltn/Qq24txTFtPRjNGqAvP65fdnKmcA6Dimcrk8HvWrQWOcXmmbu26CXgdo8HiosTkAimovZ0F88/YQB1sA3GMN9SOf1Z9DjZ2Rx6RLHrhZl4q0lL5cM6jvz3WjtzsugZ3vqILz9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S4ByWxzWGNj6F35+mZt8fYRidD0l+nclh/3TRFMr/SM=; b=IuwmLxrWftC+bly4/cSvaHuriULNqdET8aiQF2skyjzJYcN8kgfTYbzTbZEfwflEIS0+GGXZfwm2le++0CduaYCNJA7wOiL7Vqut/YcgUTZjfVXUTD2sQrwWJfv8o7AC3vKPrcglqiYAFEABAyxnM5zaqOx0H2MpM4YXty5pu9l/Bwserq/A6AhfjnLZKuN1PdVF62uh/zWNTLYNyj8H8cvlMoGGipzl0CKxunlMDAWoXo3lDzJogvdgopYkLsIeoUkKRB7zgD/9lCiGLXFw5LkpBaCKRTcCBMKxzF5cl298lWJB0YygbFsS8iAb0v+MepmSvTOQWoiv4FcGDql26w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S4ByWxzWGNj6F35+mZt8fYRidD0l+nclh/3TRFMr/SM=; b=67cHDpIxGhkmukbMIH0sAWturnN+UFresORtoPX5GFrBdVtZPjcukgQ9/EdpCDLcljOVG1KAmzAvpec+X9UnMAoo8zUmSPtTlUsI8/kjA6qJBGH1toRNEWgL5L0UVbD2yhGOC7kFJPZVJI4EqnMPEc2gSQjWOgRW+1bmliDHmP0= Received: from DB8PR09CA0010.eurprd09.prod.outlook.com (2603:10a6:10:a0::23) by DB7PR08MB3100.eurprd08.prod.outlook.com (2603:10a6:5:28::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20; Mon, 29 Jun 2020 15:20:29 +0000 Received: from DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::33) by DB8PR09CA0010.outlook.office365.com (2603:10a6:10:a0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Mon, 29 Jun 2020 15:20:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT035.mail.protection.outlook.com (10.152.20.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3131.20 via Frontend Transport; Mon, 29 Jun 2020 15:20:29 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Mon, 29 Jun 2020 15:20:28 +0000 Received: from localhost.localdomain (10.57.4.19) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Mon, 29 Jun 2020 15:20:28 +0000 From: "Tomas Pilar (tpilar)" To: CC: , , Ray Ni , "Zhichao Gao" Subject: [PATCH 5/8] ShellPkg/AcpiView: Refactor PrintFieldName Date: Mon, 29 Jun 2020 16:20:05 +0100 Message-ID: <20200629152008.685-6-Tomas.Pilar@arm.com> X-Mailer: git-send-email 2.24.1.windows.2 In-Reply-To: <20200629152008.685-1-Tomas.Pilar@arm.com> References: <20200629152008.685-1-Tomas.Pilar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(4636009)(46966005)(82310400002)(186003)(83380400001)(81166007)(6666004)(2616005)(4326008)(5660300002)(47076004)(26005)(1076003)(498600001)(8676002)(8936002)(19627235002)(2906002)(36756003)(86362001)(426003)(6916009)(70586007)(356005)(336012)(54906003)(70206006);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3be7e46f-9a54-4296-9adc-08d81c3ffa77 X-MS-TrafficTypeDiagnostic: DB7PR08MB3100:|VI1PR08MB5423: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4941;OLM:4941; X-Forefront-PRVS: 044968D9E1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xvgD7TynB4+JHUemCWdAcP/vFTDicQWqGvHc+BQKSJhbgn0VKKQHCloMmQBSNPWIhAN6WUo6Y5ry+C6Girl5/HEca83RwB/10II0uf+M92kUysJAqwbP49Xgg42MpUk6iUueS4Q9A9h7qHtRV+hWZ1xUkt8szuq1bs2EaupUFweKZ/ieiTzd+rg20nIqNbB1iu26/+XTOGaqvL2rzf8omA5YZYV3UOzOt3g+vJfQOpTXmBtN2Fu2cnW3f6jiwJ3zDxafBBEHm+NvF9gQzaYNn2cSw7uxYuQxqgD1wRZCeCBqVR+Xx74iVJ62rtJIYN5nl+3hlaXxiguAjmJFbnvieLURsE7N0rT26zJU+CGqRKqwg6vOQ7vZd7oBsH1jCq+PrSFNweUTUQoiYUdC6IueRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3100 Return-Path: Tomas.Pilar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(136003)(346002)(376002)(39860400002)(396003)(46966005)(86362001)(6666004)(81166007)(2616005)(19627235002)(4326008)(82310400002)(26005)(83380400001)(6916009)(336012)(426003)(5660300002)(186003)(316002)(36906005)(70206006)(70586007)(2906002)(36756003)(478600001)(1076003)(54906003)(82740400003)(107886003)(8936002)(47076004)(8676002);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 1543cffd-be2b-43eb-e59f-08d81c3ff55c X-Forefront-PRVS: 044968D9E1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qiZOwX9EzrY1BPTvR65ufpdiNpQzESRNAshfoWQZaXkqaAiABPu4qiZiq9ZHI62tln+BMkTMsGuJj0rrhgbmrDqa4ogpbjGEk9C48D/ZOkTsZpA73+bFEoj/kCmZkcrD2b+lQ+k0cJhkVVBO5UwCUIYgm+qM0pVOD0PX9DYkVCow2cjiPo1fHiO+z/KSHH0ZeYXiohrmVjz122+FnEBxN9XK0sfWa2NNizIoOPyY//P1LvbUj8X6L1/fXNJX+hLpK9AnYiDAEBARh6BvLUMhkR6GbBhBVCyIuqLiSvvUHHuN7WEzC2FeEFXAXBECJI3Mqd828U3NJIXUANeDSEFnqkEIy4Zq50FfzMh0BOv3YKt7knE0/y3Mi+LK48KvWc3UpuV0WZrTbgkEC2/Btd1nug== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2020 15:20:38.2097 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3be7e46f-9a54-4296-9adc-08d81c3ffa77 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5423 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain The AcpiView core method is refactored to take format and parameters rather than a fully formatted string. This allows for far more flexible parser writing. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Tomas Pilar --- .../UefiShellAcpiViewCommandLib/AcpiParser.c | 30 ---------------- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 19 ---------- .../UefiShellAcpiViewCommandLib/AcpiViewLog.c | 36 +++++++++++++++++++ .../UefiShellAcpiViewCommandLib/AcpiViewLog.h | 21 +++++++++++ .../Parsers/Dbg2/Dbg2Parser.c | 1 + .../Parsers/Fadt/FadtParser.c | 1 + .../Parsers/Iort/IortParser.c | 1 + .../Parsers/Pptt/PpttParser.c | 1 + .../Parsers/Slit/SlitParser.c | 1 + .../Parsers/Srat/SratParser.c | 1 + .../Parsers/Xsdt/XsdtParser.c | 1 + 11 files changed, 64 insertions(+), 49 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index b88594cf3865..54d87e2768e1 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -13,8 +13,6 @@ #include "AcpiViewConfig.h" #include "AcpiViewLog.h" =20 -STATIC UINT32 gIndent; - STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; =20 /** @@ -390,34 +388,6 @@ Dump12Chars ( ); } =20 -/** - This function indents and prints the ACPI table Field Name. - - @param [in] Indent Number of spaces to add to the global table inde= nt. - The global table indent is 0 by default; however - this value is updated on entry to the ParseAcpi(= ) - by adding the indent value provided to ParseAcpi= () - and restored back on exit. - Therefore the total indent in the output is - dependent on from where this function is called. - @param [in] FieldName Pointer to the Field Name. -**/ -VOID -EFIAPI -PrintFieldName ( - IN UINT32 Indent, - IN CONST CHAR16* FieldName -) -{ - Print ( - L"%*a%-*s : ", - gIndent + Indent, - "", - (OUTPUT_FIELD_COLUMN_WIDTH - gIndent - Indent), - FieldName - ); -} - /** This function is used to parse an ACPI table buffer. =20 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h index 84eae61c8889..eb0c74eef144 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h @@ -204,25 +204,6 @@ Dump12Chars ( IN UINT8* Ptr ); =20 -/** - This function indents and prints the ACPI table Field Name. - - @param [in] Indent Number of spaces to add to the global table - indent. The global table indent is 0 by default; - however this value is updated on entry to the - ParseAcpi() by adding the indent value provided = to - ParseAcpi() and restored back on exit. Therefore - the total indent in the output is dependent on f= rom - where this function is called. - @param [in] FieldName Pointer to the Field Name. -**/ -VOID -EFIAPI -PrintFieldName ( - IN UINT32 Indent, - IN CONST CHAR16* FieldName - ); - /** This function pointer is the template for customizing the trace output =20 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.c b/S= hellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.c index 9b9aaa855fdc..11fb9efe5e11 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.c @@ -26,6 +26,7 @@ static const CHAR16* mErrorTypeDesc [ACPI_ERROR_MAX] =3D = { // Publicly accessible error and warning counters. UINT32 mTableErrorCount; UINT32 mTableWarningCount; +UINT32 gIndent; =20 /** Change the attributes of the standard output console @@ -228,3 +229,38 @@ AcpiViewLog ( RestoreColor (OriginalAttribute); } =20 +/** + This function indents and prints the ACPI table Field Name. + + @param [in] Indent Number of spaces to add to the global table inde= nt. + The global table indent is 0 by default; however + this value is updated on entry to the ParseAcpi(= ) + by adding the indent value provided to ParseAcpi= () + and restored back on exit. + Therefore the total indent in the output is + dependent on from where this function is called. + @param [in] FieldName Pointer to the format string for field name. + @param [in] ... Variable List parameters to format. +**/ +VOID +EFIAPI +PrintFieldName ( + IN UINT32 Indent, + IN CONST CHAR16* FieldNameFormat, + ... + ) +{ + VA_LIST Marker; + CHAR16 Buffer[64]; + + VA_START(Marker, FieldNameFormat); + UnicodeVSPrint(Buffer, sizeof(Buffer), FieldNameFormat, Marker); + VA_END(Marker); + + AcpiViewOutput ( + L"%*a%-*s : ", + gIndent + Indent, + "", + (OUTPUT_FIELD_COLUMN_WIDTH - gIndent - Indent), + Buffer); +} diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.h b/S= hellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.h index 77049cd8eec2..7527a6546d54 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.h +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.h @@ -42,6 +42,7 @@ typedef enum { // Publicly accessible error and warning counters. extern UINT32 mTableErrorCount; extern UINT32 mTableWarningCount; +extern UINT32 gIndent; =20 /** AcpiView output and logging function. Will log the event to @@ -212,6 +213,26 @@ CheckConstraintInternal ( CheckConstraintInternal ( \ __FILE__, __func__, __LINE__, #Constraint, Specification, Constraint, = ACPI_WARN) =20 +/** + This function indents and prints the ACPI table Field Name. + + @param [in] Indent Number of spaces to add to the global table inde= nt. + The global table indent is 0 by default; however + this value is updated on entry to the ParseAcpi(= ) + by adding the indent value provided to ParseAcpi= () + and restored back on exit. + Therefore the total indent in the output is + dependent on from where this function is called. + @param [in] FieldName Pointer to the format string for field name. + @param [in] ... Variable List parameters to format. +**/ +VOID +EFIAPI +PrintFieldName ( + IN UINT32 Indent, + IN CONST CHAR16* FieldNameFormat, + ... + ); =20 // Maximum string size that can be printed #define MAX_OUTPUT_SIZE 256 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Pa= rser.c index 9df111ecaa7d..dd69ed6992ba 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.= c @@ -12,6 +12,7 @@ #include #include "AcpiParser.h" #include "AcpiTableParser.h" +#include "AcpiViewLog.h" =20 // Local variables pointing to the table fields STATIC CONST UINT32* OffsetDbgDeviceInfo; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/Fadt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPa= rser.c index d86718bab67d..4734864dfdcf 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.= c @@ -13,6 +13,7 @@ #include "AcpiParser.h" #include "AcpiTableParser.h" #include "AcpiView.h" +#include "AcpiViewLog.h" =20 // Local variables STATIC CONST UINT32* DsdtAddress; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/Iort= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPa= rser.c index f7447947b230..356f355939aa 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.= c @@ -14,6 +14,7 @@ #include "AcpiParser.h" #include "AcpiTableParser.h" #include "AcpiViewConfig.h" +#include "AcpiViewLog.h" =20 // Local variables STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/Pptt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttPa= rser.c index acd2b81bb325..97a5203efb5f 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.= c @@ -15,6 +15,7 @@ #include "AcpiView.h" #include "AcpiViewConfig.h" #include "PpttParser.h" +#include "AcpiViewLog.h" =20 // Local variables STATIC CONST UINT8* ProcessorTopologyStructureType; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/Slit= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitPa= rser.c index e4625ee8b139..cedfc8a71849 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.= c @@ -13,6 +13,7 @@ #include #include "AcpiParser.h" #include "AcpiTableParser.h" +#include "AcpiViewLog.h" =20 // Local Variables STATIC CONST UINT64* SlitSystemLocalityCount; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/Srat= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratPa= rser.c index b9b67820b89f..568a0400bf07 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.= c @@ -14,6 +14,7 @@ #include "AcpiParser.h" #include "AcpiTableParser.h" #include "AcpiViewConfig.h" +#include "AcpiViewLog.h" =20 // Local Variables STATIC CONST UINT8* SratRAType; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/Xsdt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtPa= rser.c index e39061f8e261..771c4f322b8e 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.= c @@ -13,6 +13,7 @@ #include #include "AcpiParser.h" #include "AcpiTableParser.h" +#include "AcpiViewLog.h" =20 // Local variables STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; --=20 2.24.1.windows.2