* [PATCH v5 01/15] .pytool/Plugin: Add a plugin EccCheck
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 02/15] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check Zhang, Shenglei
` (13 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck is a plugin to report Ecc issues for code in pull request
, which will be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their code in source code files. And Ecc issues
about comments can also be handled.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.pytool/Plugin/EccCheck/EccCheck.py | 268 ++++++++++++++++++
.pytool/Plugin/EccCheck/EccCheck_plug_in.yaml | 11 +
.pytool/Plugin/EccCheck/Readme.md | 15 +
3 files changed, 294 insertions(+)
create mode 100644 .pytool/Plugin/EccCheck/EccCheck.py
create mode 100644 .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml
create mode 100644 .pytool/Plugin/EccCheck/Readme.md
diff --git a/.pytool/Plugin/EccCheck/EccCheck.py b/.pytool/Plugin/EccCheck/EccCheck.py
new file mode 100644
index 000000000000..ccdb66be616d
--- /dev/null
+++ b/.pytool/Plugin/EccCheck/EccCheck.py
@@ -0,0 +1,268 @@
+# @file EccCheck.py
+#
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+
+import os
+import re
+import csv
+import xml.dom.minidom
+from typing import List, Dict, Tuple
+import logging
+from io import StringIO
+from edk2toolext.environment import shell_environment
+from edk2toolext.environment.plugintypes.ci_build_plugin import ICiBuildPlugin
+from edk2toolext.environment.var_dict import VarDict
+from edk2toollib.utility_functions import RunCmd
+
+
+class EccCheck(ICiBuildPlugin):
+ """
+ A CiBuildPlugin that finds the Ecc issues of newly added code in pull request.
+
+ Configuration options:
+ "EccCheck": {
+ "ExceptionList": [],
+ "IgnoreFiles": []
+ },
+ """
+
+ ReModifyFile = re.compile(r'[B-Q,S-Z]+[\d]*\t(.*)')
+ FindModifyFile = re.compile(r'\+\+\+ b\/(.*)')
+ LineScopePattern = (r'@@ -\d*\,*\d* \+\d*\,*\d* @@.*')
+ LineNumRange = re.compile(r'@@ -\d*\,*\d* \+(\d*)\,*(\d*) @@.*')
+
+ def GetTestName(self, packagename: str, environment: VarDict) -> tuple:
+ """ Provide the testcase name and classname for use in reporting
+ testclassname: a descriptive string for the testcase can include whitespace
+ classname: should be patterned <packagename>.<plugin>.<optionally any unique condition>
+
+ Args:
+ packagename: string containing name of package to build
+ environment: The VarDict for the test to run in
+ Returns:
+ a tuple containing the testcase name and the classname
+ (testcasename, classname)
+ """
+ return ("Check for efi coding style for " + packagename, packagename + ".EccCheck")
+
+ ##
+ # External function of plugin. This function is used to perform the task of the ci_build_plugin Plugin
+ #
+ # - package is the edk2 path to package. This means workspace/packagepath relative.
+ # - edk2path object configured with workspace and packages path
+ # - PkgConfig Object (dict) for the pkg
+ # - EnvConfig Object
+ # - Plugin Manager Instance
+ # - Plugin Helper Obj Instance
+ # - Junit Logger
+ # - output_stream the StringIO output stream from this plugin via logging
+ def RunBuildPlugin(self, packagename, Edk2pathObj, pkgconfig, environment, PLM, PLMHelper, tc, output_stream=None):
+ edk2_path = Edk2pathObj.WorkspacePath
+ python_path = os.path.join(edk2_path, "BaseTools", "Source", "Python")
+ env = shell_environment.GetEnvironment()
+ env.set_shell_var('PYTHONPATH', python_path)
+ env.set_shell_var('WORKSPACE', edk2_path)
+ self.ECC_PASS = True
+ self.ApplyConfig(pkgconfig, edk2_path, packagename)
+ modify_dir_list = self.GetModifyDir(packagename)
+ patch = self.GetDiff(packagename)
+ ecc_diff_range = self.GetDiffRange(patch, packagename, edk2_path)
+ self.GenerateEccReport(modify_dir_list, ecc_diff_range, edk2_path)
+ ecc_log = os.path.join(edk2_path, "ecc.log")
+ if self.ECC_PASS:
+ tc.SetSuccess()
+ self.RemoveFile(ecc_log)
+ return 0
+ else:
+ with open(ecc_log, encoding='utf8') as output:
+ ecc_output = output.readlines()
+ for line in ecc_output:
+ logging.error(line)
+ self.RemoveFile(ecc_log)
+ tc.SetFailed("EccCheck failed for {0}".format(packagename), "Ecc detected issues")
+ return 1
+
+ def GetDiff(self, pkg: str) -> List[str]:
+ return_buffer = StringIO()
+ params = "diff --unified=0 origin/master HEAD"
+ RunCmd("git", params, outstream=return_buffer)
+ p = return_buffer.getvalue().strip()
+ patch = p.split("\n")
+ return_buffer.close()
+
+ return patch
+
+ def RemoveFile(self, file: str) -> None:
+ if os.path.exists(file):
+ os.remove(file)
+ return
+
+ def GetModifyDir(self, pkg: str) -> List[str]:
+ return_buffer = StringIO()
+ params = "diff --name-status" + ' HEAD' + ' origin/master'
+ RunCmd("git", params, outstream=return_buffer)
+ p1 = return_buffer.getvalue().strip()
+ dir_list = p1.split("\n")
+ return_buffer.close()
+ modify_dir_list = []
+ for modify_dir in dir_list:
+ file_path = self.ReModifyFile.findall(modify_dir)
+ if file_path:
+ file_dir = os.path.dirname(file_path[0])
+ else:
+ continue
+ if pkg in file_dir and file_dir != pkg:
+ modify_dir_list.append('%s' % file_dir)
+ else:
+ continue
+
+ modify_dir_list = list(set(modify_dir_list))
+ return modify_dir_list
+
+ def GetDiffRange(self, patch_diff: List[str], pkg: str, workingdir: str) -> Dict[str, List[Tuple[int, int]]]:
+ IsDelete = True
+ StartCheck = False
+ range_directory: Dict[str, List[Tuple[int, int]]] = {}
+ for line in patch_diff:
+ modify_file = self.FindModifyFile.findall(line)
+ if modify_file and pkg in modify_file[0] and not StartCheck and os.path.isfile(modify_file[0]):
+ modify_file_comment_dic = self.GetCommentRange(modify_file[0], workingdir)
+ IsDelete = False
+ StartCheck = True
+ modify_file_dic = modify_file[0]
+ modify_file_dic = modify_file_dic.replace("/", "\\")
+ range_directory[modify_file_dic] = []
+ elif line.startswith('--- '):
+ StartCheck = False
+ elif re.match(self.LineScopePattern, line, re.I) and not IsDelete and StartCheck:
+ start_line = self.LineNumRange.search(line).group(1)
+ line_range = self.LineNumRange.search(line).group(2)
+ if not line_range:
+ line_range = '1'
+ range_directory[modify_file_dic].append((int(start_line), int(start_line) + int(line_range) - 1))
+ for i in modify_file_comment_dic:
+ if int(i[0]) <= int(start_line) <= int(i[1]):
+ range_directory[modify_file_dic].append(i)
+ return range_directory
+
+ def GetCommentRange(self, modify_file: str, workingdir: str) -> List[Tuple[int, int]]:
+ modify_file_path = os.path.join(workingdir, modify_file)
+ with open(modify_file_path) as f:
+ line_no = 1
+ comment_range: List[Tuple[int, int]] = []
+ Start = False
+ for line in f:
+ if line.startswith('/**'):
+ start_no = line_no
+ Start = True
+ if line.startswith('**/') and Start:
+ end_no = line_no
+ Start = False
+ comment_range.append((int(start_no), int(end_no)))
+ line_no += 1
+
+ if comment_range and comment_range[0][0] == 1:
+ del comment_range[0]
+ return comment_range
+
+ def GenerateEccReport(self, modify_dir_list: List[str], ecc_diff_range: Dict[str, List[Tuple[int, int]]],
+ edk2_path: str) -> None:
+ ecc_need = False
+ ecc_run = True
+ ecc_tool = os.path.join(edk2_path, "BaseTools", "Source", "Python", "Ecc", "EccMain.py")
+ config = os.path.join(edk2_path, "BaseTools", "Source", "Python", "Ecc", "config.ini")
+ exception = os.path.join(edk2_path, "BaseTools", "Source", "Python", "Ecc", "exception.xml")
+ report = os.path.join(edk2_path, "Ecc.csv")
+ for modify_dir in modify_dir_list:
+ target = os.path.join(edk2_path, modify_dir)
+ logging.info('Run ECC tool for the commit in %s' % modify_dir)
+ ecc_need = True
+ ecc_params = "-3 {0} -c {1} -e {2} -t {3} -r {4}".format(ecc_tool, config, exception, target, report)
+ return_code = RunCmd("py", ecc_params, workingdir=edk2_path)
+ if return_code != 0:
+ ecc_run = False
+ break
+ if not ecc_run:
+ logging.error('Fail to run ECC tool')
+ self.ParseEccReport(ecc_diff_range, edk2_path)
+
+ if not ecc_need:
+ logging.info("Doesn't need run ECC check")
+
+ revert_params = "checkout -- {}".format(exception)
+ RunCmd("git", revert_params)
+ return
+
+ def ParseEccReport(self, ecc_diff_range: Dict[str, List[Tuple[int, int]]], edk2_path: str) -> None:
+ ecc_log = os.path.join(edk2_path, "Ecc.log")
+ ecc_csv = "Ecc.csv"
+ file = os.listdir(edk2_path)
+ row_lines = []
+ if ecc_csv in file:
+ with open(ecc_csv) as csv_file:
+ reader = csv.reader(csv_file)
+ for row in reader:
+ for modify_file in ecc_diff_range:
+ if modify_file in row[3]:
+ for i in ecc_diff_range[modify_file]:
+ line_no = int(row[4])
+ if i[0] <= line_no <= i[1]:
+ row[0] = '\nEFI coding style error'
+ row[1] = 'Error code: ' + row[1]
+ row[3] = 'file: ' + row[3]
+ row[4] = 'Line number: ' + row[4]
+ row_line = '\n *'.join(row)
+ row_lines.append(row_line)
+ break
+ break
+ if row_lines:
+ self.ECC_PASS = False
+
+ with open(ecc_log, 'a') as log:
+ all_line = '\n'.join(row_lines)
+ all_line = all_line + '\n'
+ log.writelines(all_line)
+ return
+
+ def ApplyConfig(self, pkgconfig: Dict[str, List[str]], edk2_path: str, pkg: str) -> None:
+ if "IgnoreFiles" in pkgconfig:
+ for a in pkgconfig["IgnoreFiles"]:
+ a = os.path.join(edk2_path, pkg, a)
+ a = a.replace(os.sep, "/")
+ try:
+ logging.info("Ignoring File {0}".format(a))
+ self.RemoveFile(a)
+ except Exception:
+ logging.info("EccCheck.IgnoreInf -> {0} not found in filesystem. Invalid ignore file".format(a))
+ if "ExceptionList" in pkgconfig:
+ exception_list = pkgconfig["ExceptionList"]
+ exception_xml = os.path.join(edk2_path, "BaseTools", "Source", "Python", "Ecc", "exception.xml")
+ try:
+ logging.info("Appending exceptions")
+ self.AppendException(exception_list, exception_xml)
+ except Exception as e:
+ logging.error("Fail to apply exceptions")
+ raise e
+ return
+
+ def AppendException(self, exception_list: List[str], exception_xml: str) -> None:
+ error_code_list = exception_list[::2]
+ keyword_list = exception_list[1::2]
+ dom_tree = xml.dom.minidom.parse(exception_xml)
+ root_node = dom_tree.documentElement
+ for error_code, keyword in zip(error_code_list, keyword_list):
+ customer_node = dom_tree.createElement("Exception")
+ keyword_node = dom_tree.createElement("KeyWord")
+ keyword_node_text_value = dom_tree.createTextNode(keyword)
+ keyword_node.appendChild(keyword_node_text_value)
+ customer_node.appendChild(keyword_node)
+ error_code_node = dom_tree.createElement("ErrorID")
+ error_code_text_value = dom_tree.createTextNode(error_code)
+ error_code_node.appendChild(error_code_text_value)
+ customer_node.appendChild(error_code_node)
+ root_node.appendChild(customer_node)
+ with open(exception_xml, 'w') as f:
+ dom_tree.writexml(f, indent='', addindent='', newl='\n', encoding='UTF-8')
+ return
diff --git a/.pytool/Plugin/EccCheck/EccCheck_plug_in.yaml b/.pytool/Plugin/EccCheck/EccCheck_plug_in.yaml
new file mode 100644
index 000000000000..0d121ecb1861
--- /dev/null
+++ b/.pytool/Plugin/EccCheck/EccCheck_plug_in.yaml
@@ -0,0 +1,11 @@
+## @file
+# CiBuildPlugin used to check Ecc issues
+#
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ "scope": "cibuild",
+ "name": "EccCheck Test",
+ "module": "EccCheck"
+}
diff --git a/.pytool/Plugin/EccCheck/Readme.md b/.pytool/Plugin/EccCheck/Readme.md
new file mode 100644
index 000000000000..85c439a5edf1
--- /dev/null
+++ b/.pytool/Plugin/EccCheck/Readme.md
@@ -0,0 +1,15 @@
+# EFI Coding style Check Plugin
+
+This CiBuildPlugin finds the Ecc issues of newly added code in pull request.
+
+## Configuration
+
+The plugin can be configured to ignore certain files and issues.
+
+"EccCheck": {
+ "ExceptionList": [],
+ "IgnoreFiles": []
+ },
+ """
+
+OPTIONAL List of file to ignore.
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH v5 02/15] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 01/15] .pytool/Plugin: Add a plugin EccCheck Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 03/15] ArmVirtPkg/ArmVirtPkg.ci.yaml: " Zhang, Shenglei
` (12 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Jian J Wang, Hao A Wu
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
MdeModulePkg/MdeModulePkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml
index 1cfc1328390e..0ed929855417 100644
--- a/MdeModulePkg/MdeModulePkg.ci.yaml
+++ b/MdeModulePkg/MdeModulePkg.ci.yaml
@@ -2,9 +2,20 @@
# CI configuration for MdeModulePkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
## options defined ci/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "MdeModulePkg.dsc"
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH v5 03/15] ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 01/15] .pytool/Plugin: Add a plugin EccCheck Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 02/15] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 04/15] CryptoPkg/CryptoPkg.ci.yaml: " Zhang, Shenglei
` (11 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Laszlo Ersek, Ard Biesheuvel, Leif Lindholm
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
index 4553725ee528..3b321c806a62 100644
--- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
+++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
@@ -5,9 +5,20 @@
# used for code analysis.
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
## options defined .pytool/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "" # Don't support this test
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH v5 04/15] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (2 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 03/15] ArmVirtPkg/ArmVirtPkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 05/15] EmulatorPkg/EmulatorPkg.ci.yaml: " Zhang, Shenglei
` (10 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Jian J Wang, Xiaoyu Lu
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
---
CryptoPkg/CryptoPkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index f54ebfb22e70..c60d8bac6dee 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -2,9 +2,20 @@
# CI configuration for CryptoPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "CryptoPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH v5 05/15] EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (3 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 04/15] CryptoPkg/CryptoPkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-07-01 1:03 ` Ni, Ray
2020-06-30 12:00 ` [PATCH v5 06/15] FatPkg/FatPkg.ci.yaml: " Zhang, Shenglei
` (9 subsequent siblings)
14 siblings, 1 reply; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Jordan Justen, Andrew Fish, Ray Ni
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
EmulatorPkg/EmulatorPkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/EmulatorPkg/EmulatorPkg.ci.yaml b/EmulatorPkg/EmulatorPkg.ci.yaml
index 81f81780ec76..a664f4462e5d 100644
--- a/EmulatorPkg/EmulatorPkg.ci.yaml
+++ b/EmulatorPkg/EmulatorPkg.ci.yaml
@@ -5,9 +5,20 @@
# used for code analysis.
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
## options defined .pytool/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "" # Don't support this test
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 05/15] EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 ` [PATCH v5 05/15] EmulatorPkg/EmulatorPkg.ci.yaml: " Zhang, Shenglei
@ 2020-07-01 1:03 ` Ni, Ray
0 siblings, 0 replies; 21+ messages in thread
From: Ni, Ray @ 2020-07-01 1:03 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Justen, Jordan L, Andrew Fish
Acked-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Tuesday, June 30, 2020 8:00 PM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH v5 05/15] EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check
>
> Add configuration ExceptionList and IgnoreFiles for package config
> files. So users can rely on this to ignore some Ecc issues.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> EmulatorPkg/EmulatorPkg.ci.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/EmulatorPkg/EmulatorPkg.ci.yaml b/EmulatorPkg/EmulatorPkg.ci.yaml
> index 81f81780ec76..a664f4462e5d 100644
> --- a/EmulatorPkg/EmulatorPkg.ci.yaml
> +++ b/EmulatorPkg/EmulatorPkg.ci.yaml
> @@ -5,9 +5,20 @@
> # used for code analysis.
> #
> # Copyright (c) Microsoft Corporation
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> ##
> {
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + "IgnoreFiles": [
> + ]
> + },
> ## options defined .pytool/Plugin/CompilerPlugin
> "CompilerPlugin": {
> "DscPath": "" # Don't support this test
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 06/15] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (4 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 05/15] EmulatorPkg/EmulatorPkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-07-01 1:03 ` Ni, Ray
2020-06-30 12:00 ` [PATCH v5 07/15] FmpDevicePkg/FmpDevicePkg.ci.yaml: " Zhang, Shenglei
` (8 subsequent siblings)
14 siblings, 1 reply; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Ray Ni
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
---
FatPkg/FatPkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg.ci.yaml
index 8b0fb1d4fcd5..e6a4c810976f 100644
--- a/FatPkg/FatPkg.ci.yaml
+++ b/FatPkg/FatPkg.ci.yaml
@@ -2,9 +2,20 @@
# CI configuration for FatPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "FatPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 06/15] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 ` [PATCH v5 06/15] FatPkg/FatPkg.ci.yaml: " Zhang, Shenglei
@ 2020-07-01 1:03 ` Ni, Ray
0 siblings, 0 replies; 21+ messages in thread
From: Ni, Ray @ 2020-07-01 1:03 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io
Acked-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Tuesday, June 30, 2020 8:00 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH v5 06/15] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check
>
> Add configuration ExceptionList and IgnoreFiles for package config
> files. So users can rely on this to ignore some Ecc issues.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
> ---
> FatPkg/FatPkg.ci.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg.ci.yaml
> index 8b0fb1d4fcd5..e6a4c810976f 100644
> --- a/FatPkg/FatPkg.ci.yaml
> +++ b/FatPkg/FatPkg.ci.yaml
> @@ -2,9 +2,20 @@
> # CI configuration for FatPkg
> #
> # Copyright (c) Microsoft Corporation
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> ##
> {
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + "IgnoreFiles": [
> + ]
> + },
> "CompilerPlugin": {
> "DscPath": "FatPkg.dsc"
> },
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 07/15] FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (5 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 06/15] FatPkg/FatPkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 08/15] MdePkg/MdePkg.ci.yaml: " Zhang, Shenglei
` (7 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Liming Gao, Michael D Kinney
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/FmpDevicePkg/FmpDevicePkg.ci.yaml b/FmpDevicePkg/FmpDevicePkg.ci.yaml
index 74a0aefe8e49..b84400f06ffd 100644
--- a/FmpDevicePkg/FmpDevicePkg.ci.yaml
+++ b/FmpDevicePkg/FmpDevicePkg.ci.yaml
@@ -2,9 +2,20 @@
# CI configuration for FmpDevicePkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "FmpDevicePkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH v5 08/15] MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (6 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 07/15] FmpDevicePkg/FmpDevicePkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 09/15] NetworkPkg/NetworkPkg.ci.yaml: " Zhang, Shenglei
` (6 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Liming Gao
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
MdePkg/MdePkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
index 3268f1535499..b6d7c57de83c 100644
--- a/MdePkg/MdePkg.ci.yaml
+++ b/MdePkg/MdePkg.ci.yaml
@@ -2,9 +2,20 @@
# CI configuration for MdePkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
## options defined ci/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "MdePkg.dsc"
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH v5 09/15] NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (7 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 08/15] MdePkg/MdePkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 10/15] OvmfPkg/OvmfPkg.ci.yaml: " Zhang, Shenglei
` (5 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Maciej Rabeda, Jiaxin Wu, Siyuan Fu
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
---
NetworkPkg/NetworkPkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/NetworkPkg/NetworkPkg.ci.yaml b/NetworkPkg/NetworkPkg.ci.yaml
index 70f2e1014748..d45faf0ac967 100644
--- a/NetworkPkg/NetworkPkg.ci.yaml
+++ b/NetworkPkg/NetworkPkg.ci.yaml
@@ -2,9 +2,20 @@
# CI configuration for NetworkPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "NetworkPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH v5 10/15] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (8 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 09/15] NetworkPkg/NetworkPkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 11/15] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: " Zhang, Shenglei
` (4 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Jordan Justen, Laszlo Ersek, Ard Biesheuvel
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/OvmfPkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml
index 98992f0429ff..e151cebf7020 100644
--- a/OvmfPkg/OvmfPkg.ci.yaml
+++ b/OvmfPkg/OvmfPkg.ci.yaml
@@ -5,9 +5,20 @@
# used for code analysis.
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
## options defined .pytool/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "" # Don't support this test
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH v5 11/15] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (9 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 10/15] OvmfPkg/OvmfPkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-07-01 1:03 ` Ni, Ray
2020-06-30 12:00 ` [PATCH v5 12/15] SecurityPkg/SecurityPkg.ci.yaml: " Zhang, Shenglei
` (3 subsequent siblings)
14 siblings, 1 reply; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Ray Ni
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
index be470807bd9e..c59287064d65 100644
--- a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
+++ b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
@@ -2,9 +2,20 @@
# CI configuration for PcAtChipsetPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "PcAtChipsetPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 11/15] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 ` [PATCH v5 11/15] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: " Zhang, Shenglei
@ 2020-07-01 1:03 ` Ni, Ray
0 siblings, 0 replies; 21+ messages in thread
From: Ni, Ray @ 2020-07-01 1:03 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io
Acked-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Tuesday, June 30, 2020 8:00 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH v5 11/15] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check
>
> Add configuration ExceptionList and IgnoreFiles for package config
> files. So users can rely on this to ignore some Ecc issues.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
> ---
> PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
> index be470807bd9e..c59287064d65 100644
> --- a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
> +++ b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
> @@ -2,9 +2,20 @@
> # CI configuration for PcAtChipsetPkg
> #
> # Copyright (c) Microsoft Corporation
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> ##
> {
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + "IgnoreFiles": [
> + ]
> + },
> "CompilerPlugin": {
> "DscPath": "PcAtChipsetPkg.dsc"
> },
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 12/15] SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (10 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 11/15] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 13/15] ShellPkg/ShellPkg.ci.yaml: " Zhang, Shenglei
` (2 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Jiewen Yao, Jian J Wang, Chao Zhang
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
SecurityPkg/SecurityPkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/SecurityPkg/SecurityPkg.ci.yaml b/SecurityPkg/SecurityPkg.ci.yaml
index 953219053318..a0e143140875 100644
--- a/SecurityPkg/SecurityPkg.ci.yaml
+++ b/SecurityPkg/SecurityPkg.ci.yaml
@@ -2,9 +2,20 @@
# CI configuration for SecurityPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "SecurityPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH v5 13/15] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (11 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 12/15] SecurityPkg/SecurityPkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-07-01 1:03 ` Ni, Ray
2020-06-30 12:00 ` [PATCH v5 14/15] UefiCpuPkg/UefiCpuPkg.ci.yaml: " Zhang, Shenglei
2020-06-30 12:00 ` [PATCH v5 15/15] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file Zhang, Shenglei
14 siblings, 1 reply; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Zhichao Gao
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Zhichao gao <zhichao.gao@intel.com>
---
ShellPkg/ShellPkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/ShellPkg/ShellPkg.ci.yaml b/ShellPkg/ShellPkg.ci.yaml
index 67de34a2556e..eedc173738dc 100644
--- a/ShellPkg/ShellPkg.ci.yaml
+++ b/ShellPkg/ShellPkg.ci.yaml
@@ -2,9 +2,20 @@
# CI configuration for ShellPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "ShellPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 13/15] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 ` [PATCH v5 13/15] ShellPkg/ShellPkg.ci.yaml: " Zhang, Shenglei
@ 2020-07-01 1:03 ` Ni, Ray
0 siblings, 0 replies; 21+ messages in thread
From: Ni, Ray @ 2020-07-01 1:03 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Gao, Zhichao
Acked-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Tuesday, June 30, 2020 8:00 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH v5 13/15] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check
>
> Add configuration ExceptionList and IgnoreFiles for package config
> files. So users can rely on this to ignore some Ecc issues.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Acked-by: Zhichao gao <zhichao.gao@intel.com>
> ---
> ShellPkg/ShellPkg.ci.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/ShellPkg/ShellPkg.ci.yaml b/ShellPkg/ShellPkg.ci.yaml
> index 67de34a2556e..eedc173738dc 100644
> --- a/ShellPkg/ShellPkg.ci.yaml
> +++ b/ShellPkg/ShellPkg.ci.yaml
> @@ -2,9 +2,20 @@
> # CI configuration for ShellPkg
> #
> # Copyright (c) Microsoft Corporation
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> ##
> {
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + "IgnoreFiles": [
> + ]
> + },
> "CompilerPlugin": {
> "DscPath": "ShellPkg.dsc"
> },
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 14/15] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (12 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 13/15] ShellPkg/ShellPkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
2020-07-01 1:03 ` Ni, Ray
2020-06-30 12:00 ` [PATCH v5 15/15] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file Zhang, Shenglei
14 siblings, 1 reply; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Eric Dong, Ray Ni, Laszlo Ersek
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
UefiCpuPkg/UefiCpuPkg.ci.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml b/UefiCpuPkg/UefiCpuPkg.ci.yaml
index 99e460a8b090..0e216344cd53 100644
--- a/UefiCpuPkg/UefiCpuPkg.ci.yaml
+++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml
@@ -2,9 +2,20 @@
# CI configuration for UefiCpuPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "UefiCpuPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 14/15] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check
2020-06-30 12:00 ` [PATCH v5 14/15] UefiCpuPkg/UefiCpuPkg.ci.yaml: " Zhang, Shenglei
@ 2020-07-01 1:03 ` Ni, Ray
0 siblings, 0 replies; 21+ messages in thread
From: Ni, Ray @ 2020-07-01 1:03 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Dong, Eric, Laszlo Ersek
Acked-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Tuesday, June 30, 2020 8:00 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [PATCH v5 14/15] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check
>
> Add configuration ExceptionList and IgnoreFiles for package config
> files. So users can rely on this to ignore some Ecc issues.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> ---
> UefiCpuPkg/UefiCpuPkg.ci.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml b/UefiCpuPkg/UefiCpuPkg.ci.yaml
> index 99e460a8b090..0e216344cd53 100644
> --- a/UefiCpuPkg/UefiCpuPkg.ci.yaml
> +++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml
> @@ -2,9 +2,20 @@
> # CI configuration for UefiCpuPkg
> #
> # Copyright (c) Microsoft Corporation
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> ##
> {
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + "IgnoreFiles": [
> + ]
> + },
> "CompilerPlugin": {
> "DscPath": "UefiCpuPkg.dsc"
> },
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 15/15] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file
2020-06-30 12:00 [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (13 preceding siblings ...)
2020-06-30 12:00 ` [PATCH v5 14/15] UefiCpuPkg/UefiCpuPkg.ci.yaml: " Zhang, Shenglei
@ 2020-06-30 12:00 ` Zhang, Shenglei
14 siblings, 0 replies; 21+ messages in thread
From: Zhang, Shenglei @ 2020-06-30 12:00 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Sean Brogan, Bret Barkelew
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
index 51e172537f8a..7e9fc5d005fb 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
@@ -5,6 +5,16 @@
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ "IgnoreFiles": [
+ ]
+ },
## options defined .pytool/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "UnitTestFrameworkPkg.dsc"
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 21+ messages in thread