From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.groups.io with SMTP id smtpd.web11.6020.1593633682667655787 for ; Wed, 01 Jul 2020 13:01:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=b8b4olNC; spf=pass (domain: nuviainc.com, ip: 209.85.128.54, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f54.google.com with SMTP id o8so23867881wmh.4 for ; Wed, 01 Jul 2020 13:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g5YYtlOpDJoodu7AkKIYoQYOqRrc01tVTnfLIEQ8Co4=; b=b8b4olNC6LrXiXMS0R95hr4Z9oYn68rul0qnGTRPxAOf2h/XKEKiGI8cumrzKbihQQ FZweAfhm5nefVVepl5Nxj3YlI7192X+iLzmB57oWgkLS4PHVm7m5aBrl+mGQDLwRN9KO ZWfm1eIV4YOlIP4Ll1AgwJZCwapJiQxIMsUUMYMG+9HGkR0NhfvY96dskR+O9gKQkAvG 3xyO3gs42WpS7KCmXM3Q1aydpc/jQIeqt/+qXXPia80z8hudvTlGf0SWQGN+V5IteieY pAytFvQmwpuwxdSNJjH839UxQdGwGxN+AgWI4uxaPewGIEVWZZaobezzIalBhnF5gAAp XbmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g5YYtlOpDJoodu7AkKIYoQYOqRrc01tVTnfLIEQ8Co4=; b=Z9LqNjnRrMIfrSzixRchUu5b1ldTjfncXXBdjyDm7GOYGd9BKEVbVqI2SLGTUHOAoz Bna9hcPKlDycJbfiLrM8hQqiuhIN/2gL005KiqVtJyJraXzFw9UxCjzGYoVry3XcOR4l W99encE0hX2AkquunmkJMcd6gDK97Gu7BuB0rrd1HFBtMchFMz6EiRyUuahnN+y2yU3P r4vP7oZYzNOlLeQuQ+FSXvxHBHu3etw4whNvXGA0/bkas1MVZkPFNqZHLR+yRIXl1NIw WVGAsO8+xnMj5lD/GgD5D7UZ4c61YasXQyvnOLs0Mvl9kxbOlDMlIhn2CUAi9QJT7lyl xhKw== X-Gm-Message-State: AOAM532V3gzTexwp5DF5mN9psHaYnigJMLNZGdX1jJc6MNO61I583RIU UC7CwodpmxZqk3LyoUi3gVT6jCmi931eaOTip4RS6TsI01A0gOsyhcCMaA32jka2Scp3jl9kTwd IUAsy7k0344vnWOm4wWTrukQZafk2ki9BchnkoWz/OR9SWcBodOFzpm/2qPjUIU/Ssw== X-Google-Smtp-Source: ABdhPJze7KqiMzBp795wUjHkEByXo7Tv081Z2Ul1kmWpTKmCgwRqQ9EAsFmx+JvBi4FoKrhFt4TKzg== X-Received: by 2002:a1c:ed17:: with SMTP id l23mr28020037wmh.175.1593633680845; Wed, 01 Jul 2020 13:01:20 -0700 (PDT) Return-Path: Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id s8sm8519067wru.38.2020.07.01.13.01.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 13:01:20 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Ard Biesheuvel , macarl@microsoft.com Subject: [RFC 0/5] EmbeddedPkg/PrePiLib: rework FfsProcessSection Date: Wed, 1 Jul 2020 21:01:13 +0100 Message-Id: <20200701200118.3972-1-leif@nuviainc.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit https://bugzilla.tianocore.org/show_bug.cgi?id=2820 describes a build failure caused by misanalysis by the compiler, but the problematic code was pretty grotty, so here's an attempt at cleaning it up. This set can also be accessed at: https://github.com/leiflindholm/edk2/tree/embedded-fwvol-cleanup Note: this code is only build tested. Leif Lindholm (5): EmbeddedPkg/PrePiLib: style cleanup in FwVol.c EmbeddedPkg/PrePiLib: drop else if after return EmbeddedPkg/PrePiLib: refactor IS_SECTION2() handling EmbeddedPkg/PrePiLib: drop spurious re-init of CompressedData EmbeddedPkg/PrePiLib: break section extraction info into helper function EmbeddedPkg/Library/PrePiLib/FwVol.c | 214 ++++++++++++++++----------- 1 file changed, 125 insertions(+), 89 deletions(-) -- 2.20.1