From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web11.6025.1593633686411021040 for ; Wed, 01 Jul 2020 13:01:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=Ek9/m7W7; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id q5so25391197wru.6 for ; Wed, 01 Jul 2020 13:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/d7T1ym/aKctj3dhVszyMk94DQ21YLF8xlWr0cMnnH0=; b=Ek9/m7W7Wrj5JFWKcmvCP6wtihrLguTm0ehbt1sLrAZQrjU9nJ2nfSb01oZgubrW+X 3xI/qEGO3ATDJkHSOVBUzV6qHBPkbxfGlnc9DLBWBmo+gB7prsAMjFxdJguGucEX0KdF f5xT+rLOtGSD2kdT4EJMqRf9CbeA1I316lKjiwjj3YhimihU9zkk1AHQCzqsdY8qD5ia EKnY9eX9myX4wCw4rkbz7PnjClTK1121BPm7Tia8CqsHbfctmuTMM97DJNoH+3+wHHuc WE2XuIZofrs2EQLH5VdXQZD1DHMkMEf8qjdFvQ2Bk79IY3K59SF9REj7Ydv8aIyinXmC PGgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/d7T1ym/aKctj3dhVszyMk94DQ21YLF8xlWr0cMnnH0=; b=f6kRE7IyzdPMA/Wq4xckAi5GP4Hf44Jw0JBmgZ8oKE47e8yZRFjZkFPndvqJZTuzmM 895t6+zFhqWRwttu7+5UK6Pn/zHnVYLSWAzR96V8N3VOuH2yVbxpAA80kt0bntITw2TW xW4Un+FEpL5pL+n5QZXHSwJmpZDmdiFIB4d9JXBZh7LFYKS92Y4i/aQuSYZAkopI+mS4 dVs5HWvI3chkuX4Hrt933NUQHxviUPxzm0MoPIAJ7Y2/GuS1H4KTIKB9qwkkBp/2P/NS ypO1X1Mw53bs0ZqCSPdtvwDERfioaKd9IPKQhUVQF0Wkml9Lh/uPZaU7Y/l0eZM7lal0 oI5Q== X-Gm-Message-State: AOAM532Kedoa+XkTth5vR9ZN4zE9uQfYYpoNc8Zp4WBgkwJTrGQRSEzh rNT8AgCEoiqH+pvyXljLH80G4fLf4puPqlIQEMNvPvuj3rAmbrykgHqTrwk+4qg6C6hanLHC5RF lLUcRkLDTppV8Tj7eeVd/3X1JfAKjXutVg9h/fOwxrLXnxNVENMOjAG22NURWwvzkIw== X-Google-Smtp-Source: ABdhPJwMkUp3D57ffZ6IILNygKheSEaznMsI0vdEJ+fVxuhkweo0Vfta82CAyXv2izEemSPggk3ckg== X-Received: by 2002:adf:e4c9:: with SMTP id v9mr27760635wrm.62.1593633684632; Wed, 01 Jul 2020 13:01:24 -0700 (PDT) Return-Path: Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id s8sm8519067wru.38.2020.07.01.13.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 13:01:23 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Ard Biesheuvel , macarl@microsoft.com Subject: [RFC 4/5] EmbeddedPkg/PrePiLib: drop spurious re-init of CompressedData Date: Wed, 1 Jul 2020 21:01:17 +0100 Message-Id: <20200701200118.3972-5-leif@nuviainc.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200701200118.3972-1-leif@nuviainc.com> References: <20200701200118.3972-1-leif@nuviainc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit After the refactoring, it is very clear that CompressedData is initialized twice, using exactly the same values. Drop the second one. Signed-off-by: Leif Lindholm --- EmbeddedPkg/Library/PrePiLib/FwVol.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c b/EmbeddedPkg/Library/PrePiLib/FwVol.c index a0672c084471..083bc27efead 100644 --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c @@ -420,8 +420,6 @@ FfsProcessSection ( // Call decompress function // if (Section->Type == EFI_SECTION_COMPRESSION) { - CompressedData = (VOID *)((UINTN)Section + FfsCompressionSectionHeaderSize (Section)); - Status = UefiDecompress ( CompressedData, DstBuffer, -- 2.20.1