public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Rebecca Cran <rebecca@bsdio.com>,
	edk2-devel-groups-io <devel@edk2.groups.io>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>,
	Andrew Fish <afish@apple.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve
Date: Thu, 2 Jul 2020 11:54:19 +0100	[thread overview]
Message-ID: <20200702105419.GN6739@vanye> (raw)
In-Reply-To: <68b55c49-1e49-e082-ca38-68c3d321611b@redhat.com>

On Thu, Jul 02, 2020 at 11:27:25 +0200, Laszlo Ersek wrote:
> This likely comes from BaseTools commit a4cfb842fca9
> ("BaseTools/PatchCheck.py: Add LicenseCheck", 2020-06-12).
> 
> One approach would be to remove "VbeShim.h" from the tracked files under
> OvmfPkg, replacing it with a PREBUILD command in the OVMF DSC files.
> (Then Bhyve could do the same.)
> 
> However, the generator, namely "VbeShim.sh", is not written in Python,
> but in (POSIX) shell, and so it can't be called from PREBUILD (I think
> it would break OVMF builds on Windows).
> 
> I don't know what to tell you, other than the blanket license
> enforcement from commit a4cfb842fca9 is likely wrong.

*Reads patch*
*Figuratively spits coffee all over keyboard*

No, this is not OK.

We *STILL* have no agreed process for accepting non bsd+patent content
since we dropped the contribution agreement. I have tried to raise
this issue several times in the past, and there has never been any
outcome from resulting discussions.

So now I'm going to send out a two-patch set consisting of:
- Reverting a4cfb842fca9. (Doing nothing is better than implying that
  anything !bsd+patent can currently be added to the tree.)
- Deleting the statement in ReadmMe.rst erroneously claiming that the
  includion of these other licenses are acceptable until such a point
  an active decision has been taken, approved by the community, that
  this is permitted.

> The generated include file *must* be a ".h" file, otherwise the INF file
> reference won't be able to trigger an incremental build, if I understand
> correctly. So replacing the ".h" suffix with something else, such as
> ".genh" (for "generated header") won't work, I believe.
> 
> Modifying the printf invocations in the generator script to also output
> a license header would not be right either, IMO. A license tag makes no
> sense (I think) without a copyright (C) statement. And what copyright
> (C) notice should we put on a generated file?
> 
> Furthermore, although "ReadMe.rst" in the project root states
> 
> """
> Contributions of code put into the public domain can also be accepted.
> """
> 
> I don't see how the license check implemented in commit a4cfb842fca9
> would accommodate a public domain contribution. (I think it would be
> fine to place the the generated header file in the public domain, *if*
> (a) we could express that somehow (is there an SPDX tag for that?),
> *and* (b) if that would eliminate the need for a (C) notice / authorship
> mark.)

Public domain is not an OSI-compatible license:
https://opensource.org/node/878

The public domain statement is also one that needs to be re-evaluated
in light of the dropped contribution agreement.

/
    Leif

> Note that this generator use case is not unique to QemuVideoDxe; see for
> example commit 1e9d6b0f98b5 ("OvmfPkg/OvmfXen: Creating an ELF header",
> 2019-08-21).
> 
> I've now filed a bug for BaseTools:
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2833
> 
> Once that bug is solved -- that is, once we standardize a tag for
> marking generated source files as such --, we can update "VbeShim.sh" to
> produce the tag, in "VbeShim.h". Then OvmfPkg/Bhyve can do the same.
> 
> Thanks
> Laszlo
> 

  reply	other threads:[~2020-07-02 10:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 15:38 OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve Rebecca Cran
2020-07-02  9:27 ` Laszlo Ersek
2020-07-02 10:54   ` Leif Lindholm [this message]
2020-07-02 13:49     ` [edk2-devel] License Check - was " Liming Gao
2020-07-02 14:13       ` Leif Lindholm
2020-07-02 14:31         ` Ard Biesheuvel
2020-07-03  1:40           ` Liming Gao
2020-07-03 10:37             ` Leif Lindholm
2020-07-03 15:07               ` Liming Gao
2020-07-03 15:49             ` Laszlo Ersek
2020-07-07 14:31               ` Liming Gao
2020-07-03  3:13   ` Rebecca Cran
2020-07-03 15:50     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702105419.GN6739@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox