From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web11.3979.1593687263102859912 for ; Thu, 02 Jul 2020 03:54:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=wfwJQdQm; spf=pass (domain: nuviainc.com, ip: 209.85.128.65, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f65.google.com with SMTP id f18so27410586wml.3 for ; Thu, 02 Jul 2020 03:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JABz1YEC9+erf4lCvp29OwT7+wT+5pbFU0B+AfqTidU=; b=wfwJQdQmllxRt+31In2ET3S1z3BXdLCnRnW4LBqJ6Vge5AuPjVm2UwRQImFp9dz9WR 9+TZ46jCEH2XtHe10qqJQ/5+rEVx7e8HAP83uU7u0YOigjdh7E5Irq58U+t5hXOYirbn +/pCCXYiq9VLPsBilPChGYwX9X7kVamd+E3k5h3pSHYOavo/51pMuiE/Z540+Blh4SCB h0gTgHNRCk12XeKy1UmIfXgvgENNZodnW+aszJMWJlQuBY89tYomOyiOz1FfAmTK9SFG 1uA2UmlFphU5jtc3kjsDR+AtrTndgLcTL229A/nWV5otHiXBPX1WDo3ICv6DIEnPxZnp TyCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JABz1YEC9+erf4lCvp29OwT7+wT+5pbFU0B+AfqTidU=; b=X7i0Jgt0Le/IGNGClf8Qxy6xfOXHlBirFwzt+8fhOqZVJO4u8NBgYLDhWv2dIbm71K 2BjXLzqMkOQ6fZ4Sitojvp5r5PQAhm3EIQtNIGA4QWVkIQa0gAUBVOs7l9LtQH4Q1yzG 5uRZtAKq1SkuYPv0aaz1NXnnRDt3Mip4D/PFnecbdsXZ82osLZFMZ1IGvm6kiLNWqFIx YMx2bbHVZBCQovprSYL/xF8jrC66jxhNqmkXNIk/HpEMQrSvcrxU7+c9E7gS/lEwHtUm HHlHEUS8nNjDMtcOF75OpLgHhWTIQRBSAEG2pXIvN1KGS8SSc6Vg8JXzAPHpFiwVNUWc ZI5Q== X-Gm-Message-State: AOAM533GKANk1ASvha0U1bNEFnV2dnO2q2/A12ShwtgnxW2p2hCDocVW SLHBUs4hMxf37M+iq+g0FSl9QQ== X-Google-Smtp-Source: ABdhPJwjXhlakQLslbvBSissbWQXZhS8C/Xuwe5gKlVVmhMSmofHSue6P52+g/QwTTuyrRIjGU5OLQ== X-Received: by 2002:a1c:28c4:: with SMTP id o187mr17255422wmo.62.1593687261705; Thu, 02 Jul 2020 03:54:21 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id u16sm10038502wmn.11.2020.07.02.03.54.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 03:54:21 -0700 (PDT) Date: Thu, 2 Jul 2020 11:54:19 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: Rebecca Cran , edk2-devel-groups-io , Ard Biesheuvel , Andrew Fish , "Justen, Jordan L" , "Kinney, Michael D" Subject: Re: License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve Message-ID: <20200702105419.GN6739@vanye> References: <92612908-44f4-30d4-ae3a-3ad595e2141f@bsdio.com> <68b55c49-1e49-e082-ca38-68c3d321611b@redhat.com> MIME-Version: 1.0 In-Reply-To: <68b55c49-1e49-e082-ca38-68c3d321611b@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 02, 2020 at 11:27:25 +0200, Laszlo Ersek wrote: > This likely comes from BaseTools commit a4cfb842fca9 > ("BaseTools/PatchCheck.py: Add LicenseCheck", 2020-06-12). > > One approach would be to remove "VbeShim.h" from the tracked files under > OvmfPkg, replacing it with a PREBUILD command in the OVMF DSC files. > (Then Bhyve could do the same.) > > However, the generator, namely "VbeShim.sh", is not written in Python, > but in (POSIX) shell, and so it can't be called from PREBUILD (I think > it would break OVMF builds on Windows). > > I don't know what to tell you, other than the blanket license > enforcement from commit a4cfb842fca9 is likely wrong. *Reads patch* *Figuratively spits coffee all over keyboard* No, this is not OK. We *STILL* have no agreed process for accepting non bsd+patent content since we dropped the contribution agreement. I have tried to raise this issue several times in the past, and there has never been any outcome from resulting discussions. So now I'm going to send out a two-patch set consisting of: - Reverting a4cfb842fca9. (Doing nothing is better than implying that anything !bsd+patent can currently be added to the tree.) - Deleting the statement in ReadmMe.rst erroneously claiming that the includion of these other licenses are acceptable until such a point an active decision has been taken, approved by the community, that this is permitted. > The generated include file *must* be a ".h" file, otherwise the INF file > reference won't be able to trigger an incremental build, if I understand > correctly. So replacing the ".h" suffix with something else, such as > ".genh" (for "generated header") won't work, I believe. > > Modifying the printf invocations in the generator script to also output > a license header would not be right either, IMO. A license tag makes no > sense (I think) without a copyright (C) statement. And what copyright > (C) notice should we put on a generated file? > > Furthermore, although "ReadMe.rst" in the project root states > > """ > Contributions of code put into the public domain can also be accepted. > """ > > I don't see how the license check implemented in commit a4cfb842fca9 > would accommodate a public domain contribution. (I think it would be > fine to place the the generated header file in the public domain, *if* > (a) we could express that somehow (is there an SPDX tag for that?), > *and* (b) if that would eliminate the need for a (C) notice / authorship > mark.) Public domain is not an OSI-compatible license: https://opensource.org/node/878 The public domain statement is also one that needs to be re-evaluated in light of the dropped contribution agreement. / Leif > Note that this generator use case is not unique to QemuVideoDxe; see for > example commit 1e9d6b0f98b5 ("OvmfPkg/OvmfXen: Creating an ELF header", > 2019-08-21). > > I've now filed a bug for BaseTools: > > https://bugzilla.tianocore.org/show_bug.cgi?id=2833 > > Once that bug is solved -- that is, once we standardize a tag for > marking generated source files as such --, we can update "VbeShim.sh" to > produce the tag, in "VbeShim.h". Then OvmfPkg/Bhyve can do the same. > > Thanks > Laszlo >