From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.groups.io with SMTP id smtpd.web11.7528.1593699207186613628 for ; Thu, 02 Jul 2020 07:13:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=wRyqpg7z; spf=pass (domain: nuviainc.com, ip: 209.85.221.42, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f42.google.com with SMTP id f18so20557772wrs.0 for ; Thu, 02 Jul 2020 07:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0CPas7NYsnNM2gNOyH1EUMv0Qqmvqmwsy5opdKjpekU=; b=wRyqpg7zrEljXLhzAtLWgQ2KT5Vmop8Gj8oiWA8mzzgm1t6Iy9zgHwZ2R+FvCtPZ4w u16RNqNeTdD62E3bcI5jG1n5b16otgLki2m8l17+A7o3h/qipA2bgofm4V9F6JQgg5p+ u0Jb7KdJcaaWlKrEJ0TSnJnON3ugG/NLLMdYYFkYUCRxI+CmwAgmJCKHVB8QhnjzEn/q cG/0Uh8TlYQL/w6Kx5pg9jcoZw8VmD/WDbNFyVDSzcY5qUFHMV87unKpFwksQparN4fb /1wOXVKKIj+pGVm26nVXd/1plZjS5At0Wu9mmAfviyjw7fH+YLUNIflmyRZaE9zSN36M 6F/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0CPas7NYsnNM2gNOyH1EUMv0Qqmvqmwsy5opdKjpekU=; b=KLCodCVoio6mMnKQe4b976HV2E6txVdTW0DSXlD8BzZ9JWAi7UiXkUyU6exkZmd2SO ywrtDWrIktuZBUFzDGpvl2s9jUEhVF21/YpjiajraVvp1O3cQulxbarx4ek3+ATqxRH7 TwYjiwvz+Ju6T32ZeuIqasDmAE6AsytKfWGmfIJ2kLqNUywNPkVps+GVzeZzh/XzidTX RzKYoCrk0xtlSotJFt3rktvJwlh7MURpb+M/9rudnnyhuF4nNNtECiD5oRA8kUFHVVo7 jrHmvbl7J0v4aD/agVtxxS91S9e2lq22qJVUSp269Z9nEzNLUFbwBWJhT4m/tdRux5pt iXBA== X-Gm-Message-State: AOAM5336qZH65iZMjyQX+EWqR7fKVsIJ81f4XV7uz+hj+hz3g1kzyMYf kDjA2sinyuzsf9nsRA7lZxQufQ== X-Google-Smtp-Source: ABdhPJxz5Jmza6hMqKFRGJyNEinBXyJOks7dQw9a9g863y/nxVG5JTu+9SI9CyKuUxgmZzkL+9OEfQ== X-Received: by 2002:a5d:4ecc:: with SMTP id s12mr31000430wrv.57.1593699205787; Thu, 02 Jul 2020 07:13:25 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id x124sm5843875wmx.16.2020.07.02.07.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:13:25 -0700 (PDT) Date: Thu, 2 Jul 2020 15:13:23 +0100 From: "Leif Lindholm" To: "Gao, Liming" Cc: "devel@edk2.groups.io" , Laszlo Ersek , Rebecca Cran , Ard Biesheuvel , Andrew Fish , "Justen, Jordan L" , "Kinney, Michael D" Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve Message-ID: <20200702141323.GQ6739@vanye> References: <92612908-44f4-30d4-ae3a-3ad595e2141f@bsdio.com> <68b55c49-1e49-e082-ca38-68c3d321611b@redhat.com> <20200702105419.GN6739@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 02, 2020 at 13:49:45 +0000, Gao, Liming wrote: > Leif: > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > > Sent: Thursday, July 2, 2020 6:54 PM > > To: Laszlo Ersek > > Cc: Rebecca Cran ; edk2-devel-groups-io ; Ard Biesheuvel ; > > Andrew Fish ; Justen, Jordan L ; Kinney, Michael D > > Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve > > > > On Thu, Jul 02, 2020 at 11:27:25 +0200, Laszlo Ersek wrote: > > > This likely comes from BaseTools commit a4cfb842fca9 > > > ("BaseTools/PatchCheck.py: Add LicenseCheck", 2020-06-12). > > > > > > One approach would be to remove "VbeShim.h" from the tracked files under > > > OvmfPkg, replacing it with a PREBUILD command in the OVMF DSC files. > > > (Then Bhyve could do the same.) > > > > > > However, the generator, namely "VbeShim.sh", is not written in Python, > > > but in (POSIX) shell, and so it can't be called from PREBUILD (I think > > > it would break OVMF builds on Windows). > > > > > > I don't know what to tell you, other than the blanket license > > > enforcement from commit a4cfb842fca9 is likely wrong. > > > > *Reads patch* > > *Figuratively spits coffee all over keyboard* > > > > No, this is not OK. > > > > We *STILL* have no agreed process for accepting non bsd+patent content > > since we dropped the contribution agreement. I have tried to raise > > this issue several times in the past, and there has never been any > > outcome from resulting discussions. > > > > So now I'm going to send out a two-patch set consisting of: > > - Reverting a4cfb842fca9. (Doing nothing is better than implying that > > anything !bsd+patent can currently be added to the tree.) > > - Deleting the statement in ReadmMe.rst erroneously claiming that the > > includion of these other licenses are acceptable until such a point > > an active decision has been taken, approved by the community, that > > this is permitted. > > > > If only bsd+patent is allowed, the checker can be enhanced to check this license only. > I don't understand why remove this checker. Mainly because that was the easiest thing to do :) But also because: - The thread that spawned this also raised the problem of machine-generated files. - I am somewhat unhappy the checker got merged in the first place without wider community feedback. BaseTools and its contents are used for many repositories (even within TianoCore), and this added unconditional check breaks the use for some of those. Regards, Leif > > Thanks > Liming > > > The generated include file *must* be a ".h" file, otherwise the INF file > > > reference won't be able to trigger an incremental build, if I understand > > > correctly. So replacing the ".h" suffix with something else, such as > > > ".genh" (for "generated header") won't work, I believe. > > > > > > Modifying the printf invocations in the generator script to also output > > > a license header would not be right either, IMO. A license tag makes no > > > sense (I think) without a copyright (C) statement. And what copyright > > > (C) notice should we put on a generated file? > > > > > > Furthermore, although "ReadMe.rst" in the project root states > > > > > > """ > > > Contributions of code put into the public domain can also be accepted. > > > """ > > > > > > I don't see how the license check implemented in commit a4cfb842fca9 > > > would accommodate a public domain contribution. (I think it would be > > > fine to place the the generated header file in the public domain, *if* > > > (a) we could express that somehow (is there an SPDX tag for that?), > > > *and* (b) if that would eliminate the need for a (C) notice / authorship > > > mark.) > > > > Public domain is not an OSI-compatible license: > > https://opensource.org/node/878 > > > > The public domain statement is also one that needs to be re-evaluated > > in light of the dropped contribution agreement. > > > > / > > Leif > > > > > Note that this generator use case is not unique to QemuVideoDxe; see for > > > example commit 1e9d6b0f98b5 ("OvmfPkg/OvmfXen: Creating an ELF header", > > > 2019-08-21). > > > > > > I've now filed a bug for BaseTools: > > > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=2833 > > > > > > Once that bug is solved -- that is, once we standardize a tag for > > > marking generated source files as such --, we can update "VbeShim.sh" to > > > produce the tag, in "VbeShim.h". Then OvmfPkg/Bhyve can do the same. > > > > > > Thanks > > > Laszlo > > > > > > > >