From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67])
by mx.groups.io with SMTP id smtpd.web12.140.1593787488269003912
for <devel@edk2.groups.io>;
Fri, 03 Jul 2020 07:44:48 -0700
Authentication-Results: mx.groups.io;
dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=vXmNZUrc;
spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com)
Received: by mail-wm1-f67.google.com with SMTP id f139so34340814wmf.5
for <devel@edk2.groups.io>; Fri, 03 Jul 2020 07:44:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:in-reply-to:user-agent;
bh=TEAvWnNSlEN8f37RPeGfJ4KNhQN31V1eJ7vnWdLCeFQ=;
b=vXmNZUrcmIlbmuZxkwP9WSTELrcDnuocsFDzdv0Bx/APfH57Jz1WZ3EtK9wKG6PKs2
1IhQfQq5+WkL2V1aQkdJtk9b61IaDtwTQqdM+Gv6iFGkfu6ywjqkjM1SvY1hiPuqNPCq
7z37SXnUP8n5FFdGajkzIPwURjWJICo0BJ8Dwz+724X2wm0srP/uG4Qj20iK6KjlMG29
+kjaYc6ZlN/mRaUcfdUNfb/3B+klFC0AT/NHZ2/DdTp2+ZOKJcYRaTe7FE2Mu6ZcjhMX
l3DgqYkbtO3s5zZH3fIBQETl+JX9n1Cvl3qHFfOW7eoPD0gLGOioKqVty3nBPxwYy+m9
y9Ng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:in-reply-to:user-agent;
bh=TEAvWnNSlEN8f37RPeGfJ4KNhQN31V1eJ7vnWdLCeFQ=;
b=I/CVGkJTRGIGe6Er5a6xC5n2wAhOZq3zQBaT741nJSp8OOkyjANm23LA0uYWz9p47S
KsTELbsHq92eF99hw7qjKb2Z17oiNDTF5R8nzQxhQ0PllYOgganFTD53m5QbETKrheN6
tCBJKwVb/wu+VZU76b1vueYJgtVWqJ1JwDZavXMnVFmpTY1Gpwh/k2Virj8STR+KWTnD
6DFy2NjMuFkGivf1GumEAHzWBcyyu5QkM1O/W1GBY+YFx5cwvEEEKlek0lG4At8r4Wt7
XXNW1A/l5fbqAOOSqeeaoDj60Ctgznkwl6iVzjHq+KtnH76HS+TnF2C7rn3jDxNuVtH0
s6QQ==
X-Gm-Message-State: AOAM530VK5QQC5C6Cq/BiQCOuqqqhvdZoW/F2Hh69Be+Bhn6Y3mNls/O
IvCbFs+mT4ifREM8vFjbGUsg1w==
X-Google-Smtp-Source: ABdhPJy31mIMaVZWL/dbEx8Xjopzy7pYAfd1qGeQN+dwoopzyL75bQfFKwrjrvSJciIZ1sLCPlTo2Q==
X-Received: by 2002:a7b:c041:: with SMTP id u1mr39162741wmc.56.1593787486794;
Fri, 03 Jul 2020 07:44:46 -0700 (PDT)
Return-Path: <leif@nuviainc.com>
Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8])
by smtp.gmail.com with ESMTPSA id y77sm3674765wmd.36.2020.07.03.07.44.45
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 03 Jul 2020 07:44:46 -0700 (PDT)
Date: Fri, 3 Jul 2020 15:44:43 +0100
From: "Leif Lindholm" <leif@nuviainc.com>
To: Wasim Khan <wasim.khan@oss.nxp.com>
Cc: devel@edk2.groups.io, meenakshi.aggarwal@nxp.com, V.Sethi@nxp.com,
ard.biesheuvel@arm.com, Wasim Khan <wasim.khan@nxp.com>
Subject: Re: [PATCH edk2-platforms v2 0/7] NXP: Add PCIe Support for LX2160aRdbPkg
Message-ID: <20200703144443.GW6739@vanye>
References: <1593413106-1672-1-git-send-email-wasim.khan@oss.nxp.com>
MIME-Version: 1.0
In-Reply-To: <1593413106-1672-1-git-send-email-wasim.khan@oss.nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Mon, Jun 29, 2020 at 12:14:59 +0530, Wasim Khan wrote:
> From: Wasim Khan <wasim.khan@nxp.com>
>
> LX2160-Rev1 and LX2160-Rev2 has different PCIe controller.
> This patch series adds PCIe support for LX2160aRdbPkg which includes
> - Add PCIe space in VirtualMemoryMap
> - Platform driver to check SoC version and sets PCDs for PCIe controller, which
> are used by PciHostBridgeLib and PciSegmentLib.
> PciHostBridgeLib and PciSegmentLib already has support for both PCIe controllers.
> - Enable NetworkPkg for LX2160aRdbPkg Platform.
>
>
> Changes in V2:
> - Addressed review comments on V1
Thanks!
For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as b716f363e752..b9fba411178f.
> V1 series can be referred here:
> https://edk2.groups.io/g/devel/message/61062
>
> Wasim Khan (7):
> Silicon/NXP: LX2160A: Define PCIe related PCDs
> Platform/NXP: LX2160aRdbPkg: Add PCIe space in VirtualMemoryMap
> Platform/NXP: LX2160aRdbPkg: Add PlatformDxe driver
> Platform/NXP: LX2160aRdbPkg: Enable PlatformDxe driver
> Platform/NXP: LX2160aRdbPkg: Hide Root Port for LX2160A-Rev2
> Platform/NXP: LX2160aRdbPkg: Enable NetworkPkg
> Platform/NXP: LX2160aRdbPkg: Enable PCIE support
>
> Silicon/NXP/NxpQoriqLs.dec | 1 +
> Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 +
> Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 22 +++++
> Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 15 +++
> Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf | 36 ++++++++
> Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf | 2 +
> Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 +
> Silicon/NXP/Include/Pcie.h | 1 +
> Silicon/NXP/LX2160A/Include/Soc.h | 3 +
> Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.c | 97 ++++++++++++++++++++
> Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c | 11 ++-
> Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c | 6 +-
> 12 files changed, 198 insertions(+), 2 deletions(-)
> create mode 100644 Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf
> create mode 100644 Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.c
>
> --
> 2.7.4
>