From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [51.163.158.102]) by mx.groups.io with SMTP id smtpd.web12.12054.1594110285032444055 for ; Tue, 07 Jul 2020 01:24:45 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 51.163.158.102, mailfrom: glin@suse.com) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-1-sspBX1mMPAuYlPlTqdjm0Q-1; Tue, 07 Jul 2020 10:24:40 +0200 X-MC-Unique: sspBX1mMPAuYlPlTqdjm0Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVswe2YVTl+dpULz7J/Q4wOCHQofCbkNA/QEpWEXfwEtNEqeJmXq/kNPB3tq2/K9DB75J+/jevq24qxxbHXiR7Rx0iIbSznHVvZ9aEszFRDxQdZaaEc7ZGiV6KAzkFibv4sgpPjoqDAUajp4rvfcKZ8Xkgn0ev2Gw3w2C3Fwvd7hflR9GsXb+8z2kaTQIf1doMWFBElFKWzOvuqUSWFKS9J18swj8+E9sXwbMHlMGsFbHyAc4oYfwYMXOJlkRG0CQxSW0CGyFRDsX3eqA/4fVzN44srM+pViDlwl8QbESTd8DajHgx3mBXjP3nTbA5VBTahCNboSlEV0obdUEfABKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rlTqxUJ7M7shH+aiFP5ghqM4pbPHdXSicNRcZXSWNhc=; b=LCC8zeJq9CZTQeF71vpjRvUtv37qmkGyIh0bG7rhJJODumL0iPfTCdkwN6np0WCpiwv6TTLckqcyS+KPapk311dgWWvyX5HWphPESsvHMtRG/HCHJkJlRlCMqg4Zt6Q0ltHpNOlPJ0oVgUKTFBei22hPxHpXjzjJUpdt/NL1H7dPEeDFVp0zwc+TPUDq7LmLJvf/YLCSpZTzvRLFWXUcIscMUR5hzsD1MD3VZpsHw9g88Zi18sUlh4rR5nl+3BSiegxx7E1Amjh7zxVnJMsrtQ37NCHUQcKUhSRiMDzdAhPxHl404SjY2N0VDz34WHgPuKt6w0xy4mh/VdHDGJf5Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=suse.com; Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) by AM0PR04MB6707.eurprd04.prod.outlook.com (2603:10a6:208:16f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.27; Tue, 7 Jul 2020 08:24:38 +0000 Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::8806:715f:1409:8c6b]) by AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::8806:715f:1409:8c6b%7]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020 08:24:38 +0000 Date: Tue, 7 Jul 2020 16:24:30 +0800 From: "Gary Lin" To: Laszlo Ersek Cc: devel@edk2.groups.io, Jordan Justen , Ard Biesheuvel Subject: Re: [PATCH 01/11] OvmfPkg/LsiScsiDxe: Create the empty driver Message-ID: <20200707082430.GL18504@GaryWorkstation> References: <20200701040448.14871-1-glin@suse.com> <20200701040448.14871-2-glin@suse.com> In-Reply-To: X-ClientProxiedBy: AM0PR02CA0022.eurprd02.prod.outlook.com (2603:10a6:208:3e::35) To AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) Return-Path: glin@suse.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from GaryWorkstation (60.251.47.115) by AM0PR02CA0022.eurprd02.prod.outlook.com (2603:10a6:208:3e::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23 via Frontend Transport; Tue, 7 Jul 2020 08:24:37 +0000 X-Originating-IP: [60.251.47.115] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d567f78-abe7-4bd5-5031-08d8224f3060 X-MS-TrafficTypeDiagnostic: AM0PR04MB6707: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 0457F11EAF X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VyUvuD7xSlcd1s6qymoolaE4SIY/SEhrfix4I1AmEIM35tqooqyPcxOJOMToy8rtGX5Zohk4sI5T2V1T3qeSsGIzhPYMe4xG6q/xKvqgnlx9muIYwGYRCkJ6vChJBgfcwtWLKIh8ZJrysQIGUUCg95hEGZ6rvT1zDeJSQDntPjb1tj3VuiNRS/6XOTMZxnkNZSMvVbdyRhoZ6oHqBSztj7eA0NKv75n+MsStVPx5Cuu48ZELJktCObg3rdajYgzcRKPtduvITrzEERa4MXIaby2uKje0ju/uJDXC0SYVCZSfCwS2iydUUKYgK8ChsLe1b30GMonpfEkEMxS9X6lY2A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR0402MB3809.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(376002)(346002)(39860400002)(366004)(136003)(1076003)(8676002)(2906002)(6916009)(5660300002)(33716001)(8936002)(66556008)(6496006)(316002)(66476007)(86362001)(66946007)(956004)(9686003)(16526019)(186003)(19627235002)(55016002)(54906003)(478600001)(6666004)(83380400001)(53546011)(55236004)(4326008)(33656002)(26005)(52116002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 6dVAWU02hit2w1Xsa3iuLhfiw5uI6KzMzhv4Injj4HecZqOCST7LD6qGdA0B+a8LnrJCADCSdru3kIntwBMYHoNxpnxdK1clula+g7uV1ajwkJNF3Po+IREDg0TexOqUoQ9CHOBIpup8Km1ucraO6c8Oj7jbAhMaXTL/gQU5rgSoZ9QMX5Ajec0+TlmSNZN6sU17hIPgge7tE+QRn3DJUfVGBcJ+B6bJKOSnFYD5w9VTdHmQMijes2ZI2/TLM4TyI4yTFkYUTqE7Ht3Cap6MTafuMtb1Qc9iyTH1xZi8qXzOSXh4BHte6fTMveOc5AQjH5TQCxAoTmQUJGP/PK8fJg9D2Hrspu3D33BPnKos9fsZnK6Z85w3vH0bOqH1l68t4JpYNG33QtR3+U2dowTkqobT/ElFpnzNUYHS/DECdFglqCLZdwc7/lcQ13egf5T49kn8J84j+qQqrKAiZBqx9N+qChXLXQEaTBYDm5i0oIU= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d567f78-abe7-4bd5-5031-08d8224f3060 X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3809.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2020 08:24:38.6632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZSyjK+wiFvZVgznN5+K+c4eFwf+oMBmwm5LifqRmIeGHNegtKRVa+9ihEG0xMRkh X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6707 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 07, 2020 at 09:59:04AM +0200, Laszlo Ersek wrote: > On 07/01/20 06:04, Gary Lin wrote: > > Create the driver with only a dummy LsiScsiEntryPoint() for the further > > implementation of the driver for LSI 53C895A SCSI controller. > > > > Cc: Jordan Justen > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Signed-off-by: Gary Lin > > --- > > OvmfPkg/LsiScsiDxe/LsiScsi.c | 25 +++++++++++++++++++++++++ > > OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf | 26 ++++++++++++++++++++++++++ > > OvmfPkg/OvmfPkgIa32.dsc | 4 ++++ > > OvmfPkg/OvmfPkgIa32.fdf | 3 +++ > > OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++ > > OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++ > > OvmfPkg/OvmfPkgX64.dsc | 4 ++++ > > OvmfPkg/OvmfPkgX64.fdf | 3 +++ > > 8 files changed, 72 insertions(+) > > create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsi.c > > create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf > > > > diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.c b/OvmfPkg/LsiScsiDxe/LsiScsi.c > > new file mode 100644 > > index 000000000000..9c90941688ed > > --- /dev/null > > +++ b/OvmfPkg/LsiScsiDxe/LsiScsi.c > > @@ -0,0 +1,25 @@ > > +/** @file > > + > > + This driver produces Extended SCSI Pass Thru Protocol instances for > > + LSI 53C895A SCSI devices. > > + > > + Copyright (C) 2020, SUSE LLC. > > + > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > +**/ > > + > > +#include > > + > > +// > > +// Entry point of this driver > > +// > > +EFI_STATUS > > +EFIAPI > > +LsiScsiEntryPoint ( > > + IN EFI_HANDLE ImageHandle, > > + IN EFI_SYSTEM_TABLE *SystemTable > > + ) > > +{ > > + return EFI_UNSUPPORTED; > > +} > > diff --git a/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf b/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf > > new file mode 100644 > > index 000000000000..55b483c2fa20 > > --- /dev/null > > +++ b/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf > > @@ -0,0 +1,26 @@ > > +## @file > > +# This driver produces Extended SCSI Pass Thru Protocol instances for > > +# LSI 53C895A SCSI devices. > > +# > > +# Copyright (C) 2020, SUSE LLC. > > +# > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > +# > > +## > > + > > +[Defines] > > + INF_VERSION = 1.29 > > + BASE_NAME = LsiScsiDxe > > + FILE_GUID = EB4EB21f-5A3D-40BE-8BD2-F1B0E38E5744 > > (1) The GUID should not be written in mixed case. Please pick upper case > or lower case for the whole GUID string. > > (I wonder how you created the current (mixed-case) GUID string... > uuidgen outputs lower case, and I wonder how one can translate > everything except the *first* "f" from that to upper case. I hope you > didn't manually update a previously generated GUID!) Oops, I generated the GUID with uuidgen and converted it to upper case manually (facepalm). Will fix it. Gary Lin > > with the spelling fixed, or the GUID regenerated: > > Reviewed-by: Laszlo Ersek > > Thanks > Laszlo > > > + MODULE_TYPE = UEFI_DRIVER > > + VERSION_STRING = 1.0 > > + ENTRY_POINT = LsiScsiEntryPoint > > + > > +[Sources] > > + LsiScsi.c > > + > > +[Packages] > > + MdePkg/MdePkg.dec > > + > > +[LibraryClasses] > > + UefiDriverEntryPoint > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > > index b4ee7376791b..9178ffeb71cb 100644 > > --- a/OvmfPkg/OvmfPkgIa32.dsc > > +++ b/OvmfPkg/OvmfPkgIa32.dsc > > @@ -50,6 +50,7 @@ [Defines] > > # > > DEFINE PVSCSI_ENABLE = TRUE > > DEFINE MPT_SCSI_ENABLE = TRUE > > + DEFINE LSI_SCSI_ENABLE = FALSE > > > > # > > # Flash size selection. Setting FD_SIZE_IN_KB on the command line directly to > > @@ -771,6 +772,9 @@ [Components] > > !endif > > !if $(MPT_SCSI_ENABLE) == TRUE > > OvmfPkg/MptScsiDxe/MptScsiDxe.inf > > +!endif > > +!if $(LSI_SCSI_ENABLE) == TRUE > > + OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf > > !endif > > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > > index e2b759aa8d05..2b9a6b58015f 100644 > > --- a/OvmfPkg/OvmfPkgIa32.fdf > > +++ b/OvmfPkg/OvmfPkgIa32.fdf > > @@ -236,6 +236,9 @@ [FV.DXEFV] > > !if $(MPT_SCSI_ENABLE) == TRUE > > INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf > > !endif > > +!if $(LSI_SCSI_ENABLE) == TRUE > > +INF OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf > > +!endif > > > > !if $(SECURE_BOOT_ENABLE) == TRUE > > INF SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > > index ed68b080f2a2..a665f78f0dc7 100644 > > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > > @@ -49,6 +49,7 @@ [Defines] > > # > > DEFINE PVSCSI_ENABLE = TRUE > > DEFINE MPT_SCSI_ENABLE = TRUE > > + DEFINE LSI_SCSI_ENABLE = FALSE > > > > # > > # Flash size selection. Setting FD_SIZE_IN_KB on the command line directly to > > @@ -785,6 +786,9 @@ [Components.X64] > > !endif > > !if $(MPT_SCSI_ENABLE) == TRUE > > OvmfPkg/MptScsiDxe/MptScsiDxe.inf > > +!endif > > +!if $(LSI_SCSI_ENABLE) == TRUE > > + OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf > > !endif > > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > > index bfca1eff9e83..83ff6aef2e8c 100644 > > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > > @@ -237,6 +237,9 @@ [FV.DXEFV] > > !if $(MPT_SCSI_ENABLE) == TRUE > > INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf > > !endif > > +!if $(LSI_SCSI_ENABLE) == TRUE > > +INF OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf > > +!endif > > > > !if $(SECURE_BOOT_ENABLE) == TRUE > > INF SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > > index cb7e8068a3d8..17f345acf4ee 100644 > > --- a/OvmfPkg/OvmfPkgX64.dsc > > +++ b/OvmfPkg/OvmfPkgX64.dsc > > @@ -49,6 +49,7 @@ [Defines] > > # > > DEFINE PVSCSI_ENABLE = TRUE > > DEFINE MPT_SCSI_ENABLE = TRUE > > + DEFINE LSI_SCSI_ENABLE = FALSE > > > > # > > # Flash size selection. Setting FD_SIZE_IN_KB on the command line directly to > > @@ -781,6 +782,9 @@ [Components] > > !endif > > !if $(MPT_SCSI_ENABLE) == TRUE > > OvmfPkg/MptScsiDxe/MptScsiDxe.inf > > +!endif > > +!if $(LSI_SCSI_ENABLE) == TRUE > > + OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf > > !endif > > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > > index bfca1eff9e83..83ff6aef2e8c 100644 > > --- a/OvmfPkg/OvmfPkgX64.fdf > > +++ b/OvmfPkg/OvmfPkgX64.fdf > > @@ -237,6 +237,9 @@ [FV.DXEFV] > > !if $(MPT_SCSI_ENABLE) == TRUE > > INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf > > !endif > > +!if $(LSI_SCSI_ENABLE) == TRUE > > +INF OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf > > +!endif > > > > !if $(SECURE_BOOT_ENABLE) == TRUE > > INF SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf > > >