From: "Leif Lindholm" <leif@nuviainc.com>
To: Pankaj Bansal <pankaj.bansal@oss.nxp.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
devel@edk2.groups.io, Varun Sethi <V.Sethi@nxp.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Augustine Philips <Augustine.Philips@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Arokia Samy <arokia.samy@puresoftware.com>,
Kuldip Dwivedi <kuldip.dwivedi@puresoftware.com>
Subject: Re: [PATCH edk2-platforms v2 0/6] Add LS1046AFRWY Platform
Date: Tue, 7 Jul 2020 13:53:36 +0100 [thread overview]
Message-ID: <20200707125336.GF12303@vanye> (raw)
In-Reply-To: <20200706082421.9139-1-pankaj.bansal@oss.nxp.com>
On Mon, Jul 06, 2020 at 03:24:15 -0500, Pankaj Bansal wrote:
> From: Pankaj Bansal <pankaj.bansal@nxp.com>
>
> The Layerscape LS1046A Freeway (FRWY-LS1046A) board is a high-performance
> development platform that supports the QorIQ LS1046A architecture
> processor.
>
> The LS1046A SOC is based on Layerscape Chassis2.
>
> The code structure is same as Chassis2 and LS1043A SOC and LS1043ARDB
> platform.
>
> V1 can be referred here:
> https://edk2.groups.io/g/devel/message/60577
>
> Changes in V2 w.r.t V1:
> - No functional changes
> - Explaination Added for PATCH 2/6 Silicon/NXP/LS1043A: Fix the RCW bits' parsing
> - Refer PATCH 1/6 Silicon/NXP: Add comments explaining RCW bits' parsing
> for expalaination for PATCH 2/6 Silicon/NXP/LS1043A: Fix the RCW bits' parsing
OK, so if you can drop yourself from any Co-authored tags, 1-3 and 6/6
can have Reviewed-by: Leif Lindholm <leif@nuviainc.com>
But please move all the ArmPlatformLib bits to a single patch and
submit a v3.
Regards,
Leif
> Pankaj Bansal (6):
> Silicon/NXP: Add comments explaining RCW bits' parsing
> Silicon/NXP/LS1043A: Fix the RCW bits' parsing
> Silicon/NXP: Add LS1046A Soc package
> Platform/NXP/LS1046AFRWY: Add ArmPlatformLib
> Platform/NXP: Add LS1046AFRWY Platform
> Platform/NXP/LS1046aFrwyPkg: Add VarStore
>
> .../NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dec | 23 +++
> Silicon/NXP/LS1046A/LS1046A.dec | 13 ++
> Silicon/NXP/LS1046A/LS1046A.dsc.inc | 42 +++++
> .../NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc | 46 +++++
> .../NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf | 169 ++++++++++++++++++
> .../Library/ArmPlatformLib/ArmPlatformLib.inf | 42 +++++
> Silicon/NXP/LS1046A/Library/SocLib/SocLib.inf | 27 +++
> Silicon/NXP/LS1043A/Include/Soc.h | 29 ++-
> Silicon/NXP/LS1046A/Include/Soc.h | 63 +++++++
> Silicon/NXP/LS1046A/Include/SocSerDes.h | 33 ++++
> Silicon/NXP/LX2160A/Include/Soc.h | 28 ++-
> .../Library/ArmPlatformLib/ArmPlatformLib.c | 147 +++++++++++++++
> .../ArmPlatformLib/ArmPlatformLibMem.c | 75 ++++++++
> Silicon/NXP/LS1046A/Library/SocLib/SerDes.c | 119 ++++++++++++
> Silicon/NXP/LS1046A/Library/SocLib/SocLib.c | 78 ++++++++
> .../AArch64/ArmPlatformHelper.S | 45 +++++
> Platform/NXP/LS1046aFrwyPkg/VarStore.fdf.inc | 91 ++++++++++
> 17 files changed, 1068 insertions(+), 2 deletions(-)
> create mode 100644 Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dec
> create mode 100644 Silicon/NXP/LS1046A/LS1046A.dec
> create mode 100644 Silicon/NXP/LS1046A/LS1046A.dsc.inc
> create mode 100644 Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc
> create mode 100644 Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf
> create mode 100644 Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
> create mode 100644 Silicon/NXP/LS1046A/Library/SocLib/SocLib.inf
> create mode 100644 Silicon/NXP/LS1046A/Include/Soc.h
> create mode 100644 Silicon/NXP/LS1046A/Include/SocSerDes.h
> create mode 100644 Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c
> create mode 100644 Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c
> create mode 100644 Silicon/NXP/LS1046A/Library/SocLib/SerDes.c
> create mode 100644 Silicon/NXP/LS1046A/Library/SocLib/SocLib.c
> create mode 100644 Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/AArch64/ArmPlatformHelper.S
> create mode 100644 Platform/NXP/LS1046aFrwyPkg/VarStore.fdf.inc
>
> --
> 2.17.1
>
prev parent reply other threads:[~2020-07-07 12:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 8:24 [PATCH edk2-platforms v2 0/6] Add LS1046AFRWY Platform Pankaj Bansal
2020-07-06 8:24 ` [PATCH edk2-platforms v2 1/6] Silicon/NXP: Add comments explaining RCW bits' parsing Pankaj Bansal
2020-07-06 8:24 ` [PATCH edk2-platforms v2 2/6] Silicon/NXP/LS1043A: Fix the " Pankaj Bansal
2020-07-06 8:24 ` [PATCH edk2-platforms v2 3/6] Silicon/NXP: Add LS1046A Soc package Pankaj Bansal
2020-07-07 12:39 ` Leif Lindholm
2020-07-06 8:24 ` [PATCH edk2-platforms v2 4/6] Platform/NXP/LS1046AFRWY: Add ArmPlatformLib Pankaj Bansal
2020-07-07 12:41 ` Leif Lindholm
2020-07-06 8:24 ` [PATCH edk2-platforms v2 5/6] Platform/NXP: Add LS1046AFRWY Platform Pankaj Bansal
2020-07-07 12:50 ` Leif Lindholm
2020-07-06 8:24 ` [PATCH edk2-platforms v2 6/6] Platform/NXP/LS1046aFrwyPkg: Add VarStore Pankaj Bansal
2020-07-07 12:53 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707125336.GF12303@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox