From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web11.15463.1594126420722009351 for ; Tue, 07 Jul 2020 05:53:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=uVQFdSwz; spf=pass (domain: nuviainc.com, ip: 209.85.221.68, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f68.google.com with SMTP id z15so33731881wrl.8 for ; Tue, 07 Jul 2020 05:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=g8fI0Rum7IwUrCOsSItzrGQeSCnUpkkUtnKJGxFZqhM=; b=uVQFdSwzh8VYVTzLyawmZPvsB6yACDEsLGyiW4zt0WCzu4MlL+oINxQH3im5LOBx/B PfBLI0Gj//Y9bceTlCMjyE8NKkNuDcRNVr1dd6Rkwu7OrPcvKIBFds7s+S3rRnnJuhtX qYmnHg84g8Ddr9Xts8sUh/PQ9fnBwuIHQajq0/BLa/EVOyuV1Nbt8IgsHuOs/Xdv79Hy R9AZZD0yaq1zuXNAi3I4su28Sot+hOP3+3/VaudGejYg92MTaxGbH1at7YR0p5CrQRHZ 82PQPzt7DJbNxOv1obzoXg+UYX/4VcN9uP9pD7XPKjqq4Ax8yA+O9gDWc0MIeLcEfVj4 KHMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g8fI0Rum7IwUrCOsSItzrGQeSCnUpkkUtnKJGxFZqhM=; b=UMbWLiyb+uA0HoZoM2tqLYebedkoOgg4DIUTiMdRojXQ5y6pxLDh7lNTaBNjbYPwzY KZF8YcbbB1f+MWWPX74+k4npUJk1IIQ/U2EtxYZtE7tmeRSWlBhOex2cgwMdNDYcTA/8 yVmfotkJlILPRoxe8TmLxuvrwYvHMRs+qv1uirZ64u6NL6cHbdaRFChgawRM8aokLLWi MEUksGAdPfPUmjGkrfRoR91lulHMaD3flBua6L2KSg9is1/aduUX15Z1aPbzQGFfa4++ c3qNJSuMoKK+w/1t9v632bu2LA8DsYM7+U1ZJ++9Hp+ECrTEnzv0X8DcaKdmJdqqTuqX IVYw== X-Gm-Message-State: AOAM533vLZDdqgW6v8tAshOQw/zd8pMFZUJOKX64VJpAhMKvBZTdXJJW OjFjllhHUPw/U7EuFUyHbkPvOtwFvEtlHg== X-Google-Smtp-Source: ABdhPJyGy/1n0gikKxtXruGrZNNzbjLOJ3+0q0h0PIUR1q6EYM/IfyLYk2iazBpE8ctutn/9lflahA== X-Received: by 2002:adf:f707:: with SMTP id r7mr52903122wrp.70.1594126419325; Tue, 07 Jul 2020 05:53:39 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id v6sm885990wrr.85.2020.07.07.05.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 05:53:38 -0700 (PDT) Date: Tue, 7 Jul 2020 13:53:36 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Augustine Philips , Ard Biesheuvel , Arokia Samy , Kuldip Dwivedi Subject: Re: [PATCH edk2-platforms v2 0/6] Add LS1046AFRWY Platform Message-ID: <20200707125336.GF12303@vanye> References: <20200706082421.9139-1-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200706082421.9139-1-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 06, 2020 at 03:24:15 -0500, Pankaj Bansal wrote: > From: Pankaj Bansal > > The Layerscape LS1046A Freeway (FRWY-LS1046A) board is a high-performance > development platform that supports the QorIQ LS1046A architecture > processor. > > The LS1046A SOC is based on Layerscape Chassis2. > > The code structure is same as Chassis2 and LS1043A SOC and LS1043ARDB > platform. > > V1 can be referred here: > https://edk2.groups.io/g/devel/message/60577 > > Changes in V2 w.r.t V1: > - No functional changes > - Explaination Added for PATCH 2/6 Silicon/NXP/LS1043A: Fix the RCW bits' parsing > - Refer PATCH 1/6 Silicon/NXP: Add comments explaining RCW bits' parsing > for expalaination for PATCH 2/6 Silicon/NXP/LS1043A: Fix the RCW bits' parsing OK, so if you can drop yourself from any Co-authored tags, 1-3 and 6/6 can have Reviewed-by: Leif Lindholm But please move all the ArmPlatformLib bits to a single patch and submit a v3. Regards, Leif > Pankaj Bansal (6): > Silicon/NXP: Add comments explaining RCW bits' parsing > Silicon/NXP/LS1043A: Fix the RCW bits' parsing > Silicon/NXP: Add LS1046A Soc package > Platform/NXP/LS1046AFRWY: Add ArmPlatformLib > Platform/NXP: Add LS1046AFRWY Platform > Platform/NXP/LS1046aFrwyPkg: Add VarStore > > .../NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dec | 23 +++ > Silicon/NXP/LS1046A/LS1046A.dec | 13 ++ > Silicon/NXP/LS1046A/LS1046A.dsc.inc | 42 +++++ > .../NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc | 46 +++++ > .../NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf | 169 ++++++++++++++++++ > .../Library/ArmPlatformLib/ArmPlatformLib.inf | 42 +++++ > Silicon/NXP/LS1046A/Library/SocLib/SocLib.inf | 27 +++ > Silicon/NXP/LS1043A/Include/Soc.h | 29 ++- > Silicon/NXP/LS1046A/Include/Soc.h | 63 +++++++ > Silicon/NXP/LS1046A/Include/SocSerDes.h | 33 ++++ > Silicon/NXP/LX2160A/Include/Soc.h | 28 ++- > .../Library/ArmPlatformLib/ArmPlatformLib.c | 147 +++++++++++++++ > .../ArmPlatformLib/ArmPlatformLibMem.c | 75 ++++++++ > Silicon/NXP/LS1046A/Library/SocLib/SerDes.c | 119 ++++++++++++ > Silicon/NXP/LS1046A/Library/SocLib/SocLib.c | 78 ++++++++ > .../AArch64/ArmPlatformHelper.S | 45 +++++ > Platform/NXP/LS1046aFrwyPkg/VarStore.fdf.inc | 91 ++++++++++ > 17 files changed, 1068 insertions(+), 2 deletions(-) > create mode 100644 Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dec > create mode 100644 Silicon/NXP/LS1046A/LS1046A.dec > create mode 100644 Silicon/NXP/LS1046A/LS1046A.dsc.inc > create mode 100644 Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc > create mode 100644 Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf > create mode 100644 Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > create mode 100644 Silicon/NXP/LS1046A/Library/SocLib/SocLib.inf > create mode 100644 Silicon/NXP/LS1046A/Include/Soc.h > create mode 100644 Silicon/NXP/LS1046A/Include/SocSerDes.h > create mode 100644 Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c > create mode 100644 Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c > create mode 100644 Silicon/NXP/LS1046A/Library/SocLib/SerDes.c > create mode 100644 Silicon/NXP/LS1046A/Library/SocLib/SocLib.c > create mode 100644 Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/AArch64/ArmPlatformHelper.S > create mode 100644 Platform/NXP/LS1046aFrwyPkg/VarStore.fdf.inc > > -- > 2.17.1 >