From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com []) by mx.groups.io with SMTP id smtpd.web11.2047.1594433352364265985 for ; Fri, 10 Jul 2020 19:09:14 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: michael.d.kinney@intel.com) IronPort-SDR: 9FgPhuQLSKxVXNVsJqvf7cgmFTWLhRfQ1VshzGyOfh8sl5EnwwjTFUYbnOS1+DtrLgeD9vvrno aJruFyhQhXTA== X-IronPort-AV: E=McAfee;i="6000,8403,9678"; a="146380577" X-IronPort-AV: E=Sophos;i="5.75,337,1589266800"; d="scan'208";a="146380577" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2020 19:09:14 -0700 IronPort-SDR: W/uS2vdQTqw3yvoRhlv9Nym/EOPduMcvpbMj6Vjk++UWevUNVjdNnzV6jaMgewkUy3ua/U3KGw RanYcaMqEa7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,337,1589266800"; d="scan'208";a="298602325" Received: from mdkinney-mobl2.amr.corp.intel.com ([10.254.75.186]) by orsmga002.jf.intel.com with ESMTP; 10 Jul 2020 19:09:14 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Liming Gao Subject: [Patch v3 15/16] MdePkg/Library/BaseStackCheckLib: Fix PCD type in INF Date: Fri, 10 Jul 2020 19:09:03 -0700 Message-Id: <20200711020904.24116-16-michael.d.kinney@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200711020904.24116-1-michael.d.kinney@intel.com> References: <20200711020904.24116-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Update INF file to use a [Pcd] section instead of a [FixedPcd] section. [FixedPcd] should only be used in an INF file if the source code looks up the PCD value using the PcdLib FixedPcdGetxx() services. Using [FixedPcd] forces a platform to configure the PCD to type FixedAtBuild. In this case, PcdDebugPropertyMask supports PCD types FixedAtBuild and PatchableInModule. Without this change any platform that wants to use PcdDebugPropertyMask as type PatchableInModule breaks the build. Cc: Liming Gao Signed-off-by: Michael D Kinney Reviewed-by: Liming Gao --- MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf index 4ae3bd1a82..0dc3c4a83a 100644 --- a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf +++ b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf @@ -36,5 +36,5 @@ [LibraryClasses] BaseLib DebugLib -[FixedPcd] +[Pcd] gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask ## CONSUMES -- 2.21.0.windows.1