From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.52]) by mx.groups.io with SMTP id smtpd.web10.6638.1594549966921827238 for ; Sun, 12 Jul 2020 03:32:47 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Ba758mUT; spf=pass (domain: arm.com, ip: 40.107.7.52, mailfrom: tomas.pilar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yk/kgkggUjBcxBoUTpE8hdeJJcbmBejhBmZNw/FJ0Ro=; b=Ba758mUTw9bxp/B83HPy85COm7zrqV3fNdhL89k5TlYgH3hHCtZlqHyc8LE/pZxWv3DSJCG8saY9N+d/aoyyZcSMF9S7a7lOaFQYqZGDEdMU9wOmvjVx7kFa+y+FQ2clDjvAY3WQiJ6i7CKFD543LqVomVD3JI3NS2Q8QyBEkWc= Received: from MR2P264CA0003.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::15) by AM5PR0801MB1745.eurprd08.prod.outlook.com (2603:10a6:203:3a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.24; Sun, 12 Jul 2020 10:32:42 +0000 Received: from VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:1:cafe::47) by MR2P264CA0003.outlook.office365.com (2603:10a6:500:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20 via Frontend Transport; Sun, 12 Jul 2020 10:32:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT020.mail.protection.outlook.com (10.152.18.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Sun, 12 Jul 2020 10:32:42 +0000 Received: ("Tessian outbound 1dc58800d5dd:v62"); Sun, 12 Jul 2020 10:32:41 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7dffad7301a56769 X-CR-MTA-TID: 64aa7808 Received: from 0485141b5a04.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 21750FC6-4395-4AB8-BC6D-4FB03A818E33.1; Sun, 12 Jul 2020 10:32:36 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0485141b5a04.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 12 Jul 2020 10:32:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VlZmmozbJnRGBSD1ljrEfjqZHCergHaxeC5pTWrOCqy67OApxunOJE9SiPUd8UvdG8fJDT4Gc4t+tvWMBGtI+W7l2jZuOwmt4Rymc9whVY2ayOSNu7xmsLg4ukHsM9t9/wddw9q1YbHlY5hAGI10LzW88tSb9cub5Qy4P3+R3b1evUidGb1B2UGcmMOloS/yi6kSu/lzDmP4AXCt76td7HZ9V7y/MHeISV2Lt+OPpzLAhlR1QGdriRynkKOMiPBRh1vpk9khaFeeYouTKHjJEQ/rcQNr9kOoG8cZ+eG03kQ2ftaB8PWLnfdvzA0qxqijXeAOQE2nPhe+hk7hOWiVyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yk/kgkggUjBcxBoUTpE8hdeJJcbmBejhBmZNw/FJ0Ro=; b=LSfOeXR+w/+5FUwqrf/d6GL/6e6TEmgBsQwkdm94bfUVVVxo1Bpzqm+qPPOdq7wEPDT2kMbUspwKhz/G0W8Y+D5Ew++htUvI6sVpT7v+Jrhb7fAUOu9KgP5J6XlpQgOqLsrvKhV9S1IsBytDTtkqi1mQaEsEXR8sYEdaPRGKlrMRM2y/vYkhNVc/wLqMlOjruaHX7q4XHqJJ6sVLGZe2DT/tMP1n/TiEOaXz7/BFHmfkQoEql+Id4zY9fkZnfIqAxOq/ZLPNZ6LRhIknh4PafNGRvDhDjqPgsUxi6v29h1LDuHdGndJKFJgkwwgPBDSq1pwBAeg4rq2OWf//n8sM3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yk/kgkggUjBcxBoUTpE8hdeJJcbmBejhBmZNw/FJ0Ro=; b=Ba758mUTw9bxp/B83HPy85COm7zrqV3fNdhL89k5TlYgH3hHCtZlqHyc8LE/pZxWv3DSJCG8saY9N+d/aoyyZcSMF9S7a7lOaFQYqZGDEdMU9wOmvjVx7kFa+y+FQ2clDjvAY3WQiJ6i7CKFD543LqVomVD3JI3NS2Q8QyBEkWc= Received: from DBBPR09CA0012.eurprd09.prod.outlook.com (2603:10a6:10:c0::24) by DB7PR08MB3372.eurprd08.prod.outlook.com (2603:10a6:10:4f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Sun, 12 Jul 2020 10:32:33 +0000 Received: from DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::51) by DBBPR09CA0012.outlook.office365.com (2603:10a6:10:c0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Sun, 12 Jul 2020 10:32:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT008.mail.protection.outlook.com (10.152.20.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3174.21 via Frontend Transport; Sun, 12 Jul 2020 10:32:33 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 12 Jul 2020 10:32:32 +0000 Received: from localhost.localdomain (10.57.55.192) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 12 Jul 2020 10:32:31 +0000 From: "Tomas Pilar (tpilar)" To: CC: , , Ray Ni , "Zhichao Gao" Subject: [PATCH v2 8/8] ShellPkg/AcpiView: Refactor table parsers Date: Sun, 12 Jul 2020 11:32:15 +0100 Message-ID: <20200712103215.855-9-Tomas.Pilar@arm.com> X-Mailer: git-send-email 2.24.1.windows.2 In-Reply-To: <20200712103215.855-1-Tomas.Pilar@arm.com> References: <20200712103215.855-1-Tomas.Pilar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(4636009)(346002)(396003)(376002)(136003)(39850400004)(46966005)(70206006)(70586007)(316002)(6916009)(26005)(2906002)(36756003)(426003)(186003)(19627235002)(2616005)(336012)(6666004)(47076004)(82740400003)(8936002)(5660300002)(30864003)(8676002)(86362001)(81166007)(82310400002)(4326008)(83380400001)(478600001)(54906003)(1076003)(356005)(579004)(559001);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 911ceaa2-add5-4d21-f83b-08d8264ee86b X-MS-TrafficTypeDiagnostic: DB7PR08MB3372:|AM5PR0801MB1745: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ML2wVozpdwiSe7ScSbcGf9Z6sfVwZvSwwS9eZ91VkcNFEnMiSvSw1+M6ZqmbnbTDoxlqB0GcDe9lRi1LaAmNFcv8VeGeo/4o9T4z0bm2y8+Ju0DzuvFfvYp9gkwnAuwnOjHFWW0RVwx7Cqj5gvfwMgpxrd2RCmsI3AJwYbwLqudZAUWTHV7glFYe+hZtmKpKHk8lZHFi1CQD4q6CMI/L2F5XlQ9Pgjo37VtvjD7/ilN1GFT4VrhQrzmEwhcih8V208eUh9ORthUAVapJhwzylYyQqAVfnOEG9Gib2PILf4C1dI8yV1ctZ62TSb8s86BZ9G50H2xQt8ASaPR4cqSG7J2TC+auZmSiyhJd66v2s6qEeVBGdw7YL0zwpzVyzAZKb2K9q7Cfq+eIkGSST49sjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3372 Return-Path: Tomas.Pilar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39850400004)(376002)(346002)(396003)(46966005)(47076004)(82740400003)(86362001)(30864003)(1076003)(6666004)(70586007)(70206006)(5660300002)(316002)(36906005)(54906003)(478600001)(26005)(6916009)(8676002)(8936002)(36756003)(81166007)(19627235002)(336012)(107886003)(4326008)(83380400001)(2616005)(426003)(186003)(2906002)(82310400002)(579004)(559001);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 80a32c6b-4d23-4b72-c620-08d8264ee31a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FRJLFOL4OGKl62N7/7JtVzu9X+VbN5QhfZcMaZz0D+h09HYjcm3zDRTu5CxB/xjtbmcJNe8gMHEGPAaRmSRUwTjaiwnltcmicLvyBJvLQhQljKJWM/rwY2m2/DvTmrKGgIlRKxxDHSEK1upNRmn7+eTKtDeIas4JfCloVl0I61gAqDdEtIhFvauqNF5W89dgIn4IwTc01U+QjLcTcLBonIf5N1SniyV7ZU0Io66WTQQdveyTQXn7fhc28PFQFEvDq92em6tinR1HecYaTkxaiqIlJwJyW2MHDPspV3rMvvFEXGbtg7YREmbvaT+0oLQCP1nwamsi4yg8cGTvK+1mPX/OZXEBVje59H8ep8IkwSL3d/L/qRUnsJgcwCNUqiPGGqJyipXPvwKrjxZrjbzQyA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2020 10:32:42.0180 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 911ceaa2-add5-4d21-f83b-08d8264ee86b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1745 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain The tests for checking specific constraints and checking for buffer overflows have been simplified to use a standard set of templates defined in the logging facility. This regularises some of the error handling and makes it easier to write more tests like this in the future. Change-Id: Ica35c9ca1d9ef155927a4be3f16418f6755be8e6 Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Tomas Pilar --- .../UefiShellAcpiViewCommandLib/AcpiParser.c | 25 -- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 18 -- .../Arm/SbbrValidator.c | 65 +++--- .../Parsers/Dbg2/Dbg2Parser.c | 118 +++------- .../Parsers/Fadt/FadtParser.c | 54 ++--- .../Parsers/Gtdt/GtdtParser.c | 80 ++----- .../Parsers/Iort/IortParser.c | 213 +++++++----------- .../Parsers/Madt/MadtParser.c | 101 +++------ .../Parsers/Mcfg/McfgParser.c | 11 +- .../Parsers/Pptt/PpttParser.c | 165 ++++---------- .../Parsers/Rsdp/RsdpParser.c | 38 +--- .../Parsers/Slit/SlitParser.c | 124 ++++------ .../Parsers/Spcr/SpcrParser.c | 23 +- .../Parsers/Srat/SratParser.c | 188 +++++----------- .../Parsers/Xsdt/XsdtParser.c | 96 ++------ 15 files changed, 398 insertions(+), 921 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index 16b8d1f80bc2..1c8664910515 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -25,31 +25,6 @@ STATIC CONST ACPI_PARSER AcpiHeaderParser[] =3D { PARSE_ACPI_HEADER (&AcpiHdrInfo) }; =20 -/** - This function increments the ACPI table error counter. -**/ -VOID -EFIAPI -IncrementErrorCount ( - VOID - ) -{ - mTableErrorCount++; -} - -/** - This function increments the ACPI table warning counter. -**/ -VOID -EFIAPI -IncrementWarningCount ( - VOID - ) -{ - mTableWarningCount++; -} - - /** This function verifies the ACPI table checksum. =20 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h index bd3cdb774fb5..cdae433fef3b 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h @@ -18,24 +18,6 @@ /// that allows us to process the log options. #define RSDP_TABLE_INFO SIGNATURE_32('R', 'S', 'D', 'P') =20 -/** - This function increments the ACPI table error counter. -**/ -VOID -EFIAPI -IncrementErrorCount ( - VOID - ); - -/** - This function increments the ACPI table warning counter. -**/ -VOID -EFIAPI -IncrementWarningCount ( - VOID - ); - /** This function verifies the ACPI table checksum. =20 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator= .c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c index d3284417fa5f..ba80a5ab3b40 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c @@ -18,15 +18,16 @@ #include #include #include "AcpiParser.h" +#include "AcpiViewLog.h" #include "Arm/SbbrValidator.h" =20 /** SBBR specification version strings **/ -STATIC CONST CHAR8* ArmSbbrVersions[ArmSbbrVersionMax] =3D { - "1.0", // ArmSbbrVersion_1_0 - "1.1", // ArmSbbrVersion_1_1 - "1.2" // ArmSbbrVersion_1_2 +STATIC CONST CHAR16* ArmSbbrVersions[ArmSbbrVersionMax] =3D { + L"SBBR-v1.0", // ArmSbbrVersion_1_0 + L"SBBR-v1.1", // ArmSbbrVersion_1_1 + L"SBBR-v1.2" // ArmSbbrVersion_1_2 }; =20 /** @@ -96,6 +97,16 @@ STATIC ACPI_TABLE_COUNTER ArmSbbrTableCounts[] =3D { {EFI_ACPI_6_3_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_STRUCTURE_SIGNATURE, 0= } }; =20 +STATIC_ASSERT ( + ARRAY_SIZE (ArmSbbr10Mandatory) <=3D ARRAY_SIZE (ArmSbbrTableCounts), + "Incompatible mandatory array tables"); +STATIC_ASSERT ( + ARRAY_SIZE (ArmSbbr11Mandatory) <=3D ARRAY_SIZE (ArmSbbrTableCounts), + "Incompatible mandatory array tables"); +STATIC_ASSERT ( + ARRAY_SIZE (ArmSbbr12Mandatory) <=3D ARRAY_SIZE (ArmSbbrTableCounts), + "Incompatible mandatory array tables"); + /** Reset the platform ACPI table instance count for all SBBR-mandatory tabl= es. **/ @@ -160,7 +171,6 @@ ArmSbbrReqsValidate ( UINT32 Table; UINT32 Index; UINT32 MandatoryTable; - CONST UINT8* SignaturePtr; BOOLEAN IsArmSbbrViolated; =20 if (Version >=3D ArmSbbrVersionMax) { @@ -172,51 +182,30 @@ ArmSbbrReqsValidate ( // Go through the list of mandatory tables for the input SBBR version for (Table =3D 0; Table < ArmSbbrReqs[Version].TableCount; Table++) { MandatoryTable =3D ArmSbbrReqs[Version].Tables[Table]; - SignaturePtr =3D (CONST UINT8*)(UINTN)&MandatoryTable; =20 // Locate the instance count for the table with the given signature - Index =3D 0; - while ((Index < ARRAY_SIZE (ArmSbbrTableCounts)) && - (ArmSbbrTableCounts[Index].Signature !=3D MandatoryTable)) { - Index++; - } - - if (Index >=3D ARRAY_SIZE (ArmSbbrTableCounts)) { - IncrementErrorCount (); - Print ( - L"\nERROR: SBBR v%a: Mandatory %c%c%c%c table's instance count not= " \ - L"found\n", - ArmSbbrVersions[Version], - SignaturePtr[0], - SignaturePtr[1], - SignaturePtr[2], - SignaturePtr[3] - ); - return EFI_UNSUPPORTED; + for (Index =3D 0; Index < ARRAY_SIZE (ArmSbbrTableCounts); Index++) { + if (ArmSbbrTableCounts[Index].Signature =3D=3D MandatoryTable) { + break; + } } =20 if (ArmSbbrTableCounts[Index].Count =3D=3D 0) { IsArmSbbrViolated =3D TRUE; - IncrementErrorCount (); - Print ( - L"\nERROR: SBBR v%a: Mandatory %c%c%c%c table is missing", + AcpiError ( + ACPI_ERROR_CROSS, + L"(%a) Mandatory %4a table is missing", ArmSbbrVersions[Version], - SignaturePtr[0], - SignaturePtr[1], - SignaturePtr[2], - SignaturePtr[3] - ); + MandatoryTable); } } =20 if (!IsArmSbbrViolated) { - Print ( - L"\nINFO: SBBR v%a: All mandatory ACPI tables are installed", - ArmSbbrVersions[Version] - ); + AcpiLog ( + ACPI_GOOD, + L"(%a): Mandatory ACPI tables present", + ArmSbbrVersions[Version]); } =20 - Print (L"\n"); - return IsArmSbbrViolated ? EFI_NOT_FOUND : EFI_SUCCESS; } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Pa= rser.c index dd69ed6992ba..933ad92312e1 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.= c @@ -10,6 +10,7 @@ =20 #include #include +#include #include "AcpiParser.h" #include "AcpiTableParser.h" #include "AcpiViewLog.h" @@ -42,17 +43,10 @@ ValidateNameSpaceStrLen ( IN VOID* Context ) { - UINT16 NameSpaceStrLen; + UINT16 NameSpaceStrLen =3D *(UINT16 *) Ptr; =20 - NameSpaceStrLen =3D *(UINT16*)Ptr; - - if (NameSpaceStrLen < 2) { - IncrementErrorCount (); - Print ( - L"\nERROR: NamespaceString Length =3D %d. If no Namespace device exi= sts, " \ - L"NamespaceString[] must contain a period '.'", - NameSpaceStrLen - ); + if (AssertConstraint (L"ACPI", NameSpaceStrLen > 1)) { + AcpiInfo (L"With no namespace, NamespaceString[] must be a period '.'"= ); } } =20 @@ -133,76 +127,51 @@ DumpDbgDeviceInfo ( (OEMDataOffset =3D=3D NULL) || (BaseAddrRegOffset =3D=3D NULL) || (AddrSizeOffset =3D=3D NULL)) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient Debug Device Information Structure length. " \ - L"Length =3D %d.\n", - Length - ); + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse DbgDevInfo Structure"); return; } =20 // GAS - Index =3D 0; Offset =3D *BaseAddrRegOffset; - while ((Index++ < *GasCount) && - (Offset < Length)) { - PrintFieldName (4, L"BaseAddressRegister"); - Offset +=3D (UINT16)DumpGasStruct ( - Ptr + Offset, - 4, - Length - Offset - ); + for (Index =3D 0; Index < *GasCount; Index++) { + if (AssertMemberIntegrity (Offset, 1, Ptr, Length)) { + break; + } + + PrintFieldName (4, L"BaseAddressRegister[%d]", Index); + Offset +=3D (UINT16)DumpGasStruct (Ptr + Offset, 4, Length - Offset); } =20 // Make sure the array of address sizes corresponding to each GAS fit in= the // Debug Device Information structure - if ((*AddrSizeOffset + (*GasCount * sizeof (UINT32))) > Length) { - IncrementErrorCount (); - Print ( - L"ERROR: Invalid GAS count. GasCount =3D %d. RemainingBufferLength = =3D %d. " \ - L"Parsing of the Debug Device Information structure aborted.\n", - *GasCount, - Length - *AddrSizeOffset - ); + if (AssertMemberIntegrity ( + *AddrSizeOffset, *GasCount * sizeof (UINT32), Ptr, Length)) { return; } =20 // Address Size Index =3D 0; Offset =3D *AddrSizeOffset; - while ((Index++ < *GasCount) && - (Offset < Length)) { - PrintFieldName (4, L"Address Size"); - Print (L"0x%x\n", *((UINT32*)(Ptr + Offset))); + for (Index =3D 0; Index < *GasCount; Index++) { + if (AssertMemberIntegrity (Offset, 1, Ptr, Length)) { + break; + } + PrintFieldName (4, L"Address Size[%d]", Index); + AcpiInfo (L"0x%x", ReadUnaligned32 ((CONST UINT32 *)(Ptr + Offset))); Offset +=3D sizeof (UINT32); } =20 // NameSpace String - Index =3D 0; - Offset =3D *NameSpaceStringOffset; PrintFieldName (4, L"NameSpace String"); - while ((Index++ < *NameSpaceStringLength) && - (Offset < Length)) { - Print (L"%c", *(Ptr + Offset)); - Offset++; + if (!AssertMemberIntegrity ( + *NameSpaceStringOffset, *NameSpaceStringLength, Ptr, Length)) { + AcpiInfo (L"%-.*a", *NameSpaceStringLength - 1, Ptr + *NameSpaceString= Offset); } - Print (L"\n"); =20 // OEM Data if (*OEMDataOffset !=3D 0) { - Index =3D 0; - Offset =3D *OEMDataOffset; - PrintFieldName (4, L"OEM Data"); - while ((Index++ < *OEMDataLength) && - (Offset < Length)) { - Print (L"%x ", *(Ptr + Offset)); - if ((Index & 7) =3D=3D 0) { - Print (L"\n%-*s ", OUTPUT_FIELD_COLUMN_WIDTH, L""); - } - Offset++; - } - Print (L"\n"); + AcpiInfo (L"OEM Data"); + DumpRaw (Ptr + *OEMDataOffset, *OEMDataLength); } } =20 @@ -245,13 +214,8 @@ ParseAcpiDbg2 ( =20 // Check if the values used to control the parsing logic have been // successfully read. - if ((OffsetDbgDeviceInfo =3D=3D NULL) || - (NumberDbgDeviceInfo =3D=3D NULL)) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient table length. AcpiTableLength =3D %d\n", - AcpiTableLength - ); + if ((OffsetDbgDeviceInfo =3D=3D NULL) || (NumberDbgDeviceInfo =3D=3D NUL= L)) { + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse DbgDevInfo array"); return; } =20 @@ -259,7 +223,6 @@ ParseAcpiDbg2 ( Index =3D 0; =20 while (Index++ < *NumberDbgDeviceInfo) { - // Parse the Debug Device Information Structure header to obtain Lengt= h ParseAcpi ( FALSE, @@ -273,31 +236,20 @@ ParseAcpiDbg2 ( // Check if the values used to control the parsing logic have been // successfully read. if (DbgDevInfoLen =3D=3D NULL) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient remaining table buffer length to read the " = \ - L"Debug Device Information structure's 'Length' field. " \ - L"RemainingTableBufferLength =3D %d.\n", - AcpiTableLength - Offset - ); + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse DbgDevInfoLen"); return; } =20 // Validate Debug Device Information Structure length - if ((*DbgDevInfoLen =3D=3D 0) || - ((Offset + (*DbgDevInfoLen)) > AcpiTableLength)) { - IncrementErrorCount (); - Print ( - L"ERROR: Invalid Debug Device Information Structure length. " \ - L"Length =3D %d. Offset =3D %d. AcpiTableLength =3D %d.\n", - *DbgDevInfoLen, - Offset, - AcpiTableLength - ); + if (AssertConstraint (L"ACPI", *DbgDevInfoLen > 0)) { + return; + } + + if (AssertMemberIntegrity (Offset, *DbgDevInfoLen, Ptr, AcpiTableLengt= h)) { return; } =20 - DumpDbgDeviceInfo (Ptr + Offset, (*DbgDevInfoLen)); - Offset +=3D (*DbgDevInfoLen); + DumpDbgDeviceInfo (Ptr + Offset, *DbgDevInfoLen); + Offset +=3D *DbgDevInfoLen; } } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/Fadt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPa= rser.c index 4734864dfdcf..473495651370 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.= c @@ -69,12 +69,10 @@ ValidateFirmwareCtrl ( ) { #if defined (MDE_CPU_ARM) || defined (MDE_CPU_AARCH64) - if (*(UINT32*)Ptr !=3D 0) { - IncrementErrorCount (); - Print ( - L"\nERROR: Firmware Control must be zero for ARM platforms." - ); - } + UINT32 FirmwareControl; + + FirmwareControl =3D *(UINT32 *) Ptr; + AssertConstraint (L"ARM", FirmwareControl =3D=3D 0); #endif } =20 @@ -94,12 +92,10 @@ ValidateXFirmwareCtrl ( ) { #if defined (MDE_CPU_ARM) || defined (MDE_CPU_AARCH64) - if (*(UINT64*)Ptr !=3D 0) { - IncrementErrorCount (); - Print ( - L"\nERROR: X Firmware Control must be zero for ARM platforms." - ); - } + UINT32 XFirmwareControl; + + XFirmwareControl =3D *(UINT32 *) Ptr; + AssertConstraint (L"ARM", XFirmwareControl =3D=3D 0); #endif } =20 @@ -119,12 +115,10 @@ ValidateFlags ( ) { #if defined (MDE_CPU_ARM) || defined (MDE_CPU_AARCH64) - if (((*(UINT32*)Ptr) & HW_REDUCED_ACPI) =3D=3D 0) { - IncrementErrorCount (); - Print ( - L"\nERROR: HW_REDUCED_ACPI flag must be set for ARM platforms." - ); - } + UINT32 Flags; + + Flags =3D *(UINT32 *) Ptr; + AssertConstraint (L"ARM", Flags & HW_REDUCED_ACPI); #endif } =20 @@ -232,15 +226,13 @@ ParseAcpiFadt ( =20 if (Trace) { if (FadtMinorRevision !=3D NULL) { - Print (L"\nSummary:\n"); + AcpiInfo (L"Summary:"); PrintFieldName (2, L"FADT Version"); - Print (L"%d.%d\n", *AcpiHdrInfo.Revision, *FadtMinorRevision); + AcpiInfo (L"%d.%d", *AcpiHdrInfo.Revision, *FadtMinorRevision); } =20 - if (*GetAcpiXsdtHeaderInfo ()->OemTableId !=3D *AcpiHdrInfo.OemTableId= ) { - IncrementErrorCount (); - Print (L"ERROR: OEM Table Id does not match with RSDT/XSDT.\n"); - } + AssertConstraint ( + L"ACPI", *GetAcpiXsdtHeaderInfo ()->OemTableId =3D=3D *AcpiHdrInfo.O= emTableId); } =20 // If X_FIRMWARE_CTRL is not zero then use X_FIRMWARE_CTRL and ignore @@ -257,9 +249,9 @@ ParseAcpiFadt ( if ((Trace) && (Flags !=3D NULL) && ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D EFI_ACPI_6_3_HW_REDU= CED_ACPI)) { - IncrementErrorCount (); - Print (L"ERROR: No FACS table found, " - L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are zero.\n"); + AcpiError ( + ACPI_ERROR_CROSS, + L"No FACS table found, X_FIRMWARE_CTRL and FIRMWARE_CTRL are zero"= ); } } =20 @@ -283,9 +275,7 @@ ParseAcpiFadt ( =20 Status =3D GetParser (FacsSignature, &FacsParserProc); if (EFI_ERROR (Status)) { - Print ( - L"ERROR: No registered parser found for FACS.\n" - ); + AcpiFatal (L"No registered parser found for FACS"); return; } =20 @@ -309,8 +299,8 @@ ParseAcpiFadt ( // The DSDT Table is mandatory for ARM systems // as the CPU information MUST be presented in // the DSDT. - IncrementErrorCount (); - Print (L"ERROR: Both X_DSDT and DSDT are invalid.\n"); + AcpiError ( + ACPI_ERROR_CROSS, L"(ARM) One of X_DSDT or DSDT must be valid!"); } #endif return; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/Gtdt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPa= rser.c index d02fc4929d6f..3716a801cf6a 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.= c @@ -13,6 +13,7 @@ #include "AcpiParser.h" #include "AcpiTableParser.h" #include "AcpiViewConfig.h" +#include "AcpiViewLog.h" =20 // "The number of GT Block Timers must be less than or equal to 8" #define GT_BLOCK_TIMER_COUNT_MAX 8 @@ -44,15 +45,7 @@ ValidateGtBlockTimerCount ( UINT32 BlockTimerCount; =20 BlockTimerCount =3D *(UINT32*)Ptr; - - if (BlockTimerCount > GT_BLOCK_TIMER_COUNT_MAX) { - IncrementErrorCount (); - Print ( - L"\nERROR: Timer Count =3D %d. Max Timer Count is %d.", - BlockTimerCount, - GT_BLOCK_TIMER_COUNT_MAX - ); - } + AssertConstraint (L"ACPI", BlockTimerCount < GT_BLOCK_TIMER_COUNT_MAX); } =20 /** @@ -70,18 +63,10 @@ ValidateGtFrameNumber ( IN VOID* Context ) { - UINT8 FrameNumber; + UINT8 GTFrameNumber; =20 - FrameNumber =3D *(UINT8*)Ptr; - - if (FrameNumber >=3D GT_BLOCK_TIMER_COUNT_MAX) { - IncrementErrorCount (); - Print ( - L"\nERROR: GT Frame Number =3D %d. GT Frame Number must be in range = 0-%d.", - FrameNumber, - GT_BLOCK_TIMER_COUNT_MAX - 1 - ); - } + GTFrameNumber =3D *Ptr; + AssertConstraint (L"ACPI", GTFrameNumber < GT_BLOCK_TIMER_COUNT_MAX); } =20 /** @@ -194,11 +179,7 @@ DumpGTBlock ( // successfully read. if ((GtBlockTimerCount =3D=3D NULL) || (GtBlockTimerOffset =3D=3D NULL)) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient GT Block Structure length. Length =3D %d.\n", - Length - ); + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse GT Block Structure"); return; } =20 @@ -270,7 +251,6 @@ ParseAcpiGtdt ( { UINT32 Index; UINT32 Offset; - UINT8* TimerPtr; =20 if (!Trace) { return; @@ -287,17 +267,11 @@ ParseAcpiGtdt ( =20 // Check if the values used to control the parsing logic have been // successfully read. - if ((GtdtPlatformTimerCount =3D=3D NULL) || - (GtdtPlatformTimerOffset =3D=3D NULL)) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient table length. AcpiTableLength =3D %d.\n", - AcpiTableLength - ); + if ((GtdtPlatformTimerCount =3D=3D NULL) || (GtdtPlatformTimerOffset =3D= =3D NULL)) { + AcpiError (ACPI_ERROR_PARSE, L"Corrupt Platform Timer Table"); return; } =20 - TimerPtr =3D Ptr + *GtdtPlatformTimerOffset; Offset =3D *GtdtPlatformTimerOffset; Index =3D 0; =20 @@ -310,55 +284,35 @@ ParseAcpiGtdt ( FALSE, 0, NULL, - TimerPtr, + Ptr + Offset, AcpiTableLength - Offset, PARSER_PARAMS (GtPlatformTimerHeaderParser) ); =20 // Check if the values used to control the parsing logic have been // successfully read. - if ((PlatformTimerType =3D=3D NULL) || - (PlatformTimerLength =3D=3D NULL)) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient remaining table buffer length to read the " = \ - L"Platform Timer Structure header. Length =3D %d.\n", - AcpiTableLength - Offset - ); + if ((PlatformTimerType =3D=3D NULL) || (PlatformTimerLength =3D=3D NUL= L)) { + AcpiError (ACPI_ERROR_PARSE, L"Corrupt Platform Timer Structure"); return; } =20 // Validate Platform Timer Structure length - if ((*PlatformTimerLength =3D=3D 0) || - ((Offset + (*PlatformTimerLength)) > AcpiTableLength)) { - IncrementErrorCount (); - Print ( - L"ERROR: Invalid Platform Timer Structure length. " \ - L"Length =3D %d. Offset =3D %d. AcpiTableLength =3D %d.\n", - *PlatformTimerLength, - Offset, - AcpiTableLength - ); + if (AssertMemberIntegrity(Offset, *PlatformTimerLength, Ptr, AcpiTable= Length)) { return; } =20 switch (*PlatformTimerType) { case EFI_ACPI_6_3_GTDT_GT_BLOCK: - DumpGTBlock (TimerPtr, *PlatformTimerLength); + DumpGTBlock (Ptr + Offset, *PlatformTimerLength); break; case EFI_ACPI_6_3_GTDT_SBSA_GENERIC_WATCHDOG: - DumpWatchdogTimer (TimerPtr, *PlatformTimerLength); + DumpWatchdogTimer (Ptr + Offset, *PlatformTimerLength); break; default: - IncrementErrorCount (); - Print ( - L"ERROR: Invalid Platform Timer Type =3D %d\n", - *PlatformTimerType - ); - break; - } // switch + AcpiError ( + ACPI_ERROR_VALUE, L"Platform Timer Type %d", *PlatformTimerType)= ; + } =20 - TimerPtr +=3D *PlatformTimerLength; Offset +=3D *PlatformTimerLength; } // while } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/Iort= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPa= rser.c index 356f355939aa..f7e9aa775301 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.= c @@ -11,6 +11,7 @@ #include #include #include +#include #include "AcpiParser.h" #include "AcpiTableParser.h" #include "AcpiViewConfig.h" @@ -49,10 +50,10 @@ ValidateItsIdMappingCount ( IN VOID* Context ) { - if (*(UINT32*)Ptr !=3D 0) { - IncrementErrorCount (); - Print (L"\nERROR: IORT ID Mapping count must be zero."); - } + UINT32 ItsNodeIdMapping; + + ItsNodeIdMapping =3D *(UINT32 *) Ptr; + AssertConstraint (L"ACPI", ItsNodeIdMapping =3D=3D 0); } =20 /** @@ -71,10 +72,10 @@ ValidatePmcgIdMappingCount ( IN VOID* Context ) { - if (*(UINT32*)Ptr > 1) { - IncrementErrorCount (); - Print (L"\nERROR: IORT ID Mapping count must not be greater than 1."); - } + UINT32 PmcgNodeIdMapping; + + PmcgNodeIdMapping =3D *(UINT32 *) Ptr; + AssertConstraint (L"ACPI", PmcgNodeIdMapping <=3D 1); } =20 /** @@ -92,10 +93,10 @@ ValidateItsIdArrayReference ( IN VOID* Context ) { - if (*(UINT32*)Ptr !=3D 0) { - IncrementErrorCount (); - Print (L"\nERROR: IORT ID Mapping offset must be zero."); - } + UINT32 ItsNodeMappingArrayOffset; + + ItsNodeMappingArrayOffset =3D *(UINT32 *) Ptr; + AssertConstraint (L"ACPI", ItsNodeMappingArrayOffset =3D=3D 0); } =20 /** @@ -268,28 +269,21 @@ DumpIortNodeIdMappings ( { UINT32 Index; UINT32 Offset; - CHAR8 Buffer[40]; // Used for AsciiName param of ParseAcpi =20 - Index =3D 0; Offset =3D 0; + for (Index =3D 0; Index < MappingCount; Index++) { + if (AssertMemberIntegrity(Offset, 1, Ptr, Length)) { + return; + } =20 - while ((Index < MappingCount) && - (Offset < Length)) { - AsciiSPrint ( - Buffer, - sizeof (Buffer), - "ID Mapping [%d]", - Index - ); + AcpiLog (ACPI_ITEM, L" ID Mapping[%d] (+0x%x)", Index, Offset); Offset +=3D ParseAcpi ( - TRUE, - 4, - Buffer, - Ptr + Offset, - Length - Offset, - PARSER_PARAMS (IortNodeIdMappingParser) - ); - Index++; + TRUE, + 4, + NULL, + Ptr + Offset, + Length - Offset, + PARSER_PARAMS (IortNodeIdMappingParser)); } } =20 @@ -313,7 +307,6 @@ DumpIortNodeSmmuV1V2 ( { UINT32 Index; UINT32 Offset; - CHAR8 Buffer[50]; // Used for AsciiName param of ParseAcpi =20 ParseAcpi ( TRUE, @@ -330,56 +323,41 @@ DumpIortNodeSmmuV1V2 ( (InterruptContextOffset =3D=3D NULL) || (PmuInterruptCount =3D=3D NULL) || (PmuInterruptOffset =3D=3D NULL)) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient SMMUv1/2 node length. Length =3D %d\n", - Length - ); + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse the SMMUv1/2 node"); return; } =20 Offset =3D *InterruptContextOffset; - Index =3D 0; + for (Index =3D 0; Index < *InterruptContextCount; Index++) { + if (AssertMemberIntegrity(Offset, 1, Ptr, Length)) { + break; + } =20 - while ((Index < *InterruptContextCount) && - (Offset < Length)) { - AsciiSPrint ( - Buffer, - sizeof (Buffer), - "Context Interrupts Array [%d]", - Index - ); + AcpiLog ( + ACPI_ITEM, L" Context Interrupts Array[%d] (+0x%x)", Index, Offse= t); Offset +=3D ParseAcpi ( - TRUE, - 4, - Buffer, - Ptr + Offset, - Length - Offset, - PARSER_PARAMS (InterruptArrayParser) - ); - Index++; + TRUE, + 4, + NULL, + Ptr + Offset, + Length - Offset, + PARSER_PARAMS (InterruptArrayParser)); } =20 Offset =3D *PmuInterruptOffset; - Index =3D 0; + for(Index =3D 0; Index < *PmuInterruptCount; Index++) { + if (AssertMemberIntegrity(Offset, 1, Ptr, Length)){ + break; + } =20 - while ((Index < *PmuInterruptCount) && - (Offset < Length)) { - AsciiSPrint ( - Buffer, - sizeof (Buffer), - "PMU Interrupts Array [%d]", - Index - ); + AcpiLog (ACPI_ITEM, L" PMU Interrupts Array[%d] (+0x%x)", Index, Of= fset); Offset +=3D ParseAcpi ( - TRUE, - 4, - Buffer, - Ptr + Offset, - Length - Offset, - PARSER_PARAMS (InterruptArrayParser) - ); - Index++; + TRUE, + 4, + NULL, + Ptr + Offset, + Length - Offset, + PARSER_PARAMS (InterruptArrayParser)); } =20 DumpIortNodeIdMappings ( @@ -438,7 +416,6 @@ DumpIortNodeIts ( { UINT32 Offset; UINT32 Index; - CHAR8 Buffer[80]; // Used for AsciiName param of ParseAcpi =20 Offset =3D ParseAcpi ( TRUE, @@ -452,32 +429,26 @@ DumpIortNodeIts ( // Check if the values used to control the parsing logic have been // successfully read. if (ItsCount =3D=3D NULL) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient ITS group length. Length =3D %d.\n", - Length - ); + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse ITS node"); return; } =20 Index =3D 0; =20 - while ((Index < *ItsCount) && - (Offset < Length)) { - AsciiSPrint ( - Buffer, - sizeof (Buffer), - "GIC ITS Identifier Array [%d]", - Index - ); + for (Index =3D 0; Index < *ItsCount; Index++) { + if (AssertMemberIntegrity(Offset, 1, Ptr, Length)) { + return; + } + + AcpiLog ( + ACPI_ITEM, L" GIC ITS Identifier Array[%d] (+0x%x)", Index, Offse= t); Offset +=3D ParseAcpi ( - TRUE, - 4, - Buffer, - Ptr + Offset, - Length - Offset, - PARSER_PARAMS (ItsIdParser) - ); + TRUE, + 4, + NULL, + Ptr + Offset, + Length - Offset, + PARSER_PARAMS (ItsIdParser)); Index++; } =20 @@ -516,13 +487,10 @@ DumpIortNodeNamedComponent ( =20 // Estimate the Device Name length PrintFieldName (2, L"Device Object Name"); - - while ((*(Ptr + Offset) !=3D 0) && - (Offset < Length)) { - Print (L"%c", *(Ptr + Offset)); - Offset++; - } - Print (L"\n"); + AcpiInfo ( + L"%.*a", + AsciiStrnLenS ((CONST CHAR8 *)Ptr + Offset, Length - Offset), + Ptr + Offset); =20 DumpIortNodeIdMappings ( Ptr + MappingOffset, @@ -629,7 +597,6 @@ ParseAcpiIort ( { UINT32 Offset; UINT32 Index; - UINT8* NodePtr; =20 if (!Trace) { return; @@ -648,16 +615,11 @@ ParseAcpiIort ( // successfully read. if ((IortNodeCount =3D=3D NULL) || (IortNodeOffset =3D=3D NULL)) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient table length. AcpiTableLength =3D %d.\n", - AcpiTableLength - ); + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse IORT Node."); return; } =20 Offset =3D *IortNodeOffset; - NodePtr =3D Ptr + Offset; Index =3D 0; =20 // Parse the specified number of IORT nodes or the IORT table buffer len= gth. @@ -669,7 +631,7 @@ ParseAcpiIort ( FALSE, 0, "IORT Node Header", - NodePtr, + Ptr + Offset, AcpiTableLength - Offset, PARSER_PARAMS (IortNodeHeaderParser) ); @@ -680,42 +642,28 @@ ParseAcpiIort ( (IortNodeLength =3D=3D NULL) || (IortIdMappingCount =3D=3D NULL) || (IortIdMappingOffset =3D=3D NULL)) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient remaining table buffer length to read the " = \ - L"IORT node header. Length =3D %d.\n", - AcpiTableLength - Offset - ); + AcpiError (ACPI_ERROR_PARSE, L"Failed ot parse the IORT node header"= ); return; } =20 - // Validate IORT Node length - if ((*IortNodeLength =3D=3D 0) || - ((Offset + (*IortNodeLength)) > AcpiTableLength)) { - IncrementErrorCount (); - Print ( - L"ERROR: Invalid IORT Node length. " \ - L"Length =3D %d. Offset =3D %d. AcpiTableLength =3D %d.\n", - *IortNodeLength, - Offset, - AcpiTableLength - ); + // Protect against buffer overrun + if (AssertMemberIntegrity (Offset, *IortNodeLength, Ptr, AcpiTableLeng= th)) { return; } =20 PrintFieldName (2, L"* Node Offset *"); - Print (L"0x%x\n", Offset); + AcpiInfo (L"0x%x", Offset); =20 switch (*IortNodeType) { case EFI_ACPI_IORT_TYPE_ITS_GROUP: DumpIortNodeIts ( - NodePtr, + Ptr + Offset, *IortNodeLength ); break; case EFI_ACPI_IORT_TYPE_NAMED_COMP: DumpIortNodeNamedComponent ( - NodePtr, + Ptr + Offset, *IortNodeLength, *IortIdMappingCount, *IortIdMappingOffset @@ -723,7 +671,7 @@ ParseAcpiIort ( break; case EFI_ACPI_IORT_TYPE_ROOT_COMPLEX: DumpIortNodeRootComplex ( - NodePtr, + Ptr + Offset, *IortNodeLength, *IortIdMappingCount, *IortIdMappingOffset @@ -731,7 +679,7 @@ ParseAcpiIort ( break; case EFI_ACPI_IORT_TYPE_SMMUv1v2: DumpIortNodeSmmuV1V2 ( - NodePtr, + Ptr + Offset, *IortNodeLength, *IortIdMappingCount, *IortIdMappingOffset @@ -739,7 +687,7 @@ ParseAcpiIort ( break; case EFI_ACPI_IORT_TYPE_SMMUv3: DumpIortNodeSmmuV3 ( - NodePtr, + Ptr + Offset, *IortNodeLength, *IortIdMappingCount, *IortIdMappingOffset @@ -747,7 +695,7 @@ ParseAcpiIort ( break; case EFI_ACPI_IORT_TYPE_PMCG: DumpIortNodePmcg ( - NodePtr, + Ptr + Offset, *IortNodeLength, *IortIdMappingCount, *IortIdMappingOffset @@ -755,11 +703,10 @@ ParseAcpiIort ( break; =20 default: - IncrementErrorCount (); - Print (L"ERROR: Unsupported IORT Node type =3D %d\n", *IortNodeTyp= e); + AcpiError ( + ACPI_ERROR_VALUE, L"Unsupported IORT Node type =3D %d", *IortNod= eType); } // switch =20 - NodePtr +=3D (*IortNodeLength); Offset +=3D (*IortNodeLength); } // while } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/Madt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPa= rser.c index 15aa2392b60c..69c1c6d752cb 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.= c @@ -17,6 +17,7 @@ #include "AcpiTableParser.h" #include "AcpiViewConfig.h" #include "MadtParser.h" +#include "AcpiViewLog.h" =20 // Local Variables STATIC CONST UINT8* MadtInterruptControllerType; @@ -38,12 +39,10 @@ ValidateGICDSystemVectorBase ( IN VOID* Context ) { - if (*(UINT32*)Ptr !=3D 0) { - IncrementErrorCount (); - Print ( - L"\nERROR: System Vector Base must be zero." - ); - } + UINT32 GicdSystemVectorBase; + + GicdSystemVectorBase =3D *(UINT32 *) Ptr; + AssertConstraint (L"ACPI", GicdSystemVectorBase =3D=3D 0); } =20 /** @@ -63,36 +62,20 @@ ValidateSpeOverflowInterrupt ( { UINT16 SpeOverflowInterrupt; =20 - SpeOverflowInterrupt =3D *(UINT16*)Ptr; + SpeOverflowInterrupt =3D *(UINT16 *) Ptr; =20 // SPE not supported by this processor if (SpeOverflowInterrupt =3D=3D 0) { return; } =20 - if ((SpeOverflowInterrupt < ARM_PPI_ID_MIN) || - ((SpeOverflowInterrupt > ARM_PPI_ID_MAX) && - (SpeOverflowInterrupt < ARM_PPI_ID_EXTENDED_MIN)) || - (SpeOverflowInterrupt > ARM_PPI_ID_EXTENDED_MAX)) { - IncrementErrorCount (); - Print ( - L"\nERROR: SPE Overflow Interrupt ID of %d is not in the allowed PPI= ID " - L"ranges of %d-%d or %d-%d (for GICv3.1 or later).", - SpeOverflowInterrupt, - ARM_PPI_ID_MIN, - ARM_PPI_ID_MAX, - ARM_PPI_ID_EXTENDED_MIN, - ARM_PPI_ID_EXTENDED_MAX - ); - } else if (SpeOverflowInterrupt !=3D ARM_PPI_ID_PMBIRQ) { - IncrementWarningCount(); - Print ( - L"\nWARNING: SPE Overflow Interrupt ID of %d is not compliant with S= BSA " - L"Level 3 PPI ID assignment: %d.", - SpeOverflowInterrupt, - ARM_PPI_ID_PMBIRQ - ); - } + AssertConstraint (L"ACPI", SpeOverflowInterrupt > ARM_PPI_ID_MIN); + AssertConstraint ( + L"ACPI", + (SpeOverflowInterrupt < ARM_PPI_ID_MAX) || + (SpeOverflowInterrupt > ARM_PPI_ID_EXTENDED_MIN)); + AssertConstraint (L"ACPI", SpeOverflowInterrupt < ARM_PPI_ID_EXTENDED_MA= X); + WarnConstraint (L"SBSA", SpeOverflowInterrupt =3D=3D ARM_PPI_ID_PMBIRQ); } =20 /** @@ -231,7 +214,6 @@ ParseAcpiMadt ( ) { UINT32 Offset; - UINT8* InterruptContollerPtr; UINT32 GICDCount; =20 GICDCount =3D 0; @@ -248,7 +230,6 @@ ParseAcpiMadt ( AcpiTableLength, PARSER_PARAMS (MadtParser) ); - InterruptContollerPtr =3D Ptr + Offset; =20 while (Offset < AcpiTableLength) { // Parse Interrupt Controller Structure to obtain Length. @@ -256,7 +237,7 @@ ParseAcpiMadt ( FALSE, 0, NULL, - InterruptContollerPtr, + Ptr + Offset, AcpiTableLength - Offset, PARSER_PARAMS (MadtInterruptControllerHeaderParser) ); @@ -265,26 +246,14 @@ ParseAcpiMadt ( // successfully read. if ((MadtInterruptControllerType =3D=3D NULL) || (MadtInterruptControllerLength =3D=3D NULL)) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient remaining table buffer length to read the " = \ - L"Interrupt Controller Structure header. Length =3D %d.\n", - AcpiTableLength - Offset - ); + AcpiError ( + ACPI_ERROR_PARSE, + L"Failed to read the Interrupt Controller Structure header"); return; } =20 - // Validate Interrupt Controller Structure length - if ((*MadtInterruptControllerLength =3D=3D 0) || - ((Offset + (*MadtInterruptControllerLength)) > AcpiTableLength)) { - IncrementErrorCount (); - Print ( - L"ERROR: Invalid Interrupt Controller Structure length. " \ - L"Length =3D %d. Offset =3D %d. AcpiTableLength =3D %d.\n", - *MadtInterruptControllerLength, - Offset, - AcpiTableLength - ); + if (AssertMemberIntegrity ( + Offset, *MadtInterruptControllerLength, Ptr, AcpiTableLength)) { return; } =20 @@ -294,7 +263,7 @@ ParseAcpiMadt ( TRUE, 2, "GICC", - InterruptContollerPtr, + Ptr + Offset, *MadtInterruptControllerLength, PARSER_PARAMS (GicCParser) ); @@ -303,18 +272,16 @@ ParseAcpiMadt ( =20 case EFI_ACPI_6_3_GICD: { if (++GICDCount > 1) { - IncrementErrorCount (); - Print ( - L"ERROR: Only one GICD must be present," - L" GICDCount =3D %d\n", - GICDCount - ); + AcpiError ( + ACPI_ERROR_CROSS, + L"Only one GICD must be present (now %d)", + GICDCount); } ParseAcpi ( TRUE, 2, "GICD", - InterruptContollerPtr, + Ptr + Offset, *MadtInterruptControllerLength, PARSER_PARAMS (GicDParser) ); @@ -326,7 +293,7 @@ ParseAcpiMadt ( TRUE, 2, "GIC MSI Frame", - InterruptContollerPtr, + Ptr + Offset, *MadtInterruptControllerLength, PARSER_PARAMS (GicMSIFrameParser) ); @@ -338,7 +305,7 @@ ParseAcpiMadt ( TRUE, 2, "GICR", - InterruptContollerPtr, + Ptr + Offset, *MadtInterruptControllerLength, PARSER_PARAMS (GicRParser) ); @@ -350,7 +317,7 @@ ParseAcpiMadt ( TRUE, 2, "GIC ITS", - InterruptContollerPtr, + Ptr + Offset, *MadtInterruptControllerLength, PARSER_PARAMS (GicITSParser) ); @@ -358,17 +325,13 @@ ParseAcpiMadt ( } =20 default: { - IncrementErrorCount (); - Print ( - L"ERROR: Unknown Interrupt Controller Structure," - L" Type =3D %d, Length =3D %d\n", - *MadtInterruptControllerType, - *MadtInterruptControllerLength - ); + AcpiError ( + ACPI_ERROR_VALUE, + L"Interrupt Controller Structure Type =3D %d", + *MadtInterruptControllerType); } } // switch =20 - InterruptContollerPtr +=3D *MadtInterruptControllerLength; Offset +=3D *MadtInterruptControllerLength; } // while } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mcfg/Mcfg= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mcfg/McfgPa= rser.c index 9da4d60e8497..7a7eaa374acf 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mcfg/McfgParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mcfg/McfgParser.= c @@ -12,6 +12,7 @@ #include #include "AcpiParser.h" #include "AcpiTableParser.h" +#include "AcpiViewLog.h" =20 // Local variables STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; @@ -57,8 +58,6 @@ ParseAcpiMcfg ( ) { UINT32 Offset; - UINT32 PciCfgOffset; - UINT8* PciCfgSpacePtr; =20 if (!Trace) { return; @@ -73,18 +72,14 @@ ParseAcpiMcfg ( PARSER_PARAMS (McfgParser) ); =20 - PciCfgSpacePtr =3D Ptr + Offset; - while (Offset < AcpiTableLength) { - PciCfgOffset =3D ParseAcpi ( + Offset +=3D ParseAcpi ( TRUE, 2, "PCI Configuration Space", - PciCfgSpacePtr, + Ptr + Offset, (AcpiTableLength - Offset), PARSER_PARAMS (PciCfgSpaceBaseAddrParser) ); - PciCfgSpacePtr +=3D PciCfgOffset; - Offset +=3D PciCfgOffset; } } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/Pptt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttPa= rser.c index 97a5203efb5f..719c9dce9d4f 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.= c @@ -14,6 +14,7 @@ #include "AcpiParser.h" #include "AcpiView.h" #include "AcpiViewConfig.h" +#include "AcpiViewLog.h" #include "PpttParser.h" #include "AcpiViewLog.h" =20 @@ -39,38 +40,21 @@ ValidateCacheNumberOfSets ( IN VOID* Context ) { - UINT32 NumberOfSets; - NumberOfSets =3D *(UINT32*)Ptr; + UINT32 CacheNumberOfSets; =20 - if (NumberOfSets =3D=3D 0) { - IncrementErrorCount (); - Print (L"\nERROR: Cache number of sets must be greater than 0"); - return; - } + CacheNumberOfSets =3D *(UINT32*) Ptr; + AssertConstraint (L"ACPI", CacheNumberOfSets !=3D 0); =20 #if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64) - if (NumberOfSets > PPTT_ARM_CCIDX_CACHE_NUMBER_OF_SETS_MAX) { - IncrementErrorCount (); - Print ( - L"\nERROR: When ARMv8.3-CCIDX is implemented the maximum cache numbe= r of " - L"sets must be less than or equal to %d", - PPTT_ARM_CCIDX_CACHE_NUMBER_OF_SETS_MAX - ); + if (AssertConstraint ( + L"ARMv8.3-CCIDX", + CacheNumberOfSets < PPTT_ARM_CCIDX_CACHE_NUMBER_OF_SETS_MAX)) { return; } =20 - if (NumberOfSets > PPTT_ARM_CACHE_NUMBER_OF_SETS_MAX) { - IncrementWarningCount (); - Print ( - L"\nWARNING: Without ARMv8.3-CCIDX, the maximum cache number of sets= " - L"must be less than or equal to %d. Ignore this message if " - L"ARMv8.3-CCIDX is implemented", - PPTT_ARM_CACHE_NUMBER_OF_SETS_MAX - ); - return; - } + WarnConstraint ( + L"No-ARMv8.3-CCIDX", CacheNumberOfSets < PPTT_ARM_CACHE_NUMBER_OF_SETS= _MAX); #endif - } =20 /** @@ -89,14 +73,10 @@ ValidateCacheAssociativity ( IN VOID* Context ) { - UINT8 Associativity; - Associativity =3D *(UINT8*)Ptr; + UINT8 CacheAssociativity; =20 - if (Associativity =3D=3D 0) { - IncrementErrorCount (); - Print (L"\nERROR: Cache associativity must be greater than 0"); - return; - } + CacheAssociativity =3D *Ptr; + AssertConstraint (L"ACPI", CacheAssociativity !=3D 0); } =20 /** @@ -120,25 +100,15 @@ ValidateCacheLineSize ( // LineSize, bits [2:0] // (Log2(Number of bytes in cache line)) - 4. =20 - UINT16 LineSize; - LineSize =3D *(UINT16*)Ptr; - - if ((LineSize < PPTT_ARM_CACHE_LINE_SIZE_MIN) || - (LineSize > PPTT_ARM_CACHE_LINE_SIZE_MAX)) { - IncrementErrorCount (); - Print ( - L"\nERROR: The cache line size must be between %d and %d bytes" - L" on ARM Platforms.", - PPTT_ARM_CACHE_LINE_SIZE_MIN, - PPTT_ARM_CACHE_LINE_SIZE_MAX - ); - return; - } + UINT16 CacheLineSize; =20 - if ((LineSize & (LineSize - 1)) !=3D 0) { - IncrementErrorCount (); - Print (L"\nERROR: The cache line size is not a power of 2."); - } + CacheLineSize =3D *(UINT16 *) Ptr; + AssertConstraint ( + L"ARM", + (CacheLineSize >=3D PPTT_ARM_CACHE_LINE_SIZE_MIN && + CacheLineSize <=3D PPTT_ARM_CACHE_LINE_SIZE_MAX)); + + AssertConstraint (L"ARM", BitFieldCountOnes32 (CacheLineSize, 0, 15) =3D= =3D 1); #endif } =20 @@ -161,16 +131,9 @@ ValidateCacheAttributes ( // Version 6.2 Errata A, September 2017 // Table 5-153: Cache Type Structure UINT8 Attributes; - Attributes =3D *(UINT8*)Ptr; =20 - if ((Attributes & 0xE0) !=3D 0) { - IncrementErrorCount (); - Print ( - L"\nERROR: Attributes bits [7:5] are reserved and must be zero.", - Attributes - ); - return; - } + Attributes =3D *(UINT8 *) Ptr; + AssertConstraint (L"ACPI", BitFieldCountOnes32 (Attributes, 5, 7) =3D=3D= 0); } =20 /** @@ -255,7 +218,6 @@ DumpProcessorHierarchyNodeStructure ( { UINT32 Offset; UINT32 Index; - CHAR16 Buffer[OUTPUT_FIELD_COLUMN_WIDTH]; =20 Offset =3D ParseAcpi ( TRUE, @@ -268,48 +230,22 @@ DumpProcessorHierarchyNodeStructure ( =20 // Check if the values used to control the parsing logic have been // successfully read. - if (NumberOfPrivateResources =3D=3D NULL) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient Processor Hierarchy Node length. Length =3D %d= .\n", - Length - ); - return; - } - - // Make sure the Private Resource array lies inside this structure - if (Offset + (*NumberOfPrivateResources * sizeof (UINT32)) > Length) { - IncrementErrorCount (); - Print ( - L"ERROR: Invalid Number of Private Resources. " \ - L"PrivateResourceCount =3D %d. RemainingBufferLength =3D %d. " \ - L"Parsing of this structure aborted.\n", - *NumberOfPrivateResources, - Length - Offset - ); + if(NumberOfPrivateResources =3D=3D NULL) { + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse processor hierarchy"); return; } =20 - Index =3D 0; - // Parse the specified number of private resource references or the Proc= essor // Hierarchy Node length. Whichever is minimum. - while (Index < *NumberOfPrivateResources) { - UnicodeSPrint ( - Buffer, - sizeof (Buffer), - L"Private resources [%d]", - Index - ); + for (Index =3D 0; Index < *NumberOfPrivateResources; Index++) { + if (AssertMemberIntegrity (Offset, sizeof (UINT32), Ptr, Length)) { + return; + } =20 - PrintFieldName (4, Buffer); - Print ( - L"0x%x\n", - *((UINT32*)(Ptr + Offset)) - ); + PrintFieldName (4, L"Private resources [%d]", Index); + AcpiInfo (L"0x%x", *(UINT32 *) (Ptr + Offset)); =20 Offset +=3D sizeof (UINT32); - Index++; } } =20 @@ -386,7 +322,6 @@ ParseAcpiPptt ( ) { UINT32 Offset; - UINT8* ProcessorTopologyStructurePtr; =20 if (!Trace) { return; @@ -401,15 +336,13 @@ ParseAcpiPptt ( PARSER_PARAMS (PpttParser) ); =20 - ProcessorTopologyStructurePtr =3D Ptr + Offset; - while (Offset < AcpiTableLength) { // Parse Processor Hierarchy Node Structure to obtain Type and Length. ParseAcpi ( FALSE, 0, NULL, - ProcessorTopologyStructurePtr, + Ptr + Offset, AcpiTableLength - Offset, PARSER_PARAMS (ProcessorTopologyStructureHeaderParser) ); @@ -418,62 +351,42 @@ ParseAcpiPptt ( // successfully read. if ((ProcessorTopologyStructureType =3D=3D NULL) || (ProcessorTopologyStructureLength =3D=3D NULL)) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient remaining table buffer length to read the " = \ - L"processor topology structure header. Length =3D %d.\n", - AcpiTableLength - Offset - ); + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse processor topology"); return; } =20 // Validate Processor Topology Structure length - if ((*ProcessorTopologyStructureLength =3D=3D 0) || - ((Offset + (*ProcessorTopologyStructureLength)) > AcpiTableLength)= ) { - IncrementErrorCount (); - Print ( - L"ERROR: Invalid Processor Topology Structure length. " \ - L"Length =3D %d. Offset =3D %d. AcpiTableLength =3D %d.\n", - *ProcessorTopologyStructureLength, - Offset, - AcpiTableLength - ); + if (AssertMemberIntegrity ( + Offset, *ProcessorTopologyStructureLength, Ptr, AcpiTableLength)= ) { return; } =20 PrintFieldName (2, L"* Structure Offset *"); - Print (L"0x%x\n", Offset); + AcpiInfo (L"0x%x", Offset); =20 switch (*ProcessorTopologyStructureType) { case EFI_ACPI_6_2_PPTT_TYPE_PROCESSOR: DumpProcessorHierarchyNodeStructure ( - ProcessorTopologyStructurePtr, + Ptr + Offset, *ProcessorTopologyStructureLength ); break; case EFI_ACPI_6_2_PPTT_TYPE_CACHE: DumpCacheTypeStructure ( - ProcessorTopologyStructurePtr, + Ptr + Offset, *ProcessorTopologyStructureLength ); break; case EFI_ACPI_6_2_PPTT_TYPE_ID: DumpIDStructure ( - ProcessorTopologyStructurePtr, + Ptr + Offset, *ProcessorTopologyStructureLength ); break; default: - IncrementErrorCount (); - Print ( - L"ERROR: Unknown processor topology structure:" - L" Type =3D %d, Length =3D %d\n", - *ProcessorTopologyStructureType, - *ProcessorTopologyStructureLength - ); + AcpiError (ACPI_ERROR_VALUE, L"Unknown processor topology structur= e"); } =20 - ProcessorTopologyStructurePtr +=3D *ProcessorTopologyStructureLength; Offset +=3D *ProcessorTopologyStructureLength; } // while } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/Rsdp= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpPa= rser.c index f4a8732a7db7..16dbab118795 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.= c @@ -11,6 +11,7 @@ #include #include "AcpiParser.h" #include "AcpiTableParser.h" +#include "AcpiViewLog.h" =20 // Local Variables STATIC CONST UINT64* XsdtAddress; @@ -38,15 +39,8 @@ ValidateRsdtAddress ( // XsdtAddresss MUST be a valid, non-null, 64-bit value. UINT32 RsdtAddr; =20 - RsdtAddr =3D *(UINT32*)Ptr; - - if (RsdtAddr !=3D 0) { - IncrementErrorCount (); - Print ( - L"\nERROR: Rsdt Address =3D 0x%p. This must be NULL on ARM Platforms= .", - RsdtAddr - ); - } + RsdtAddr =3D *(UINT32 *) Ptr; + AssertConstraint (L"ARM", RsdtAddr =3D=3D 0); #endif } =20 @@ -73,15 +67,8 @@ ValidateXsdtAddress ( // XsdtAddresss MUST be a valid, non-null, 64-bit value. UINT64 XsdtAddr; =20 - XsdtAddr =3D *(UINT64*)Ptr; - - if (XsdtAddr =3D=3D 0) { - IncrementErrorCount (); - Print ( - L"\nERROR: Xsdt Address =3D 0x%p. This must not be NULL on ARM Platf= orms.", - XsdtAddr - ); - } + XsdtAddr =3D *(UINT64 *) Ptr; + AssertConstraint (L"ARM", XsdtAddr !=3D 0); #endif } =20 @@ -141,12 +128,7 @@ ParseAcpiRsdp ( // Check if the values used to control the parsing logic have been // successfully read. if (XsdtAddress =3D=3D NULL) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient table length. AcpiTableLength =3D %d." \ - L"RSDP parsing aborted.\n", - AcpiTableLength - ); + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse the RSDP table"); return; } =20 @@ -154,11 +136,11 @@ ParseAcpiRsdp ( // and does not parse the RSDT table. Platforms provide the // RSDT to enable compatibility with ACPI 1.0 operating systems. // Therefore the RSDT should not be used on ARM platforms. - if ((*XsdtAddress) =3D=3D 0) { - IncrementErrorCount (); - Print (L"ERROR: XSDT Pointer is not set. RSDP parsing aborted.\n"); + if (*XsdtAddress =3D=3D 0) { + AcpiError ( + ACPI_ERROR_VALUE, L"XSDT Pointer is not set. RSDP parsing aborted.")= ; return; } =20 - ProcessAcpiTable ((UINT8*)(UINTN)(*XsdtAddress)); + ProcessAcpiTable ((VOID *)(UINTN) *XsdtAddress); } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/Slit= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitPa= rser.c index cedfc8a71849..5f3207f5827c 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.= c @@ -29,9 +29,11 @@ STATIC CONST ACPI_PARSER SlitParser[] =3D { }; =20 /** - Macro to get the value of a System Locality + Macro to get the value of a System Locality, simple + 2D variable size array item retrieval **/ -#define SLIT_ELEMENT(Ptr, i, j) *(Ptr + (i * LocalityCount) + j) +#define SLIT_ELEMENT(ArrayPtr, RowSize, Row, Column) \ + *((ArrayPtr) + ((Row) * (RowSize)) + (Column)) =20 /** This function parses the ACPI SLIT table. @@ -58,11 +60,11 @@ ParseAcpiSlit ( ) { UINT32 Offset; - UINT32 Count; - UINT32 Index; + UINT32 Index1; + UINT32 Index2; UINT32 LocalityCount; - UINT8* LocalityPtr; - CHAR16 Buffer[80]; // Used for AsciiName param of ParseAcpi + CHAR16 Buffer[256]; + UINTN StrLen; =20 if (!Trace) { return; @@ -80,11 +82,7 @@ ParseAcpiSlit ( // Check if the values used to control the parsing logic have been // successfully read. if (SlitSystemLocalityCount =3D=3D NULL) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient table length. AcpiTableLength =3D %d.\n", - AcpiTableLength - ); + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse the SLIT table"); return; } =20 @@ -100,89 +98,65 @@ ParseAcpiSlit ( =3D 65535 =3D MAX_UINT16 */ - if (*SlitSystemLocalityCount > MAX_UINT16) { - IncrementErrorCount (); - Print ( - L"ERROR: The Number of System Localities provided can't be represent= ed " \ - L"in the SLIT table. SlitSystemLocalityCount =3D %ld. " \ - L"MaxLocalityCountAllowed =3D %d.\n", - *SlitSystemLocalityCount, - MAX_UINT16 - ); + if (AssertConstraint (L"ACPI", *SlitSystemLocalityCount <=3D MAX_UINT16)= ) { return; } =20 - LocalityCount =3D (UINT32)*SlitSystemLocalityCount; + LocalityCount =3D (UINT32) *SlitSystemLocalityCount; =20 // Make sure system localities fit in the table buffer provided - if (Offset + (LocalityCount * LocalityCount) > AcpiTableLength) { - IncrementErrorCount (); - Print ( - L"ERROR: Invalid Number of System Localities. " \ - L"SlitSystemLocalityCount =3D %ld. AcpiTableLength =3D %d.\n", - *SlitSystemLocalityCount, - AcpiTableLength - ); + if (AssertMemberIntegrity ( + Offset, (LocalityCount * LocalityCount), Ptr, AcpiTableLength)) { return; } =20 - LocalityPtr =3D Ptr + Offset; - // We only print the Localities if the count is less than 16 // If the locality count is more than 16 then refer to the // raw data dump. if (LocalityCount < 16) { - UnicodeSPrint ( - Buffer, - sizeof (Buffer), - L"Entry[0x%lx][0x%lx]", - LocalityCount, - LocalityCount - ); - PrintFieldName (0, Buffer); - Print (L"\n"); - Print (L" "); - for (Index =3D 0; Index < LocalityCount; Index++) { - Print (L" (%3d) ", Index); + PrintFieldName (0, L"Entry[0x%lx][0x%lx]", LocalityCount, LocalityCoun= t); + AcpiInfo (L""); + UnicodeSPrint (Buffer, sizeof (Buffer), L" "); + for (Index1 =3D 0; Index1 < LocalityCount; Index1++) { + StrLen =3D StrnLenS (Buffer, sizeof (Buffer)); + UnicodeSPrint ( + Buffer + StrLen, sizeof (Buffer) - StrLen, L" (%3d) ", Index1); } - Print (L"\n"); - for (Count =3D 0; Count< LocalityCount; Count++) { - Print (L" (%3d) ", Count); - for (Index =3D 0; Index < LocalityCount; Index++) { - Print (L" %3d ", SLIT_ELEMENT (LocalityPtr, Count, Index)); + AcpiInfo (L"%s", Buffer); + + for (Index1 =3D 0; Index1 < LocalityCount; Index1++) { + UnicodeSPrint (Buffer, sizeof (Buffer), L" (%3d) ", Index1); + for (Index2 =3D 0; Index2 < LocalityCount; Index2++) { + StrLen =3D StrnLenS (Buffer, sizeof (Buffer)); + UnicodeSPrint ( + Buffer + StrLen, + sizeof (Buffer) - StrLen, + L" %3d ", + SLIT_ELEMENT(Ptr + Offset, LocalityCount, Index1, Index2)); } - Print (L"\n"); + AcpiInfo (L"%s", Buffer); } } =20 // Validate - for (Count =3D 0; Count < LocalityCount; Count++) { - for (Index =3D 0; Index < LocalityCount; Index++) { - // Element[x][x] must be equal to 10 - if ((Count =3D=3D Index) && (SLIT_ELEMENT (LocalityPtr, Count,Index)= !=3D 10)) { - IncrementErrorCount (); - Print ( - L"ERROR: Diagonal Element[0x%lx][0x%lx] (%3d)." - L" Normalized Value is not 10\n", - Count, - Index, - SLIT_ELEMENT (LocalityPtr, Count, Index) - ); - } + for (Index1 =3D 0; Index1 < LocalityCount; Index1++) { + // Element[x][x] must be equal to 10 + if (SLIT_ELEMENT(Ptr + Offset, LocalityCount, Index1, Index1) !=3D 10)= { + AcpiError ( + ACPI_ERROR_VALUE, L"SLIT Element[%d][%d] !=3D 10", Index1, Index1)= ; + } + for (Index2 =3D 0; Index2 < Index1; Index2++) { // Element[i][j] must be equal to Element[j][i] - if (SLIT_ELEMENT (LocalityPtr, Count, Index) !=3D - SLIT_ELEMENT (LocalityPtr, Index, Count)) { - IncrementErrorCount (); - Print ( - L"ERROR: Relative distances for Element[0x%lx][0x%lx] (%3d) and = \n" - L"Element[0x%lx][0x%lx] (%3d) do not match.\n", - Count, - Index, - SLIT_ELEMENT (LocalityPtr, Count, Index), - Index, - Count, - SLIT_ELEMENT (LocalityPtr, Index, Count) - ); + if ( + SLIT_ELEMENT(Ptr + Offset, LocalityCount, Index1, Index2) !=3D + SLIT_ELEMENT(Ptr + Offset, LocalityCount, Index2, Index1)) { + AcpiError ( + ACPI_ERROR_VALUE, + L"SLIT Element[%d][%d] !=3D SLIT Element[%d][%d]", + Index1, + Index2, + Index2, + Index1); } } } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/Spcr= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrPa= rser.c index 3b06b05dee8c..fa611d4b37c2 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser.= c @@ -14,6 +14,7 @@ #include #include "AcpiParser.h" #include "AcpiTableParser.h" +#include "AcpiViewLog.h" =20 // Local variables STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; @@ -37,15 +38,10 @@ ValidateInterruptType ( UINT8 InterruptType; =20 InterruptType =3D *Ptr; - - if (InterruptType !=3D - EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERRUPT_TYPE_GIC)= { - IncrementErrorCount (); - Print ( - L"\nERROR: InterruptType =3D %d. This must be 8 on ARM Platforms", - InterruptType - ); - } + AssertConstraint ( + L"ARM", + InterruptType =3D=3D + EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERRUPT_TYPE_GIC); #endif } =20 @@ -68,14 +64,7 @@ ValidateIrq ( UINT8 Irq; =20 Irq =3D *Ptr; - - if (Irq !=3D 0) { - IncrementErrorCount (); - Print ( - L"\nERROR: Irq =3D %d. This must be zero on ARM Platforms\n", - Irq - ); - } + AssertConstraint (L"ARM", Irq =3D=3D 0); #endif } =20 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/Srat= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratPa= rser.c index 568a0400bf07..1954b18298b9 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.= c @@ -37,10 +37,10 @@ ValidateSratReserved ( IN VOID* Context ) { - if (*(UINT32*)Ptr !=3D 1) { - IncrementErrorCount (); - Print (L"\nERROR: Reserved should be 1 for backward compatibility.\n")= ; - } + UINT32 Reserved; + + Reserved =3D *(UINT32 *) Ptr; + AssertConstraint (L"Backwards-Compatibility", Reserved =3D=3D 1); } =20 /** @@ -59,18 +59,10 @@ ValidateSratDeviceHandleType ( IN VOID* Context ) { - UINT8 DeviceHandleType; + UINT8 DeviceHandleType; =20 DeviceHandleType =3D *Ptr; - - if (DeviceHandleType > EFI_ACPI_6_3_PCI_DEVICE_HANDLE) { - IncrementErrorCount (); - Print ( - L"\nERROR: Invalid Device Handle Type: %d. Must be between 0 and %d.= ", - DeviceHandleType, - EFI_ACPI_6_3_PCI_DEVICE_HANDLE - ); - } + AssertConstraint (L"ACPI", DeviceHandleType < EFI_ACPI_6_3_PCI_DEVICE_HA= NDLE); } =20 /** @@ -87,9 +79,9 @@ DumpSratPciBdfNumber ( IN UINT8* Ptr ) { - CHAR16 Buffer[OUTPUT_FIELD_COLUMN_WIDTH]; - - Print (L"\n"); + UINT16 Bus; + UINT16 Device; + UINT16 Function; =20 /* The PCI BDF Number subfields are printed in the order specified in the= ACPI @@ -102,43 +94,13 @@ DumpSratPciBdfNumber ( +-----+------+------+ */ =20 + Bus =3D BitFieldRead16(*(UINT16 *) Ptr, 0, 7); + Device =3D BitFieldRead16(*(UINT16 *) Ptr, 8, 10); + Function =3D BitFieldRead16(*(UINT16 *) Ptr, 11, 15); + // Print PCI Bus Number (Bits 7:0 of Byte 2) - UnicodeSPrint ( - Buffer, - sizeof (Buffer), - L"PCI Bus Number" - ); - PrintFieldName (4, Buffer); - Print ( - L"0x%x\n", - *Ptr - ); - - Ptr++; - - // Print PCI Device Number (Bits 7:3 of Byte 3) - UnicodeSPrint ( - Buffer, - sizeof (Buffer), - L"PCI Device Number" - ); - PrintFieldName (4, Buffer); - Print ( - L"0x%x\n", - (*Ptr & (BIT7 | BIT6 | BIT5 | BIT4 | BIT3)) >> 3 - ); - - // PCI Function Number (Bits 2:0 of Byte 3) - UnicodeSPrint ( - Buffer, - sizeof (Buffer), - L"PCI Function Number" - ); - PrintFieldName (4, Buffer); - Print ( - L"0x%x\n", - *Ptr & (BIT2 | BIT1 | BIT0) - ); + PrintFieldName (4, L"PCI Bus:Device.Function"); + AcpiInfo (L"%4X:%2X.%d", Bus, Device, Function); } =20 /** @@ -176,8 +138,7 @@ DumpSratDeviceHandle ( ) { if (SratDeviceHandleType =3D=3D NULL) { - IncrementErrorCount (); - Print (L"\nERROR: Device Handle Type read incorrectly.\n"); + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse Device Handle"); return; } =20 @@ -222,7 +183,7 @@ DumpSratApicProximity ( =20 ProximityDomain =3D Ptr[0] | (Ptr[1] << 8) | (Ptr[2] << 16); =20 - Print (Format, ProximityDomain); + AcpiInfo ((CHAR16 *)Format, ProximityDomain); } =20 /** @@ -360,7 +321,6 @@ ParseAcpiSrat ( ) { UINT32 Offset; - UINT8* ResourcePtr; UINT32 GicCAffinityIndex; UINT32 GicITSAffinityIndex; UINT32 GenericInitiatorAffinityIndex; @@ -389,155 +349,113 @@ ParseAcpiSrat ( PARSER_PARAMS (SratParser) ); =20 - ResourcePtr =3D Ptr + Offset; - while (Offset < AcpiTableLength) { ParseAcpi ( FALSE, 0, NULL, - ResourcePtr, + Ptr + Offset, AcpiTableLength - Offset, PARSER_PARAMS (SratResourceAllocationParser) ); =20 // Check if the values used to control the parsing logic have been // successfully read. - if ((SratRAType =3D=3D NULL) || - (SratRALength =3D=3D NULL)) { - IncrementErrorCount (); - Print ( - L"ERROR: Insufficient remaining table buffer length to read the " = \ - L"Static Resource Allocation structure header. Length =3D %d.\n"= , - AcpiTableLength - Offset - ); + if ((SratRAType =3D=3D NULL) || (SratRALength =3D=3D NULL)) { + AcpiError (ACPI_ERROR_PARSE, L"Failed to parse SRAT header"); return; } =20 // Validate Static Resource Allocation Structure length - if ((*SratRALength =3D=3D 0) || - ((Offset + (*SratRALength)) > AcpiTableLength)) { - IncrementErrorCount (); - Print ( - L"ERROR: Invalid Static Resource Allocation Structure length. " \ - L"Length =3D %d. Offset =3D %d. AcpiTableLength =3D %d.\n", - *SratRALength, - Offset, - AcpiTableLength - ); + if (AssertMemberIntegrity(Offset, *SratRALength, Ptr, AcpiTableLength)= ) { return; } =20 switch (*SratRAType) { case EFI_ACPI_6_3_GICC_AFFINITY: - AsciiSPrint ( - Buffer, - sizeof (Buffer), - "GICC Affinity Structure [%d]", - GicCAffinityIndex++ - ); + AcpiLog ( + ACPI_ITEM, L"GICC Affinity Structure [%d]", GicCAffinityIndex++)= ; ParseAcpi ( TRUE, 2, Buffer, - ResourcePtr, + Ptr + Offset, *SratRALength, - PARSER_PARAMS (SratGicCAffinityParser) - ); + PARSER_PARAMS (SratGicCAffinityParser)); break; =20 case EFI_ACPI_6_3_GIC_ITS_AFFINITY: - AsciiSPrint ( - Buffer, - sizeof (Buffer), - "GIC ITS Affinity Structure [%d]", - GicITSAffinityIndex++ - ); + AcpiLog ( + ACPI_ITEM, L"GIC ITS Affinity Structure [%d]", GicITSAffinityInd= ex++); ParseAcpi ( TRUE, 2, Buffer, - ResourcePtr, + Ptr + Offset, *SratRALength, - PARSER_PARAMS (SratGicITSAffinityParser) - ); + PARSER_PARAMS (SratGicITSAffinityParser)); break; =20 case EFI_ACPI_6_3_GENERIC_INITIATOR_AFFINITY: - AsciiSPrint ( - Buffer, - sizeof (Buffer), - "Generic Initiator Affinity Structure [%d]", - GenericInitiatorAffinityIndex++ - ); + AcpiLog ( + ACPI_ITEM, + L"Generic Initiator Affinity Structure [%d]", + GenericInitiatorAffinityIndex++); ParseAcpi ( TRUE, 2, Buffer, - ResourcePtr, + Ptr + Offset, *SratRALength, - PARSER_PARAMS (SratGenericInitiatorAffinityParser) - ); + PARSER_PARAMS (SratGenericInitiatorAffinityParser)); break; =20 case EFI_ACPI_6_3_MEMORY_AFFINITY: - AsciiSPrint ( - Buffer, - sizeof (Buffer), - "Memory Affinity Structure [%d]", - MemoryAffinityIndex++ - ); + AcpiLog ( + ACPI_ITEM, L"Memory Affinity Structure [%d]", MemoryAffinityInde= x++); ParseAcpi ( TRUE, 2, Buffer, - ResourcePtr, + Ptr + Offset, *SratRALength, - PARSER_PARAMS (SratMemAffinityParser) - ); + PARSER_PARAMS (SratMemAffinityParser)); break; =20 case EFI_ACPI_6_3_PROCESSOR_LOCAL_APIC_SAPIC_AFFINITY: - AsciiSPrint ( - Buffer, - sizeof (Buffer), - "APIC/SAPIC Affinity Structure [%d]", - ApicSapicAffinityIndex++ - ); + AcpiLog ( + ACPI_ITEM, + L"APIC/SAPIC Affinity Structure [%d]", + ApicSapicAffinityIndex++); ParseAcpi ( TRUE, 2, Buffer, - ResourcePtr, + Ptr + Offset, *SratRALength, - PARSER_PARAMS (SratApciSapicAffinityParser) - ); + PARSER_PARAMS (SratApciSapicAffinityParser)); break; =20 case EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC_AFFINITY: - AsciiSPrint ( - Buffer, - sizeof (Buffer), - "X2APIC Affinity Structure [%d]", - X2ApicAffinityIndex++ - ); + AcpiLog ( + ACPI_ITEM, L"X2APIC Affinity Structure [%d]", X2ApicAffinityInde= x++); ParseAcpi ( TRUE, 2, Buffer, - ResourcePtr, + Ptr + Offset, *SratRALength, - PARSER_PARAMS (SratX2ApciAffinityParser) - ); + PARSER_PARAMS (SratX2ApciAffinityParser)); break; =20 default: - IncrementErrorCount (); - Print (L"ERROR: Unknown SRAT Affinity type =3D 0x%x\n", *SratRATyp= e); + AcpiError ( + ACPI_ERROR_VALUE, + L"Unknown SRAT Affinity type =3D 0x%x\n", + *SratRAType); break; } =20 - ResourcePtr +=3D (*SratRALength); Offset +=3D (*SratRALength); } } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/Xsdt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtPa= rser.c index 771c4f322b8e..77031183782d 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.= c @@ -29,9 +29,7 @@ STATIC CONST ACPI_PARSER XsdtParser[] =3D { **/ CONST ACPI_DESCRIPTION_HEADER_INFO * EFIAPI -GetAcpiXsdtHeaderInfo ( - VOID -) +GetAcpiXsdtHeaderInfo (VOID) { return &AcpiHdrInfo; } @@ -55,87 +53,43 @@ ParseAcpiXsdt ( IN UINT8 AcpiTableRevision ) { - UINT32 Offset; UINT32 TableOffset; - UINT64* TablePointer; + UINT64** TablePointer; UINTN EntryIndex; - CHAR16 Buffer[32]; =20 - Offset =3D ParseAcpi ( - Trace, - 0, - "XSDT", - Ptr, - AcpiTableLength, - PARSER_PARAMS (XsdtParser) - ); - - TableOffset =3D Offset; + TableOffset =3D ParseAcpi ( + Trace, 0, "XSDT", Ptr, AcpiTableLength, PARSER_PARAMS (XsdtParser)); =20 + EntryIndex =3D 0; if (Trace) { - EntryIndex =3D 0; - TablePointer =3D (UINT64*)(Ptr + TableOffset); - while (Offset < AcpiTableLength) { + for (TablePointer =3D (UINT64 **)(Ptr + TableOffset); + (UINT8 *) TablePointer < Ptr + AcpiTableLength; + TablePointer++) { + CONST UINT32* Signature; CONST UINT32* Length; CONST UINT8* Revision; =20 - if ((UINT64*)(UINTN)(*TablePointer) !=3D NULL) { - UINT8* SignaturePtr; - - ParseAcpiHeader ( - (UINT8*)(UINTN)(*TablePointer), - &Signature, - &Length, - &Revision - ); - - SignaturePtr =3D (UINT8*)Signature; - - UnicodeSPrint ( - Buffer, - sizeof (Buffer), - L"Entry[%d] - %c%c%c%c", - EntryIndex++, - SignaturePtr[0], - SignaturePtr[1], - SignaturePtr[2], - SignaturePtr[3] - ); + if (*TablePointer !=3D NULL) { + ParseAcpiHeader (*TablePointer, &Signature, &Length, &Revision); + PrintFieldName (2, L"Entry[%d] - %.4a", EntryIndex++, Signature); + AcpiInfo (L"0x%lx", *TablePointer); } else { - UnicodeSPrint ( - Buffer, - sizeof (Buffer), - L"Entry[%d]", - EntryIndex++ - ); - } - - PrintFieldName (2, Buffer); - Print (L"0x%lx\n", *TablePointer); - - // Validate the table pointers are not NULL - if ((UINT64*)(UINTN)(*TablePointer) =3D=3D NULL) { - IncrementErrorCount (); - Print ( - L"ERROR: Invalid table entry at 0x%lx, table address is 0x%lx\n"= , - TablePointer, - *TablePointer - ); + PrintFieldName (2, L"Entry[%d]", EntryIndex++); + AcpiInfo (L"NULL"); + AcpiError (ACPI_ERROR_VALUE, L"Invalid table entry"); } - Offset +=3D sizeof (UINT64); - TablePointer++; - } // while + } } =20 // Process the tables - Offset =3D TableOffset; - TablePointer =3D (UINT64*)(Ptr + TableOffset); - while (Offset < AcpiTableLength) { - if ((UINT64*)(UINTN)(*TablePointer) !=3D NULL) { - ProcessAcpiTable ((UINT8*)(UINTN)(*TablePointer)); + for (TablePointer =3D (UINT64 **)(Ptr + TableOffset); + (UINT8 *) TablePointer < Ptr + AcpiTableLength; + TablePointer++) { + + if (*TablePointer !=3D NULL) { + ProcessAcpiTable (*TablePointer); } - Offset +=3D sizeof (UINT64); - TablePointer++; - } // while + + } } --=20 2.24.1.windows.2