From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by mx.groups.io with SMTP id smtpd.web10.15164.1594628729091290840 for ; Mon, 13 Jul 2020 01:25:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=KJqcf7fo; spf=pass (domain: 9elements.com, ip: 209.85.208.66, mailfrom: marcello.bauer@9elements.com) Received: by mail-ed1-f66.google.com with SMTP id dg28so12370979edb.3 for ; Mon, 13 Jul 2020 01:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JED/Pcris87ofgE99R0KJo2nz/djnJCVLEFSAeJhGQY=; b=KJqcf7fo+6rZwTLWb2+/uUZHU+dwQxjB+uH2csLYzA6cXV5wL6/nzsO8JwKrzRfTQv +YH4s38UzxHjZeUxim8OWcs87E91PASKEqHI27exb5p9RH4VwJQdFtDeUDeGyOSolhML w3vAY0G3P2LdLHg9hqSIFOKyWgl2rFRW7bdWqbPLfDcYFYdUAllapsBR7V1fqwe0S7RQ uQkrT9fEnhyBmhNVo0h/WPb8/LUq6hzivgz7FIV2s2yCZVu7lQRcn8eANxV/jvsgsuCt OtN25UFxHjQHekgY4UVm4ZSiL2rYRDmNqfDCSoODY4u+dMrzxp1PODLCLHKoXZJFiYJJ uzQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JED/Pcris87ofgE99R0KJo2nz/djnJCVLEFSAeJhGQY=; b=NkPZ9p9Vmi8CS7PX25QE7I9D0ZcN6Jufuas2CQHbsRoaalATv69+SwlbonyICxFchq zMyk8Qx588ZvqSNgVhP/gPLbV0fLuncTyxg/5dkdr38b/S1o3MwZrXYASQAHepnidXOF JWFPhTms3rxh/FkDlvLvlfHXg0f3ntM3CZgsJK51s0nnuDlzOIdNqK2e2LD4kNBCBds5 xv2hwKc4DaYf06vlXoe1L4u98TD04f9QwO5YIFzwzBiHzUd1a4WXW+0r00JdYfabbcpP XfqwFFX19QKca5IZMvRD7zMJ2UEnoGEIkNz8AwF69F4dnsnXsEqaCbcbknkbiZ86GFHe La2A== X-Gm-Message-State: AOAM532gmfx/WAkRR1XY1jfZ90t4B5VaPCKTmdToqGbL1yt2rLUNwz8z EUq0/m0BFjWgrH1s4pzrVFEe0jtOYBQ= X-Google-Smtp-Source: ABdhPJwu+J6yHq/h8Z/HaE2EP7FW+oUEDofM6jFJUQyQyd4KnX9/J4HMenUBabL/T4pol45iNDdwUA== X-Received: by 2002:a05:6402:3064:: with SMTP id bs4mr91785394edb.350.1594628727369; Mon, 13 Jul 2020 01:25:27 -0700 (PDT) Return-Path: Received: from T580.dut.n1ce.space ([2a02:908:e851:d750:f570:655a:1f30:429f]) by smtp.gmail.com with ESMTPSA id cd11sm9175219ejb.57.2020.07.13.01.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 01:25:26 -0700 (PDT) From: "Marcello Sylvester Bauer" To: devel@edk2.groups.io Cc: Patrick Rudolph , Christian Walter , Maurice Ma , Nate DeSimone , Star Zeng Subject: [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults Date: Mon, 13 Jul 2020 10:25:22 +0200 Message-Id: <20200713082522.5168-2-marcello.bauer@9elements.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200713082522.5168-1-marcello.bauer@9elements.com> References: <20200713082522.5168-1-marcello.bauer@9elements.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Patrick Rudolph The BaseSerialPortLib16550 does fallback to a fixed address UART defined by PcdSerialRegisterBase and does not initialize if it is zero. Do not assume a serial port at 0x3F8, otherwise it could cause errors during initialisation of a non-existent serial port on non legacy platforms. Signed-off-by: Patrick Rudolph Signed-off-by: Marcello Sylvester Bauer Cc: Patrick Rudolph Cc: Christian Walter Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng --- UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 +- UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc b/UefiPayloadPkg/UefiPay= loadPkgIa32.dsc index 0efcfa8fb2f4..0d8854810700 100644 --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc @@ -306,7 +306,7 @@ [PcdsPatchableInModule.common] # The following parameters are set by Library/PlatformHookLib=0D #=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE=0D - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8=0D + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1=0D =0D diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc b/UefiPayloadPkg/Uefi= PayloadPkgIa32X64.dsc index d645d233cd08..34640b1fc1da 100644 --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc @@ -307,7 +307,7 @@ [PcdsPatchableInModule.common] # The following parameters are set by Library/PlatformHookLib=0D #=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE=0D - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8=0D + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1=0D =0D --=20 2.27.0