* [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
2020-07-13 8:25 [PATCH v2 0/1] " Marcello Sylvester Bauer
@ 2020-07-13 8:25 ` Marcello Sylvester Bauer
2020-07-13 15:27 ` Ma, Maurice
0 siblings, 1 reply; 4+ messages in thread
From: Marcello Sylvester Bauer @ 2020-07-13 8:25 UTC (permalink / raw)
To: devel
Cc: Patrick Rudolph, Christian Walter, Maurice Ma, Nate DeSimone,
Star Zeng
From: Patrick Rudolph <patrick.rudolph@9elements.com>
The BaseSerialPortLib16550 does fallback to a fixed address UART defined
by PcdSerialRegisterBase and does not initialize if it is zero. Do not
assume a serial port at 0x3F8, otherwise it could cause errors during
initialisation of a non-existent serial port on non legacy platforms.
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: Christian Walter <christian.walter@9elements.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 +-
UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
index 0efcfa8fb2f4..0d8854810700 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
@@ -306,7 +306,7 @@ [PcdsPatchableInModule.common]
# The following parameters are set by Library/PlatformHookLib
#
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
- gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
index d645d233cd08..34640b1fc1da 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
@@ -307,7 +307,7 @@ [PcdsPatchableInModule.common]
# The following parameters are set by Library/PlatformHookLib
#
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
- gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
2020-07-13 8:25 ` [PATCH v2 1/1] UefiPayloadPkg: " Marcello Sylvester Bauer
@ 2020-07-13 15:27 ` Ma, Maurice
0 siblings, 0 replies; 4+ messages in thread
From: Ma, Maurice @ 2020-07-13 15:27 UTC (permalink / raw)
To: Marcello Sylvester Bauer, devel@edk2.groups.io
Cc: Patrick Rudolph, Christian Walter, Desimone, Nathaniel L,
Zeng, Star
As I mentioned in the previous comments, could you please CC all UefiPayloadPkg maintainers listed in the Maintainers.txt under the root of the EDK2 directory for code changes in UefiPayloadPkg ?
Other than that, this patch looks good to me.
Reviewed-by: Maurice Ma <maurice.ma@intel.com>
Thanks
Maurice
> -----Original Message-----
> From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Sent: Monday, July 13, 2020 1:25
> To: devel@edk2.groups.io
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>; Christian Walter
> <christian.walter@9elements.com>; Ma, Maurice <maurice.ma@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
>
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>
> The BaseSerialPortLib16550 does fallback to a fixed address UART defined by
> PcdSerialRegisterBase and does not initialize if it is zero. Do not assume a serial
> port at 0x3F8, otherwise it could cause errors during initialisation of a non-
> existent serial port on non legacy platforms.
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
> Cc: Christian Walter <christian.walter@9elements.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 +-
> UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> index 0efcfa8fb2f4..0d8854810700 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> @@ -306,7 +306,7 @@ [PcdsPatchableInModule.common]
> # The following parameters are set by Library/PlatformHookLib #
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE-
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8+
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1 diff --git
> a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> index d645d233cd08..34640b1fc1da 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> @@ -307,7 +307,7 @@ [PcdsPatchableInModule.common]
> # The following parameters are set by Library/PlatformHookLib #
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE-
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8+
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1 --
> 2.27.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 0/1] Remove x86 legacy UART defaults
@ 2020-07-13 16:37 Marcello Sylvester Bauer
2020-07-13 16:37 ` [PATCH v2 1/1] UefiPayloadPkg: " Marcello Sylvester Bauer
0 siblings, 1 reply; 4+ messages in thread
From: Marcello Sylvester Bauer @ 2020-07-13 16:37 UTC (permalink / raw)
To: devel
Do not fallback to a fixed UART base address, otherwise it can cause
errors during initialisation of a non-existent serial port non legacy platforms.
(Resent because of missing CC)
v2:
* extend commit message
* add all Maintainer
Patrick Rudolph (1):
UefiPayloadPkg: Remove x86 legacy UART defaults
UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 +-
UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.27.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
2020-07-13 16:37 [PATCH v2 0/1] Remove x86 legacy UART defaults Marcello Sylvester Bauer
@ 2020-07-13 16:37 ` Marcello Sylvester Bauer
0 siblings, 0 replies; 4+ messages in thread
From: Marcello Sylvester Bauer @ 2020-07-13 16:37 UTC (permalink / raw)
To: devel
Cc: Patrick Rudolph, Christian Walter, Maurice Ma, Nate DeSimone,
Star Zeng
From: Patrick Rudolph <patrick.rudolph@9elements.com>
The BaseSerialPortLib16550 does fallback to a fixed address UART defined
by PcdSerialRegisterBase and does not initialize if it is zero. Do not
assume a serial port at 0x3F8, otherwise it could cause errors during
initialisation of a non-existent serial port on non legacy platforms.
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: Christian Walter <christian.walter@9elements.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 +-
UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
index 0efcfa8fb2f4..0d8854810700 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
@@ -306,7 +306,7 @@ [PcdsPatchableInModule.common]
# The following parameters are set by Library/PlatformHookLib
#
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
- gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
index d645d233cd08..34640b1fc1da 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
@@ -307,7 +307,7 @@ [PcdsPatchableInModule.common]
# The following parameters are set by Library/PlatformHookLib
#
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
- gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-13 16:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-13 16:37 [PATCH v2 0/1] Remove x86 legacy UART defaults Marcello Sylvester Bauer
2020-07-13 16:37 ` [PATCH v2 1/1] UefiPayloadPkg: " Marcello Sylvester Bauer
-- strict thread matches above, loose matches on Subject: below --
2020-07-13 8:25 [PATCH v2 0/1] " Marcello Sylvester Bauer
2020-07-13 8:25 ` [PATCH v2 1/1] UefiPayloadPkg: " Marcello Sylvester Bauer
2020-07-13 15:27 ` Ma, Maurice
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox